All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Woojung Huh <woojung.huh@microchip.com>,
	UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Wei Fang <wei.fang@nxp.com>,
	Heiner Kallweit <hkallweit1@gmail.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
	kernel@pengutronix.de, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, Arun.Ramadoss@microchip.com,
	intel-wired-lan@lists.osuosl.org
Subject: [PATCH net-next v5 03/23] net: phy: micrel: add ksz9477_get_features()
Date: Mon,  6 Feb 2023 14:50:30 +0100	[thread overview]
Message-ID: <20230206135050.3237952-4-o.rempel@pengutronix.de> (raw)
In-Reply-To: <20230206135050.3237952-1-o.rempel@pengutronix.de>

KSZ8563R, which has same PHYID as KSZ9477 family, will change "EEE control
and capability 1" (Register 3.20) content depending on configuration of
"EEE advertisement 1" (Register 7.60). Changes on the 7.60 will affect
3.20 register.

So, instead of depending on register 3.20, driver should set supported_eee.

Proper supported_eee configuration is needed to make use of generic
PHY c45 set/get_eee functions provided by next patches.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 drivers/net/phy/micrel.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index d5b80c31ab91..41eb8df6bfb9 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -1370,6 +1370,26 @@ static int ksz9131_config_aneg(struct phy_device *phydev)
 	return genphy_config_aneg(phydev);
 }
 
+static int ksz9477_get_features(struct phy_device *phydev)
+{
+	int ret;
+
+	ret = genphy_read_abilities(phydev);
+	if (ret)
+		return ret;
+
+	/* The "EEE control and capability 1" (Register 3.20) seems to be
+	 * influenced by the "EEE advertisement 1" (Register 7.60). Changes
+	 * on the 7.60 will affect 3.20. So, we need to construct our own list
+	 * of caps.
+	 * KSZ8563R should have 100BaseTX/Full only.
+	 */
+	linkmode_and(phydev->supported_eee, phydev->supported,
+		     PHY_EEE_CAP1_FEATURES);
+
+	return 0;
+}
+
 #define KSZ8873MLL_GLOBAL_CONTROL_4	0x06
 #define KSZ8873MLL_GLOBAL_CONTROL_4_DUPLEX	BIT(6)
 #define KSZ8873MLL_GLOBAL_CONTROL_4_SPEED	BIT(4)
@@ -3422,6 +3442,7 @@ static struct phy_driver ksphy_driver[] = {
 	.handle_interrupt = kszphy_handle_interrupt,
 	.suspend	= genphy_suspend,
 	.resume		= genphy_resume,
+	.get_features	= ksz9477_get_features,
 } };
 
 module_phy_driver(ksphy_driver);
-- 
2.30.2


WARNING: multiple messages have this Message-ID (diff)
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Woojung Huh <woojung.huh@microchip.com>,
	UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Wei Fang <wei.fang@nxp.com>,
	Heiner Kallweit <hkallweit1@gmail.com>
Cc: Arun.Ramadoss@microchip.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Oleksij Rempel <o.rempel@pengutronix.de>,
	intel-wired-lan@lists.osuosl.org, kernel@pengutronix.de
Subject: [Intel-wired-lan] [PATCH net-next v5 03/23] net: phy: micrel: add ksz9477_get_features()
Date: Mon,  6 Feb 2023 14:50:30 +0100	[thread overview]
Message-ID: <20230206135050.3237952-4-o.rempel@pengutronix.de> (raw)
In-Reply-To: <20230206135050.3237952-1-o.rempel@pengutronix.de>

KSZ8563R, which has same PHYID as KSZ9477 family, will change "EEE control
and capability 1" (Register 3.20) content depending on configuration of
"EEE advertisement 1" (Register 7.60). Changes on the 7.60 will affect
3.20 register.

So, instead of depending on register 3.20, driver should set supported_eee.

Proper supported_eee configuration is needed to make use of generic
PHY c45 set/get_eee functions provided by next patches.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 drivers/net/phy/micrel.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index d5b80c31ab91..41eb8df6bfb9 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -1370,6 +1370,26 @@ static int ksz9131_config_aneg(struct phy_device *phydev)
 	return genphy_config_aneg(phydev);
 }
 
+static int ksz9477_get_features(struct phy_device *phydev)
+{
+	int ret;
+
+	ret = genphy_read_abilities(phydev);
+	if (ret)
+		return ret;
+
+	/* The "EEE control and capability 1" (Register 3.20) seems to be
+	 * influenced by the "EEE advertisement 1" (Register 7.60). Changes
+	 * on the 7.60 will affect 3.20. So, we need to construct our own list
+	 * of caps.
+	 * KSZ8563R should have 100BaseTX/Full only.
+	 */
+	linkmode_and(phydev->supported_eee, phydev->supported,
+		     PHY_EEE_CAP1_FEATURES);
+
+	return 0;
+}
+
 #define KSZ8873MLL_GLOBAL_CONTROL_4	0x06
 #define KSZ8873MLL_GLOBAL_CONTROL_4_DUPLEX	BIT(6)
 #define KSZ8873MLL_GLOBAL_CONTROL_4_SPEED	BIT(4)
@@ -3422,6 +3442,7 @@ static struct phy_driver ksphy_driver[] = {
 	.handle_interrupt = kszphy_handle_interrupt,
 	.suspend	= genphy_suspend,
 	.resume		= genphy_resume,
+	.get_features	= ksz9477_get_features,
 } };
 
 module_phy_driver(ksphy_driver);
-- 
2.30.2

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

  parent reply	other threads:[~2023-02-06 13:51 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-06 13:50 [PATCH net-next v5 00/23] net: add EEE support for KSZ9477 and AR8035 with i.MX6 Oleksij Rempel
2023-02-06 13:50 ` [Intel-wired-lan] " Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 01/23] net: dsa: microchip: enable EEE support Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-07  0:44   ` Andrew Lunn
2023-02-07  0:44     ` [Intel-wired-lan] " Andrew Lunn
2023-02-06 13:50 ` [PATCH net-next v5 02/23] net: phy: add genphy_c45_read_eee_abilities() function Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-06 14:46   ` Arun.Ramadoss
2023-02-06 14:46     ` [Intel-wired-lan] " Arun.Ramadoss
2023-02-07  0:44   ` Andrew Lunn
2023-02-07  0:44     ` [Intel-wired-lan] " Andrew Lunn
2023-02-08  5:19   ` Jakub Kicinski
2023-02-08  5:19     ` [Intel-wired-lan] " Jakub Kicinski
2023-02-06 13:50 ` Oleksij Rempel [this message]
2023-02-06 13:50   ` [Intel-wired-lan] [PATCH net-next v5 03/23] net: phy: micrel: add ksz9477_get_features() Oleksij Rempel
2023-02-07  0:45   ` Andrew Lunn
2023-02-07  0:45     ` [Intel-wired-lan] " Andrew Lunn
2023-02-06 13:50 ` [PATCH net-next v5 04/23] net: phy: export phy_check_valid() function Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 05/23] net: phy: add genphy_c45_ethtool_get/set_eee() support Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-06 14:54   ` Arun.Ramadoss
2023-02-06 14:54     ` [Intel-wired-lan] " Arun.Ramadoss
2023-02-06 13:50 ` [PATCH net-next v5 06/23] net: phy: c22: migrate to genphy_c45_write_eee_adv() Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-07  0:52   ` Andrew Lunn
2023-02-07  0:52     ` [Intel-wired-lan] " Andrew Lunn
2023-02-06 13:50 ` [PATCH net-next v5 07/23] net: phy: c45: " Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-07  0:52   ` Andrew Lunn
2023-02-07  0:52     ` [Intel-wired-lan] " Andrew Lunn
2023-02-06 13:50 ` [PATCH net-next v5 08/23] net: phy: migrate phy_init_eee() to genphy_c45_eee_is_active() Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-07  0:54   ` Andrew Lunn
2023-02-07  0:54     ` [Intel-wired-lan] " Andrew Lunn
2023-02-06 13:50 ` [PATCH net-next v5 09/23] net: phy: start using genphy_c45_ethtool_get/set_eee() Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-07  1:05   ` Andrew Lunn
2023-02-07  1:05     ` [Intel-wired-lan] " Andrew Lunn
2023-02-06 13:50 ` [PATCH net-next v5 10/23] net: phy: add driver specific get/set_eee support Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 11/23] net: phy: at803x: implement ethtool access to SmartEEE functionality Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 12/23] net: phy: at803x: ar8035: fix EEE support for half duplex links Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 13/23] net: phy: add PHY specifica flag to signal SmartEEE support Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 14/23] net: phy: at803x: add PHY_SMART_EEE flag to AR8035 Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 15/23] net: phy: add phy_has_smarteee() helper Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-08  5:20   ` Jakub Kicinski
2023-02-08  5:20     ` [Intel-wired-lan] " Jakub Kicinski
2023-02-06 13:50 ` [PATCH net-next v5 16/23] net: fec: add support for PHYs with SmartEEE support Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 17/23] e1000e: replace EEE ethtool helpers to linkmode variants Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 18/23] igb: " Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 19/23] igc: " Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 20/23] tg3: " Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 21/23] r8152: " Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 22/23] net: usb: ax88179_178a: " Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-06 13:50 ` [PATCH net-next v5 23/23] net: mdio: drop EEE ethtool helpers in favor " Oleksij Rempel
2023-02-06 13:50   ` [Intel-wired-lan] " Oleksij Rempel
2023-02-08  5:25 ` [PATCH net-next v5 00/23] net: add EEE support for KSZ9477 and AR8035 with i.MX6 Jakub Kicinski
2023-02-08  5:25   ` [Intel-wired-lan] " Jakub Kicinski
2023-02-08  8:30   ` Oleksij Rempel
2023-02-08  8:30     ` [Intel-wired-lan] " Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230206135050.3237952-4-o.rempel@pengutronix.de \
    --to=o.rempel@pengutronix.de \
    --cc=Arun.Ramadoss@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=vivien.didelot@gmail.com \
    --cc=wei.fang@nxp.com \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.