All of lore.kernel.org
 help / color / mirror / Atom feed
From: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
To: Christian Borntraeger <borntraeger@linux.ibm.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Janis Schoetterl-Glausch <scgl@linux.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>,
	kvm@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-s390@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
	Shuah Khan <shuah@kernel.org>,
	Sven Schnelle <svens@linux.ibm.com>,
	Nico Boehr <nrb@linux.ibm.com>
Subject: [PATCH v7 04/14] KVM: s390: selftest: memop: Add bad address test
Date: Mon,  6 Feb 2023 17:45:52 +0100	[thread overview]
Message-ID: <20230206164602.138068-5-scgl@linux.ibm.com> (raw)
In-Reply-To: <20230206164602.138068-1-scgl@linux.ibm.com>

Add a test that tries a real write to a bad address.
The existing CHECK_ONLY test doesn't cover all paths.

Signed-off-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
Reviewed-by: Nico Boehr <nrb@linux.ibm.com>
---
 tools/testing/selftests/kvm/s390x/memop.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/kvm/s390x/memop.c b/tools/testing/selftests/kvm/s390x/memop.c
index bbc191a13760..00737cceacda 100644
--- a/tools/testing/selftests/kvm/s390x/memop.c
+++ b/tools/testing/selftests/kvm/s390x/memop.c
@@ -641,7 +641,9 @@ static void _test_errors_common(struct test_info info, enum mop_target target, i
 
 	/* Bad guest address: */
 	rv = ERR_MOP(info, target, WRITE, mem1, size, GADDR((void *)~0xfffUL), CHECK_ONLY);
-	TEST_ASSERT(rv > 0, "ioctl does not report bad guest memory access");
+	TEST_ASSERT(rv > 0, "ioctl does not report bad guest memory address with CHECK_ONLY");
+	rv = ERR_MOP(info, target, WRITE, mem1, size, GADDR((void *)~0xfffUL));
+	TEST_ASSERT(rv > 0, "ioctl does not report bad guest memory address on write");
 
 	/* Bad host address: */
 	rv = ERR_MOP(info, target, WRITE, 0, size, GADDR_V(mem1));
-- 
2.37.2


  parent reply	other threads:[~2023-02-06 16:46 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-06 16:45 [PATCH v7 00/14] KVM: s390: Extend MEM_OP ioctl by storage key checked cmpxchg Janis Schoetterl-Glausch
2023-02-06 16:45 ` [PATCH v7 01/14] KVM: s390: selftest: memop: Pass mop_desc via pointer Janis Schoetterl-Glausch
2023-02-06 16:45 ` [PATCH v7 02/14] KVM: s390: selftest: memop: Replace macros by functions Janis Schoetterl-Glausch
2023-02-06 16:45 ` [PATCH v7 03/14] KVM: s390: selftest: memop: Move testlist into main Janis Schoetterl-Glausch
2023-02-06 16:45 ` Janis Schoetterl-Glausch [this message]
2023-02-07 13:00   ` [PATCH v7 04/14] KVM: s390: selftest: memop: Add bad address test Janosch Frank
2023-02-06 16:45 ` [PATCH v7 05/14] KVM: s390: selftest: memop: Fix typo Janis Schoetterl-Glausch
2023-02-06 16:45 ` [PATCH v7 06/14] KVM: s390: selftest: memop: Fix wrong address being used in test Janis Schoetterl-Glausch
2023-02-06 16:45 ` [PATCH v7 07/14] KVM: s390: selftest: memop: Fix integer literal Janis Schoetterl-Glausch
2023-02-06 16:45 ` [PATCH v7 08/14] KVM: s390: Move common code of mem_op functions into function Janis Schoetterl-Glausch
2023-02-07 13:03   ` Janosch Frank
2023-02-06 16:45 ` [PATCH v7 09/14] KVM: s390: Dispatch to implementing function at top level of vm mem_op Janis Schoetterl-Glausch
2023-02-07 13:08   ` Janosch Frank
2023-02-06 16:45 ` [PATCH v7 10/14] KVM: s390: Refactor absolute vm mem_op function Janis Schoetterl-Glausch
2023-02-07 13:17   ` Janosch Frank
2023-02-07 13:22   ` Janosch Frank
2023-02-06 16:45 ` [PATCH v7 11/14] KVM: s390: Refactor vcpu " Janis Schoetterl-Glausch
2023-02-06 16:46 ` [PATCH v7 12/14] KVM: s390: Extend MEM_OP ioctl by storage key checked cmpxchg Janis Schoetterl-Glausch
2023-02-07 15:46   ` Janosch Frank
2023-02-06 16:46 ` [PATCH v7 13/14] Documentation: KVM: s390: Describe KVM_S390_MEMOP_F_CMPXCHG Janis Schoetterl-Glausch
2023-02-07 15:55   ` Janosch Frank
2023-02-06 16:46 ` [PATCH v7 14/14] KVM: s390: selftest: memop: Add cmpxchg tests Janis Schoetterl-Glausch
2023-02-07 16:01   ` Janosch Frank
2023-02-07 16:18   ` Janosch Frank
2023-02-07 16:42     ` [PATCH v8 " Janis Schoetterl-Glausch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230206164602.138068-5-scgl@linux.ibm.com \
    --to=scgl@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=corbet@lwn.net \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=nrb@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=shuah@kernel.org \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.