From: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> To: Mark Brown <broonie@kernel.org>, Tudor Ambarus <tudor.ambarus@microchip.com>, Pratyush Yadav <pratyush@kernel.org>, "Michael Walle" <michael@walle.cc>, Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com> Cc: <linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <saikrishna12468@gmail.com>, <git@amd.com>, Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> Subject: [PATCH 2/3] mtd: spi-nor: Add and update device_id field in spi_mem structure Date: Tue, 7 Feb 2023 11:39:23 +0530 [thread overview] Message-ID: <20230207060924.265789-3-sai.krishna.potthuri@amd.com> (raw) In-Reply-To: <20230207060924.265789-1-sai.krishna.potthuri@amd.com> Xilinx Versal Octal SPI controller drivers might require the device id information to perform the Rx tuning operation. Since there is no common Tuning Data Pattern defined across all vendors, controllers which requires Rx tuning to find out the optimal sampling point for data lines, this device id information will be used as a golden data. spi-nor core updates the device id information in device_id field while reading the id of the flash device. Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> --- drivers/mtd/spi-nor/core.c | 1 + include/linux/spi/spi-mem.h | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index bee8fc4c9f07..9811e74ef3b6 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -1644,6 +1644,7 @@ static const struct flash_info *spi_nor_match_id(struct spi_nor *nor, if (part->id_len && !memcmp(part->id, id, part->id_len)) { nor->manufacturer = manufacturers[i]; + memcpy(nor->spimem->device_id, id, SPI_NOR_MAX_ID_LEN); return part; } } diff --git a/include/linux/spi/spi-mem.h b/include/linux/spi/spi-mem.h index 8e984d75f5b6..e9ae5c1b7391 100644 --- a/include/linux/spi/spi-mem.h +++ b/include/linux/spi/spi-mem.h @@ -181,11 +181,14 @@ struct spi_mem_dirmap_desc { void *priv; }; +#define SPI_MEM_DEV_MAX_ID_LEN 6 + /** * struct spi_mem - describes a SPI memory device * @spi: the underlying SPI device * @drvpriv: spi_mem_driver private data * @name: name of the SPI memory device + * @device_id: device id of the SPI memory device * * Extra information that describe the SPI memory device and may be needed by * the controller to properly handle this device should be placed here. @@ -197,6 +200,7 @@ struct spi_mem { struct spi_device *spi; void *drvpriv; const char *name; + u8 device_id[SPI_MEM_DEV_MAX_ID_LEN]; }; /** -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> To: Mark Brown <broonie@kernel.org>, Tudor Ambarus <tudor.ambarus@microchip.com>, Pratyush Yadav <pratyush@kernel.org>, "Michael Walle" <michael@walle.cc>, Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com> Cc: <linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <saikrishna12468@gmail.com>, <git@amd.com>, Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> Subject: [PATCH 2/3] mtd: spi-nor: Add and update device_id field in spi_mem structure Date: Tue, 7 Feb 2023 11:39:23 +0530 [thread overview] Message-ID: <20230207060924.265789-3-sai.krishna.potthuri@amd.com> (raw) In-Reply-To: <20230207060924.265789-1-sai.krishna.potthuri@amd.com> Xilinx Versal Octal SPI controller drivers might require the device id information to perform the Rx tuning operation. Since there is no common Tuning Data Pattern defined across all vendors, controllers which requires Rx tuning to find out the optimal sampling point for data lines, this device id information will be used as a golden data. spi-nor core updates the device id information in device_id field while reading the id of the flash device. Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> --- drivers/mtd/spi-nor/core.c | 1 + include/linux/spi/spi-mem.h | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index bee8fc4c9f07..9811e74ef3b6 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -1644,6 +1644,7 @@ static const struct flash_info *spi_nor_match_id(struct spi_nor *nor, if (part->id_len && !memcmp(part->id, id, part->id_len)) { nor->manufacturer = manufacturers[i]; + memcpy(nor->spimem->device_id, id, SPI_NOR_MAX_ID_LEN); return part; } } diff --git a/include/linux/spi/spi-mem.h b/include/linux/spi/spi-mem.h index 8e984d75f5b6..e9ae5c1b7391 100644 --- a/include/linux/spi/spi-mem.h +++ b/include/linux/spi/spi-mem.h @@ -181,11 +181,14 @@ struct spi_mem_dirmap_desc { void *priv; }; +#define SPI_MEM_DEV_MAX_ID_LEN 6 + /** * struct spi_mem - describes a SPI memory device * @spi: the underlying SPI device * @drvpriv: spi_mem_driver private data * @name: name of the SPI memory device + * @device_id: device id of the SPI memory device * * Extra information that describe the SPI memory device and may be needed by * the controller to properly handle this device should be placed here. @@ -197,6 +200,7 @@ struct spi_mem { struct spi_device *spi; void *drvpriv; const char *name; + u8 device_id[SPI_MEM_DEV_MAX_ID_LEN]; }; /** -- 2.25.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-02-07 6:10 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-07 6:09 [PATCH 0/3] spi: spi-cadence-quadspi: Add Rx tuning support for DTR mode Sai Krishna Potthuri 2023-02-07 6:09 ` Sai Krishna Potthuri 2023-02-07 6:09 ` [PATCH 1/3] spi: cadence-quadspi: Add support for PHY module and DQS Sai Krishna Potthuri 2023-02-07 6:09 ` Sai Krishna Potthuri 2023-02-07 6:09 ` Sai Krishna Potthuri [this message] 2023-02-07 6:09 ` [PATCH 2/3] mtd: spi-nor: Add and update device_id field in spi_mem structure Sai Krishna Potthuri 2023-02-07 6:09 ` [PATCH 3/3] spi: cadence-quadspi: Add Rx tuning support for Xilinx Versal OSPI Sai Krishna Potthuri 2023-02-07 6:09 ` Sai Krishna Potthuri 2023-02-07 7:23 ` Tudor Ambarus 2023-02-07 7:23 ` Tudor Ambarus 2023-02-07 6:48 ` [PATCH 0/3] spi: spi-cadence-quadspi: Add Rx tuning support for DTR mode Tudor Ambarus 2023-02-07 6:48 ` Tudor Ambarus 2023-07-18 10:01 ` Michael Walle 2023-07-18 10:01 ` Michael Walle 2023-07-18 11:30 ` Potthuri, Sai Krishna 2023-07-18 11:30 ` Potthuri, Sai Krishna
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230207060924.265789-3-sai.krishna.potthuri@amd.com \ --to=sai.krishna.potthuri@amd.com \ --cc=broonie@kernel.org \ --cc=git@amd.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=michael@walle.cc \ --cc=miquel.raynal@bootlin.com \ --cc=pratyush@kernel.org \ --cc=richard@nod.at \ --cc=saikrishna12468@gmail.com \ --cc=tudor.ambarus@microchip.com \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.