From: Tanmay Shah <tanmay.shah@amd.com> To: <michal.simek@amd.com>, <andersson@kernel.org>, <mathieu.poirier@linaro.org>, <jaswinder.singh@linaro.org>, <ben.levinsky@amd.com>, <shubhrajyoti.datta@amd.com> Cc: <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-remoteproc@vger.kernel.org>, Tanmay Shah <tanmay.shah@amd.com> Subject: [PATCH v3 1/3] drivers: mailbox: zynqmp: handle multiple child nodes Date: Mon, 13 Feb 2023 13:18:24 -0800 [thread overview] Message-ID: <20230213211825.3507034-2-tanmay.shah@amd.com> (raw) In-Reply-To: <20230213211825.3507034-1-tanmay.shah@amd.com> As of now only one child node is handled by zynqmp-ipi mailbox driver. Upon introducing remoteproc r5 core mailbox nodes, found few enhancements in Xilinx zynqmp mailbox driver as following: - fix mailbox child node counts If child mailbox node status is disabled it causes crash in interrupt handler. Fix this by assigning only available child node during driver probe. - fix typo in IPI documentation %s/12/32/ Xilinx IPI message buffers allows 32-byte data transfer. Fix documentation that says 12 bytes - fix bug in zynqmp-ipi isr handling Multiple IPI channels are mapped to same interrupt handler. Current isr implementation handles only one channel per isr. Fix this behavior by checking isr status bit of all child mailbox nodes. Fixes: 4981b82ba2ff ("mailbox: ZynqMP IPI mailbox controller") Signed-off-by: Tanmay Shah <tanmay.shah@amd.com> --- Changelog: - This is first version of this change, however posting as part of the series that has version v3. v2: https://lore.kernel.org/all/20230126213154.1707300-1-tanmay.shah@amd.com/ drivers/mailbox/zynqmp-ipi-mailbox.c | 8 ++++---- include/linux/mailbox/zynqmp-ipi-message.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c index 12e004ff1a14..b1498f6f06e1 100644 --- a/drivers/mailbox/zynqmp-ipi-mailbox.c +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c @@ -152,7 +152,7 @@ static irqreturn_t zynqmp_ipi_interrupt(int irq, void *data) struct zynqmp_ipi_message *msg; u64 arg0, arg3; struct arm_smccc_res res; - int ret, i; + int ret, i, status = IRQ_NONE; (void)irq; arg0 = SMC_IPI_MAILBOX_STATUS_ENQUIRY; @@ -170,11 +170,11 @@ static irqreturn_t zynqmp_ipi_interrupt(int irq, void *data) memcpy_fromio(msg->data, mchan->req_buf, msg->len); mbox_chan_received_data(chan, (void *)msg); - return IRQ_HANDLED; + status = IRQ_HANDLED; } } } - return IRQ_NONE; + return status; } /** @@ -634,7 +634,7 @@ static int zynqmp_ipi_probe(struct platform_device *pdev) struct zynqmp_ipi_mbox *mbox; int num_mboxes, ret = -EINVAL; - num_mboxes = of_get_child_count(np); + num_mboxes = of_get_available_child_count(np); pdata = devm_kzalloc(dev, sizeof(*pdata) + (num_mboxes * sizeof(*mbox)), GFP_KERNEL); if (!pdata) diff --git a/include/linux/mailbox/zynqmp-ipi-message.h b/include/linux/mailbox/zynqmp-ipi-message.h index 35ce84c8ca02..31d8046d945e 100644 --- a/include/linux/mailbox/zynqmp-ipi-message.h +++ b/include/linux/mailbox/zynqmp-ipi-message.h @@ -9,7 +9,7 @@ * @data: message payload * * This is the structure for data used in mbox_send_message - * the maximum length of data buffer is fixed to 12 bytes. + * the maximum length of data buffer is fixed to 32 bytes. * Client is supposed to be aware of this. */ struct zynqmp_ipi_message { -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Tanmay Shah <tanmay.shah@amd.com> To: <michal.simek@amd.com>, <andersson@kernel.org>, <mathieu.poirier@linaro.org>, <jaswinder.singh@linaro.org>, <ben.levinsky@amd.com>, <shubhrajyoti.datta@amd.com> Cc: <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-remoteproc@vger.kernel.org>, Tanmay Shah <tanmay.shah@amd.com> Subject: [PATCH v3 1/3] drivers: mailbox: zynqmp: handle multiple child nodes Date: Mon, 13 Feb 2023 13:18:24 -0800 [thread overview] Message-ID: <20230213211825.3507034-2-tanmay.shah@amd.com> (raw) In-Reply-To: <20230213211825.3507034-1-tanmay.shah@amd.com> As of now only one child node is handled by zynqmp-ipi mailbox driver. Upon introducing remoteproc r5 core mailbox nodes, found few enhancements in Xilinx zynqmp mailbox driver as following: - fix mailbox child node counts If child mailbox node status is disabled it causes crash in interrupt handler. Fix this by assigning only available child node during driver probe. - fix typo in IPI documentation %s/12/32/ Xilinx IPI message buffers allows 32-byte data transfer. Fix documentation that says 12 bytes - fix bug in zynqmp-ipi isr handling Multiple IPI channels are mapped to same interrupt handler. Current isr implementation handles only one channel per isr. Fix this behavior by checking isr status bit of all child mailbox nodes. Fixes: 4981b82ba2ff ("mailbox: ZynqMP IPI mailbox controller") Signed-off-by: Tanmay Shah <tanmay.shah@amd.com> --- Changelog: - This is first version of this change, however posting as part of the series that has version v3. v2: https://lore.kernel.org/all/20230126213154.1707300-1-tanmay.shah@amd.com/ drivers/mailbox/zynqmp-ipi-mailbox.c | 8 ++++---- include/linux/mailbox/zynqmp-ipi-message.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c index 12e004ff1a14..b1498f6f06e1 100644 --- a/drivers/mailbox/zynqmp-ipi-mailbox.c +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c @@ -152,7 +152,7 @@ static irqreturn_t zynqmp_ipi_interrupt(int irq, void *data) struct zynqmp_ipi_message *msg; u64 arg0, arg3; struct arm_smccc_res res; - int ret, i; + int ret, i, status = IRQ_NONE; (void)irq; arg0 = SMC_IPI_MAILBOX_STATUS_ENQUIRY; @@ -170,11 +170,11 @@ static irqreturn_t zynqmp_ipi_interrupt(int irq, void *data) memcpy_fromio(msg->data, mchan->req_buf, msg->len); mbox_chan_received_data(chan, (void *)msg); - return IRQ_HANDLED; + status = IRQ_HANDLED; } } } - return IRQ_NONE; + return status; } /** @@ -634,7 +634,7 @@ static int zynqmp_ipi_probe(struct platform_device *pdev) struct zynqmp_ipi_mbox *mbox; int num_mboxes, ret = -EINVAL; - num_mboxes = of_get_child_count(np); + num_mboxes = of_get_available_child_count(np); pdata = devm_kzalloc(dev, sizeof(*pdata) + (num_mboxes * sizeof(*mbox)), GFP_KERNEL); if (!pdata) diff --git a/include/linux/mailbox/zynqmp-ipi-message.h b/include/linux/mailbox/zynqmp-ipi-message.h index 35ce84c8ca02..31d8046d945e 100644 --- a/include/linux/mailbox/zynqmp-ipi-message.h +++ b/include/linux/mailbox/zynqmp-ipi-message.h @@ -9,7 +9,7 @@ * @data: message payload * * This is the structure for data used in mbox_send_message - * the maximum length of data buffer is fixed to 12 bytes. + * the maximum length of data buffer is fixed to 32 bytes. * Client is supposed to be aware of this. */ struct zynqmp_ipi_message { -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-13 21:19 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-13 21:18 [PATCH v3 0/3] drivers: remoteproc: xilinx: add mailbox support Tanmay Shah 2023-02-13 21:18 ` Tanmay Shah 2023-02-13 21:18 ` Tanmay Shah [this message] 2023-02-13 21:18 ` [PATCH v3 1/3] drivers: mailbox: zynqmp: handle multiple child nodes Tanmay Shah 2023-02-22 5:28 ` Datta, Shubhrajyoti 2023-02-22 5:28 ` Datta, Shubhrajyoti 2023-02-22 17:34 ` Mathieu Poirier 2023-02-22 17:34 ` Mathieu Poirier 2023-02-23 9:40 ` Michal Simek 2023-02-23 9:40 ` Michal Simek 2023-02-23 14:47 ` Tanmay Shah 2023-02-23 14:47 ` Tanmay Shah 2023-02-24 8:37 ` Michal Simek 2023-02-24 8:37 ` Michal Simek 2023-02-27 15:25 ` Tanmay Shah 2023-02-27 15:25 ` Tanmay Shah 2023-02-27 15:28 ` Michal Simek 2023-02-27 15:28 ` Michal Simek 2023-02-13 21:18 ` [PATCH v3 2/3] drivers: remoteproc: xilinx: fix carveout names Tanmay Shah 2023-02-13 21:18 ` Tanmay Shah 2023-02-22 18:41 ` Mathieu Poirier 2023-02-22 18:41 ` Mathieu Poirier 2023-02-22 20:47 ` Tanmay Shah 2023-02-22 20:47 ` Tanmay Shah 2023-02-13 21:18 ` [PATCH v3 3/3] remoteproc: xilinx: add mailbox channels for rpmsg Tanmay Shah 2023-02-13 21:18 ` Tanmay Shah 2023-02-22 19:06 ` Mathieu Poirier 2023-02-22 19:06 ` Mathieu Poirier 2023-02-22 20:49 ` Tanmay Shah 2023-02-22 20:49 ` Tanmay Shah
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230213211825.3507034-2-tanmay.shah@amd.com \ --to=tanmay.shah@amd.com \ --cc=andersson@kernel.org \ --cc=ben.levinsky@amd.com \ --cc=jaswinder.singh@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=mathieu.poirier@linaro.org \ --cc=michal.simek@amd.com \ --cc=shubhrajyoti.datta@amd.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.