All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-renesas-soc@vger.kernel.org,
	Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>
Subject: [PATCH 1/3] drm: rcar-du: lvds: Call function directly instead of through pointer
Date: Tue, 14 Feb 2023 02:37:34 +0200	[thread overview]
Message-ID: <20230214003736.18871-2-laurent.pinchart+renesas@ideasonboard.com> (raw)
In-Reply-To: <20230214003736.18871-1-laurent.pinchart+renesas@ideasonboard.com>

When disabling the companion bridge in rcar_lvds_atomic_disable(),
there's no need to go through the bridge's operations to call
.atomic_disable(). Call rcar_lvds_atomic_disable() on the companion
directly.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 drivers/gpu/drm/rcar-du/rcar_lvds.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
index 260ea5d8624e..61de18af62e6 100644
--- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
+++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
@@ -582,8 +582,7 @@ static void rcar_lvds_atomic_disable(struct drm_bridge *bridge,
 
 	/* Disable the companion LVDS encoder in dual-link mode. */
 	if (lvds->link_type != RCAR_LVDS_SINGLE_LINK && lvds->companion)
-		lvds->companion->funcs->atomic_disable(lvds->companion,
-						       old_bridge_state);
+		rcar_lvds_atomic_disable(lvds->companion, old_bridge_state);
 
 	pm_runtime_put_sync(lvds->dev);
 }
-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2023-02-14  0:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14  0:37 [PATCH 0/3] drm: rcar-du: Fix vblank wait timeout when stopping LVDS output Laurent Pinchart
2023-02-14  0:37 ` Laurent Pinchart [this message]
2023-02-15  6:18   ` [PATCH 1/3] drm: rcar-du: lvds: Call function directly instead of through pointer Tomi Valkeinen
2023-02-14  0:37 ` [PATCH 2/3] drm: rcar-du: lvds: Move LVDS enable code to separate code section Laurent Pinchart
2023-02-14  8:25   ` Geert Uytterhoeven
2023-02-14  8:25     ` Geert Uytterhoeven
2023-02-15  6:20   ` Tomi Valkeinen
2023-02-15  8:34     ` Laurent Pinchart
2023-02-15  8:34       ` Laurent Pinchart
2023-02-14  0:37 ` [PATCH 3/3] drm: rcar-du: lvds: Fix LVDS PLL disable on D3/E3 Laurent Pinchart
2023-02-15  6:29   ` Tomi Valkeinen
2023-02-15 10:19     ` Laurent Pinchart
2023-02-15 10:19       ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230214003736.18871-2-laurent.pinchart+renesas@ideasonboard.com \
    --to=laurent.pinchart+renesas@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=tomi.valkeinen@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.