All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Mun Yew Tham <mun.yew.tham@intel.com>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
	Alban Bedel <albeu@free.fr>, Orson Zhai <orsonzhai@gmail.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>,
	Jay Fang <f.fangjian@huawei.com>,
	Daniel Palmer <daniel@thingy.jp>,
	Romain Perier <romain.perier@gmail.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Kevin Hilman <khilman@kernel.org>,
	William Breathitt Gray <william.gray@linaro.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-omap@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Janusz Krzysztofik <jmkrzyszt@gmail.com>,
	Tony Lindgren <tony@atomide.com>, Arnd Bergmann <arnd@arndb.de>,
	Marc Zyngier <maz@kernel.org>
Subject: [PATCH v3 14/17] gpio: omap: Drop irq_base
Date: Thu, 09 Mar 2023 08:46:02 +0100	[thread overview]
Message-ID: <20230215-immutable-chips-v3-14-972542092a77@linaro.org> (raw)
In-Reply-To: <20230215-immutable-chips-v3-0-972542092a77@linaro.org>

The OMAP1 at one point was using static irqs but that time is gone,
OMAP1 uses sparse irqs like all other multiplatform targets so this
static allocation of descriptors should just go.

Cc: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/gpio/gpio-omap.c | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index f5f3d4b22452..1cbd040cf796 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -992,7 +992,6 @@ static int omap_gpio_chip_init(struct gpio_bank *bank, struct irq_chip *irqc,
 	struct gpio_irq_chip *irq;
 	static int gpio;
 	const char *label;
-	int irq_base = 0;
 	int ret;
 
 	/*
@@ -1024,19 +1023,6 @@ static int omap_gpio_chip_init(struct gpio_bank *bank, struct irq_chip *irqc,
 	}
 	bank->chip.ngpio = bank->width;
 
-#ifdef CONFIG_ARCH_OMAP1
-	/*
-	 * REVISIT: Once we have OMAP1 supporting SPARSE_IRQ, we can drop
-	 * irq_alloc_descs() since a base IRQ offset will no longer be needed.
-	 */
-	irq_base = devm_irq_alloc_descs(bank->chip.parent,
-					-1, 0, bank->width, 0);
-	if (irq_base < 0) {
-		dev_err(bank->chip.parent, "Couldn't allocate IRQ numbers\n");
-		return -ENODEV;
-	}
-#endif
-
 	/* MPUIO is a bit different, reading IRQ status clears it */
 	if (bank->is_mpuio && !bank->regs->wkup_en)
 		irqc->irq_set_wake = NULL;
@@ -1047,7 +1033,6 @@ static int omap_gpio_chip_init(struct gpio_bank *bank, struct irq_chip *irqc,
 	irq->default_type = IRQ_TYPE_NONE;
 	irq->num_parents = 1;
 	irq->parents = &bank->irq;
-	irq->first = irq_base;
 
 	ret = gpiochip_add_data(&bank->chip, bank);
 	if (ret)

-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Mun Yew Tham <mun.yew.tham@intel.com>,
	 Bartosz Golaszewski <brgl@bgdev.pl>,
	Joel Stanley <joel@jms.id.au>,  Andrew Jeffery <andrew@aj.id.au>,
	Alban Bedel <albeu@free.fr>,  Orson Zhai <orsonzhai@gmail.com>,
	 Baolin Wang <baolin.wang@linux.alibaba.com>,
	 Chunyan Zhang <zhang.lyra@gmail.com>,
	Jay Fang <f.fangjian@huawei.com>,
	 Daniel Palmer <daniel@thingy.jp>,
	Romain Perier <romain.perier@gmail.com>,
	 Santosh Shilimkar <ssantosh@kernel.org>,
	Kevin Hilman <khilman@kernel.org>,
	 William Breathitt Gray <william.gray@linaro.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org,  linux-omap@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	 Janusz Krzysztofik <jmkrzyszt@gmail.com>,
	Tony Lindgren <tony@atomide.com>,  Arnd Bergmann <arnd@arndb.de>,
	Marc Zyngier <maz@kernel.org>
Subject: [PATCH v3 14/17] gpio: omap: Drop irq_base
Date: Thu, 09 Mar 2023 08:46:02 +0100	[thread overview]
Message-ID: <20230215-immutable-chips-v3-14-972542092a77@linaro.org> (raw)
In-Reply-To: <20230215-immutable-chips-v3-0-972542092a77@linaro.org>

The OMAP1 at one point was using static irqs but that time is gone,
OMAP1 uses sparse irqs like all other multiplatform targets so this
static allocation of descriptors should just go.

Cc: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/gpio/gpio-omap.c | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index f5f3d4b22452..1cbd040cf796 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -992,7 +992,6 @@ static int omap_gpio_chip_init(struct gpio_bank *bank, struct irq_chip *irqc,
 	struct gpio_irq_chip *irq;
 	static int gpio;
 	const char *label;
-	int irq_base = 0;
 	int ret;
 
 	/*
@@ -1024,19 +1023,6 @@ static int omap_gpio_chip_init(struct gpio_bank *bank, struct irq_chip *irqc,
 	}
 	bank->chip.ngpio = bank->width;
 
-#ifdef CONFIG_ARCH_OMAP1
-	/*
-	 * REVISIT: Once we have OMAP1 supporting SPARSE_IRQ, we can drop
-	 * irq_alloc_descs() since a base IRQ offset will no longer be needed.
-	 */
-	irq_base = devm_irq_alloc_descs(bank->chip.parent,
-					-1, 0, bank->width, 0);
-	if (irq_base < 0) {
-		dev_err(bank->chip.parent, "Couldn't allocate IRQ numbers\n");
-		return -ENODEV;
-	}
-#endif
-
 	/* MPUIO is a bit different, reading IRQ status clears it */
 	if (bank->is_mpuio && !bank->regs->wkup_en)
 		irqc->irq_set_wake = NULL;
@@ -1047,7 +1033,6 @@ static int omap_gpio_chip_init(struct gpio_bank *bank, struct irq_chip *irqc,
 	irq->default_type = IRQ_TYPE_NONE;
 	irq->num_parents = 1;
 	irq->parents = &bank->irq;
-	irq->first = irq_base;
 
 	ret = gpiochip_add_data(&bank->chip, bank);
 	if (ret)

-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-03-09  7:47 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09  7:45 [PATCH v3 00/17] Mass convert GPIO IRQ chips to be immutable Linus Walleij
2023-03-09  7:45 ` Linus Walleij
2023-03-09  7:45 ` [PATCH v3 01/17] gpio: altera: Convert to immutable irq_chip Linus Walleij
2023-03-09  7:45   ` Linus Walleij
2023-03-09  7:45 ` [PATCH v3 02/17] gpio: adnp: " Linus Walleij
2023-03-09  7:45   ` Linus Walleij
2023-03-09  7:45 ` [PATCH v3 03/17] gpio: aspeed: Always register the irqchip Linus Walleij
2023-03-09  7:45   ` Linus Walleij
2023-03-09  7:45 ` [PATCH v3 04/17] gpio: aspeed: Convert to immutable irq_chip Linus Walleij
2023-03-09  7:45   ` Linus Walleij
2023-03-09  7:45 ` [PATCH v3 05/17] gpio: aspeed-sgpio: " Linus Walleij
2023-03-09  7:45   ` Linus Walleij
2023-03-09  7:45 ` [PATCH v3 06/17] gpio: ath79: " Linus Walleij
2023-03-09  7:45   ` Linus Walleij
2023-03-09  7:45 ` [PATCH v3 07/17] gpio: cadence: " Linus Walleij
2023-03-09  7:45   ` Linus Walleij
2023-03-09  7:45 ` [PATCH v3 08/17] gpio: hisi: " Linus Walleij
2023-03-09  7:45   ` Linus Walleij
2023-03-09  7:45 ` [PATCH v3 09/17] gpio: hlwd: " Linus Walleij
2023-03-09  7:45   ` Linus Walleij
2023-03-09  7:45 ` [PATCH v3 10/17] gpio: idt3243x: " Linus Walleij
2023-03-09  7:45   ` Linus Walleij
2023-03-09  7:45 ` [PATCH v3 11/17] gpio: msc313: " Linus Walleij
2023-03-09  7:45   ` Linus Walleij
2023-03-10  8:06   ` Romain Perier
2023-03-10  8:06     ` Romain Perier
2023-03-09  7:46 ` [PATCH v3 12/17] gpio: mlxbf2: " Linus Walleij
2023-03-09  7:46   ` Linus Walleij
2023-03-09  7:46 ` [PATCH v3 13/17] gpio: max732x: " Linus Walleij
2023-03-09  7:46   ` Linus Walleij
2023-03-09  7:46 ` Linus Walleij [this message]
2023-03-09  7:46   ` [PATCH v3 14/17] gpio: omap: Drop irq_base Linus Walleij
2023-03-09  7:46 ` [PATCH v3 15/17] gpio: omap: Convert to immutable irq_chip Linus Walleij
2023-03-09  7:46   ` Linus Walleij
2023-03-09  7:46 ` [PATCH v3 16/17] gpio: pci-idio-16: " Linus Walleij
2023-03-09  7:46   ` Linus Walleij
2023-03-09  7:46 ` [PATCH v3 17/17] gpio: pcie-idio-24: " Linus Walleij
2023-03-09  7:46   ` Linus Walleij
2023-03-10 15:25 ` [PATCH v3 00/17] Mass convert GPIO IRQ chips to be immutable Bartosz Golaszewski
2023-03-10 15:25   ` Bartosz Golaszewski
2023-03-10 22:44   ` Linus Walleij
2023-03-10 22:44     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230215-immutable-chips-v3-14-972542092a77@linaro.org \
    --to=linus.walleij@linaro.org \
    --cc=albeu@free.fr \
    --cc=andrew@aj.id.au \
    --cc=arnd@arndb.de \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=brgl@bgdev.pl \
    --cc=daniel@thingy.jp \
    --cc=f.fangjian@huawei.com \
    --cc=jmkrzyszt@gmail.com \
    --cc=joel@jms.id.au \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=mun.yew.tham@intel.com \
    --cc=orsonzhai@gmail.com \
    --cc=romain.perier@gmail.com \
    --cc=ssantosh@kernel.org \
    --cc=tony@atomide.com \
    --cc=william.gray@linaro.org \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.