From: Marc Zyngier <maz@kernel.org> To: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: James Morse <james.morse@arm.com>, Suzuki K Poulose <suzuki.poulose@arm.com>, Oliver Upton <oliver.upton@linux.dev>, Zenghui Yu <yuzenghui@huawei.com>, Ricardo Koller <ricarkol@google.com>, Simon Veith <sveith@amazon.de>, dwmw2@infradead.org Subject: [PATCH 00/16] KVM: arm64: Rework timer offsetting for fun and profit Date: Thu, 16 Feb 2023 14:21:07 +0000 [thread overview] Message-ID: <20230216142123.2638675-1-maz@kernel.org> (raw) This series aims at satisfying multiple goals: - allow a VMM to atomically restore a timer offset for a whole VM instead of updating the offset each time a vcpu get its counter written - allow a VMM to save/restore the physical timer context, something that we cannot do at the moment due to the lack of offsetting - provide a framework that is suitable for NV support, where we get both global and per timer, per vcpu offsetting We fix a couple of issues along the way, both from a stylistic and correctness perspective. This results in a new per VM KVM API that allows a pair of global offsets to be set at any point in time, overriding the timer counter writeback. This has been moderately tested with nVHE, VHE and NV. I do not have access to CNTPOFF-aware HW, so the jury is still out on that one. Note that the NV patches in this series are here to give a perspective on how this gets used. I've updated the arch_timer selftest to allow offsets to be provided from the command line, but the arch_test is pretty flimsy and tends to fail with an error==EINTR, even without this series. Something to investigate. Note that this is at best 6.4 material. I have a branch stashed at [1] and based on kvmarm/next. Thanks, M. [1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=kvm-arm64/timer-vm-offsets Marc Zyngier (16): arm64: Add CNTPOFF_EL2 register definition arm64: Add HAS_ECV_CNTPOFF capability kvm: arm64: Expose {un,}lock_all_vcpus() to the reset of KVM KVM: arm64: timers: Use a per-vcpu, per-timer accumulator for fractional ns KVM: arm64: timers: Convert per-vcpu virtual offset to a global value KVM: arm64: timers: Use CNTPOFF_EL2 to offset the physical timer KVM: arm64: timers: Allow physical offset without CNTPOFF_EL2 KVM: arm64: timers: Allow userspace to set the counter offsets KVM: arm64: timers: Allow save/restoring of the physical timer KVM: arm64: timers: Rationalise per-vcpu timer init KVM: arm64: Document KVM_ARM_SET_CNT_OFFSETS and co KVM: arm64: nv: timers: Add a per-timer, per-vcpu offset KVM: arm64: nv: timers: Support hyp timer emulation KVM: arm64: selftests: Add physical timer registers to the sysreg list KVM: arm64: selftests: Augment existing timer test to handle variable offsets KVM: arm64: selftests: Deal with spurious timer interrupts Documentation/virt/kvm/api.rst | 47 ++ arch/arm64/include/asm/kvm_host.h | 14 + arch/arm64/include/uapi/asm/kvm.h | 15 + arch/arm64/kernel/cpufeature.c | 11 + arch/arm64/kvm/arch_timer.c | 443 ++++++++++++++---- arch/arm64/kvm/arm.c | 47 ++ arch/arm64/kvm/guest.c | 29 +- arch/arm64/kvm/hyp/nvhe/timer-sr.c | 18 +- arch/arm64/kvm/hypercalls.c | 2 +- arch/arm64/kvm/trace_arm.h | 6 +- arch/arm64/kvm/vgic/vgic-kvm-device.c | 38 -- arch/arm64/kvm/vgic/vgic.c | 15 + arch/arm64/kvm/vgic/vgic.h | 3 - arch/arm64/tools/cpucaps | 1 + arch/arm64/tools/sysreg | 4 + include/clocksource/arm_arch_timer.h | 1 + include/kvm/arm_arch_timer.h | 32 +- include/kvm/arm_vgic.h | 1 + include/uapi/linux/kvm.h | 3 + .../selftests/kvm/aarch64/arch_timer.c | 26 +- .../selftests/kvm/aarch64/get-reg-list.c | 5 +- 21 files changed, 603 insertions(+), 158 deletions(-) -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org> To: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: James Morse <james.morse@arm.com>, Suzuki K Poulose <suzuki.poulose@arm.com>, Oliver Upton <oliver.upton@linux.dev>, Zenghui Yu <yuzenghui@huawei.com>, Ricardo Koller <ricarkol@google.com>, Simon Veith <sveith@amazon.de>, dwmw2@infradead.org Subject: [PATCH 00/16] KVM: arm64: Rework timer offsetting for fun and profit Date: Thu, 16 Feb 2023 14:21:07 +0000 [thread overview] Message-ID: <20230216142123.2638675-1-maz@kernel.org> (raw) This series aims at satisfying multiple goals: - allow a VMM to atomically restore a timer offset for a whole VM instead of updating the offset each time a vcpu get its counter written - allow a VMM to save/restore the physical timer context, something that we cannot do at the moment due to the lack of offsetting - provide a framework that is suitable for NV support, where we get both global and per timer, per vcpu offsetting We fix a couple of issues along the way, both from a stylistic and correctness perspective. This results in a new per VM KVM API that allows a pair of global offsets to be set at any point in time, overriding the timer counter writeback. This has been moderately tested with nVHE, VHE and NV. I do not have access to CNTPOFF-aware HW, so the jury is still out on that one. Note that the NV patches in this series are here to give a perspective on how this gets used. I've updated the arch_timer selftest to allow offsets to be provided from the command line, but the arch_test is pretty flimsy and tends to fail with an error==EINTR, even without this series. Something to investigate. Note that this is at best 6.4 material. I have a branch stashed at [1] and based on kvmarm/next. Thanks, M. [1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=kvm-arm64/timer-vm-offsets Marc Zyngier (16): arm64: Add CNTPOFF_EL2 register definition arm64: Add HAS_ECV_CNTPOFF capability kvm: arm64: Expose {un,}lock_all_vcpus() to the reset of KVM KVM: arm64: timers: Use a per-vcpu, per-timer accumulator for fractional ns KVM: arm64: timers: Convert per-vcpu virtual offset to a global value KVM: arm64: timers: Use CNTPOFF_EL2 to offset the physical timer KVM: arm64: timers: Allow physical offset without CNTPOFF_EL2 KVM: arm64: timers: Allow userspace to set the counter offsets KVM: arm64: timers: Allow save/restoring of the physical timer KVM: arm64: timers: Rationalise per-vcpu timer init KVM: arm64: Document KVM_ARM_SET_CNT_OFFSETS and co KVM: arm64: nv: timers: Add a per-timer, per-vcpu offset KVM: arm64: nv: timers: Support hyp timer emulation KVM: arm64: selftests: Add physical timer registers to the sysreg list KVM: arm64: selftests: Augment existing timer test to handle variable offsets KVM: arm64: selftests: Deal with spurious timer interrupts Documentation/virt/kvm/api.rst | 47 ++ arch/arm64/include/asm/kvm_host.h | 14 + arch/arm64/include/uapi/asm/kvm.h | 15 + arch/arm64/kernel/cpufeature.c | 11 + arch/arm64/kvm/arch_timer.c | 443 ++++++++++++++---- arch/arm64/kvm/arm.c | 47 ++ arch/arm64/kvm/guest.c | 29 +- arch/arm64/kvm/hyp/nvhe/timer-sr.c | 18 +- arch/arm64/kvm/hypercalls.c | 2 +- arch/arm64/kvm/trace_arm.h | 6 +- arch/arm64/kvm/vgic/vgic-kvm-device.c | 38 -- arch/arm64/kvm/vgic/vgic.c | 15 + arch/arm64/kvm/vgic/vgic.h | 3 - arch/arm64/tools/cpucaps | 1 + arch/arm64/tools/sysreg | 4 + include/clocksource/arm_arch_timer.h | 1 + include/kvm/arm_arch_timer.h | 32 +- include/kvm/arm_vgic.h | 1 + include/uapi/linux/kvm.h | 3 + .../selftests/kvm/aarch64/arch_timer.c | 26 +- .../selftests/kvm/aarch64/get-reg-list.c | 5 +- 21 files changed, 603 insertions(+), 158 deletions(-) -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2023-02-16 14:22 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-16 14:21 Marc Zyngier [this message] 2023-02-16 14:21 ` [PATCH 00/16] KVM: arm64: Rework timer offsetting for fun and profit Marc Zyngier 2023-02-16 14:21 ` [PATCH 01/16] arm64: Add CNTPOFF_EL2 register definition Marc Zyngier 2023-02-16 14:21 ` Marc Zyngier 2023-02-16 14:21 ` [PATCH 02/16] arm64: Add HAS_ECV_CNTPOFF capability Marc Zyngier 2023-02-16 14:21 ` Marc Zyngier 2023-02-22 4:30 ` Reiji Watanabe 2023-02-22 4:30 ` Reiji Watanabe 2023-02-22 10:47 ` Marc Zyngier 2023-02-22 10:47 ` Marc Zyngier 2023-02-16 14:21 ` [PATCH 03/16] kvm: arm64: Expose {un,}lock_all_vcpus() to the reset of KVM Marc Zyngier 2023-02-16 14:21 ` Marc Zyngier 2023-02-23 22:30 ` Colton Lewis 2023-02-23 22:30 ` Colton Lewis 2023-02-16 14:21 ` [PATCH 04/16] KVM: arm64: timers: Use a per-vcpu, per-timer accumulator for fractional ns Marc Zyngier 2023-02-16 14:21 ` Marc Zyngier 2023-02-23 22:30 ` Colton Lewis 2023-02-23 22:30 ` Colton Lewis 2023-02-16 14:21 ` [PATCH 05/16] KVM: arm64: timers: Convert per-vcpu virtual offset to a global value Marc Zyngier 2023-02-16 14:21 ` Marc Zyngier 2023-02-22 6:15 ` Reiji Watanabe 2023-02-22 6:15 ` Reiji Watanabe 2023-02-22 10:54 ` Marc Zyngier 2023-02-22 10:54 ` Marc Zyngier 2023-02-16 14:21 ` [PATCH 06/16] KVM: arm64: timers: Use CNTPOFF_EL2 to offset the physical timer Marc Zyngier 2023-02-16 14:21 ` Marc Zyngier 2023-02-23 22:34 ` Colton Lewis 2023-02-23 22:34 ` Colton Lewis 2023-02-24 8:59 ` Marc Zyngier 2023-02-24 8:59 ` Marc Zyngier 2023-02-16 14:21 ` [PATCH 07/16] KVM: arm64: timers: Allow physical offset without CNTPOFF_EL2 Marc Zyngier 2023-02-16 14:21 ` Marc Zyngier 2023-02-23 22:40 ` Colton Lewis 2023-02-23 22:40 ` Colton Lewis 2023-02-24 10:54 ` Marc Zyngier 2023-02-24 10:54 ` Marc Zyngier 2023-02-16 14:21 ` [PATCH 08/16] KVM: arm64: timers: Allow userspace to set the counter offsets Marc Zyngier 2023-02-16 14:21 ` Marc Zyngier 2023-02-16 22:09 ` Oliver Upton 2023-02-16 22:09 ` Oliver Upton 2023-02-17 10:17 ` Marc Zyngier 2023-02-17 10:17 ` Marc Zyngier 2023-02-17 22:11 ` Oliver Upton 2023-02-17 22:11 ` Oliver Upton 2023-02-22 11:56 ` Marc Zyngier 2023-02-22 11:56 ` Marc Zyngier 2023-02-22 16:34 ` Oliver Upton 2023-02-22 16:34 ` Oliver Upton 2023-02-23 18:25 ` Marc Zyngier 2023-02-23 18:25 ` Marc Zyngier 2023-03-08 7:46 ` Oliver Upton 2023-03-08 7:46 ` Oliver Upton 2023-03-08 7:53 ` Oliver Upton 2023-03-08 7:53 ` Oliver Upton 2023-03-09 8:29 ` Marc Zyngier 2023-03-09 8:29 ` Marc Zyngier 2023-03-09 8:25 ` Marc Zyngier 2023-03-09 8:25 ` Marc Zyngier 2023-02-23 22:41 ` Colton Lewis 2023-02-23 22:41 ` Colton Lewis 2023-02-24 11:24 ` Marc Zyngier 2023-02-24 11:24 ` Marc Zyngier 2023-02-16 14:21 ` [PATCH 09/16] KVM: arm64: timers: Allow save/restoring of the physical timer Marc Zyngier 2023-02-16 14:21 ` Marc Zyngier 2023-02-16 14:21 ` [PATCH 10/16] KVM: arm64: timers: Rationalise per-vcpu timer init Marc Zyngier 2023-02-16 14:21 ` Marc Zyngier 2023-02-16 14:21 ` [PATCH 11/16] KVM: arm64: Document KVM_ARM_SET_CNT_OFFSETS and co Marc Zyngier 2023-02-16 14:21 ` Marc Zyngier 2023-02-16 14:21 ` [PATCH 12/16] KVM: arm64: nv: timers: Add a per-timer, per-vcpu offset Marc Zyngier 2023-02-16 14:21 ` Marc Zyngier 2023-02-24 20:07 ` Colton Lewis 2023-02-24 20:07 ` Colton Lewis 2023-02-25 10:32 ` Marc Zyngier 2023-02-25 10:32 ` Marc Zyngier 2023-02-16 14:21 ` [PATCH 13/16] KVM: arm64: nv: timers: Support hyp timer emulation Marc Zyngier 2023-02-16 14:21 ` Marc Zyngier 2023-02-24 20:08 ` Colton Lewis 2023-02-24 20:08 ` Colton Lewis 2023-02-25 10:34 ` Marc Zyngier 2023-02-25 10:34 ` Marc Zyngier 2023-02-16 14:21 ` [PATCH 14/16] KVM: arm64: selftests: Add physical timer registers to the sysreg list Marc Zyngier 2023-02-16 14:21 ` Marc Zyngier 2023-02-16 14:21 ` [PATCH 15/16] KVM: arm64: selftests: Augment existing timer test to handle variable offsets Marc Zyngier 2023-02-16 14:21 ` Marc Zyngier 2023-03-06 22:08 ` Colton Lewis 2023-03-06 22:08 ` Colton Lewis 2023-03-09 9:01 ` Marc Zyngier 2023-03-09 9:01 ` Marc Zyngier 2023-03-10 19:26 ` Colton Lewis 2023-03-10 19:26 ` Colton Lewis 2023-03-12 15:53 ` Marc Zyngier 2023-03-12 15:53 ` Marc Zyngier 2023-03-13 11:43 ` Marc Zyngier 2023-03-13 11:43 ` Marc Zyngier 2023-03-14 17:47 ` Colton Lewis 2023-03-14 17:47 ` Colton Lewis 2023-03-14 18:18 ` Marc Zyngier 2023-03-14 18:18 ` Marc Zyngier 2023-02-16 14:21 ` [PATCH 16/16] KVM: arm64: selftests: Deal with spurious timer interrupts Marc Zyngier 2023-02-16 14:21 ` Marc Zyngier 2023-02-21 16:28 ` [PATCH 00/16] KVM: arm64: Rework timer offsetting for fun and profit Veith, Simon 2023-02-21 16:28 ` Veith, Simon 2023-02-21 22:17 ` Marc Zyngier 2023-02-21 22:17 ` Marc Zyngier 2023-02-23 22:29 ` Colton Lewis 2023-02-23 22:29 ` Colton Lewis 2023-02-24 8:45 ` Marc Zyngier 2023-02-24 8:45 ` Marc Zyngier 2023-02-24 20:07 ` Colton Lewis 2023-02-24 20:07 ` Colton Lewis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230216142123.2638675-1-maz@kernel.org \ --to=maz@kernel.org \ --cc=dwmw2@infradead.org \ --cc=james.morse@arm.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.linux.dev \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=oliver.upton@linux.dev \ --cc=ricarkol@google.com \ --cc=suzuki.poulose@arm.com \ --cc=sveith@amazon.de \ --cc=yuzenghui@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.