All of lore.kernel.org
 help / color / mirror / Atom feed
From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	"Cai Huoqing" <cai.huoqing@linux.dev>,
	"Jingoo Han" <jingoohan1@gmail.com>,
	"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
	"Rob Herring" <robh@kernel.org>,
	"Serge Semin" <fancer.lancer@gmail.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
	Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
	Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
	<linux-pci@vger.kernel.org>, <dmaengine@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH 06/11] PCI: dwc: Drop duplicated fast-link-mode flag unsetting
Date: Fri, 17 Feb 2023 12:39:51 +0300	[thread overview]
Message-ID: <20230217093956.27126-7-Sergey.Semin@baikalelectronics.ru> (raw)
In-Reply-To: <20230217093956.27126-1-Sergey.Semin@baikalelectronics.ru>

Most likely by mistake the PORT_LINK_FAST_LINK_MODE flag unsetting was
added twice in the commit cff9244432e8 ("PCI: dwc: Ensure FAST_LINK_MODE
is cleared"): first it is cleared right after the content of the
PCIE_PORT_LINK_CONTROL register is read, second it's cleared in the
framework of the link-mode initialization procedure. The later action is
redundant. Let's drop it.

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
---
 drivers/pci/controller/dwc/pcie-designware.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
index 3bb9ca14fb9c..ab774665ed87 100644
--- a/drivers/pci/controller/dwc/pcie-designware.c
+++ b/drivers/pci/controller/dwc/pcie-designware.c
@@ -825,7 +825,6 @@ void dw_pcie_setup(struct dw_pcie *pci)
 
 	/* Set the number of lanes */
 	val = dw_pcie_readl_dbi(pci, PCIE_PORT_LINK_CONTROL);
-	val &= ~PORT_LINK_FAST_LINK_MODE;
 	val &= ~PORT_LINK_MODE_MASK;
 	switch (pci->num_lanes) {
 	case 1:
-- 
2.39.0



  parent reply	other threads:[~2023-02-17  9:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-17  9:39 [PATCH 00/11] PCI: dwc: Relatively simple fixes and cleanups Serge Semin
2023-02-17  9:39 ` [PATCH 01/11] PCI: dwc: Fix port link CSR improper init if CDM check enabled Serge Semin
2023-02-17 10:19   ` Serge Semin
2023-02-17  9:39 ` [PATCH 02/11] PCI: dwc: Fix erroneous version type test helper Serge Semin
2023-02-17  9:39 ` [PATCH 03/11] PCI: dwc: Fix inbound iATU entries out-of-bounds warning message Serge Semin
2023-02-17  9:39 ` [PATCH 04/11] PCI: bt1: Enable async probe type Serge Semin
2023-02-17  9:39 ` [PATCH 05/11] PCI: bt1: Fix printing false error message Serge Semin
2023-02-17  9:39 ` Serge Semin [this message]
2023-02-17  9:39 ` [PATCH 07/11] PCI: dwc: Drop empty line from dw_pcie_link_set_max_speed() Serge Semin
2023-02-17  9:39 ` [PATCH 08/11] PCI: visconti: Convert to using generic resources getter Serge Semin
2023-02-17  9:39   ` Serge Semin
2023-02-17  9:39 ` [PATCH 09/11] MAINTAINERS: Add all generic DW PCIe RP/EP DT-schemas Serge Semin
2023-02-17  9:39 ` [PATCH 10/11] MAINTAINERS: Add myself as the DW PCIe core reviewer Serge Semin
2023-02-17  9:39 ` [PATCH 11/11] MAINTAINERS: Add myself as the DW eDMA driver reviewer Serge Semin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230217093956.27126-7-Sergey.Semin@baikalelectronics.ru \
    --to=sergey.semin@baikalelectronics.ru \
    --cc=Alexey.Malahov@baikalelectronics.ru \
    --cc=Pavel.Parkhomenko@baikalelectronics.ru \
    --cc=bhelgaas@google.com \
    --cc=cai.huoqing@linux.dev \
    --cc=dmaengine@vger.kernel.org \
    --cc=fancer.lancer@gmail.com \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=jingoohan1@gmail.com \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=lpieralisi@kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.