From: psykose <alice@ayaya.dev>
To: linux-trace-devel@vger.kernel.org
Cc: psykose <alice@ayaya.dev>
Subject: [PATCH] libtraceevent: fix some missing commas in big endian blocks
Date: Mon, 20 Feb 2023 18:52:41 +0100 [thread overview]
Message-ID: <20230220175241.15424-1-alice@ayaya.dev> (raw)
the lack of a trailing comma makes the array definition invalid, since elements
must be comma delimited in the initialiser. so, add one in the big endian case
too.
Signed-off-by: psykose <alice@ayaya.dev>
---
utest/traceevent-utest.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/utest/traceevent-utest.c b/utest/traceevent-utest.c
index ebd5eb9..041843e 100644
--- a/utest/traceevent-utest.c
+++ b/utest/traceevent-utest.c
@@ -45,7 +45,7 @@ static char dyn_str_data[] = {
#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
/* common type */ 1, 0x00,
#else
- /* common type */ 0x00, 1
+ /* common type */ 0x00, 1,
#endif
/* common flags */ 0x00,
/* common_preempt_count */ 0x00,
@@ -82,7 +82,7 @@ static char dyn_str_old_data[] = {
#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
/* common type */ 2, 0x00,
#else
- /* common type */ 0x00, 2
+ /* common type */ 0x00, 2,
#endif
/* common flags */ 0x00,
/* common_preempt_count */ 0x00,
@@ -166,7 +166,7 @@ static char sizeof_data[] = {
#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
/* common type */ 23, 0x00,
#else
- /* common type */ 0x00, 23
+ /* common type */ 0x00, 23,
#endif
/* common flags */ 0x00,
/* common_preempt_count */ 0x00,
--
2.39.2
next reply other threads:[~2023-02-20 17:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 17:52 psykose [this message]
2023-02-20 18:17 ` [PATCH] libtraceevent: fix some missing commas in big endian blocks Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220175241.15424-1-alice@ayaya.dev \
--to=alice@ayaya.dev \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.