From: Sergey Matyukevich <geomatsi@gmail.com> To: linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>, Zong Li <zong.li@sifive.com>, Guo Ren <guoren@kernel.org>, Albert Ou <aou@eecs.berkeley.edu>, Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley <paul.walmsley@sifive.com>, Sergey Matyukevich <geomatsi@gmail.com> Subject: [PATCH 0/2] riscv: asid: switch to alternative way to fix stale TLB entries Date: Sun, 26 Feb 2023 18:01:35 +0300 [thread overview] Message-ID: <20230226150137.1919750-1-geomatsi@gmail.com> (raw) Hi all, Some time ago two different patches have been posted to fix stale TLB entries that caused applications crashes. The patch [0] suggested 'aggregating' mm_cpumask, i.e. current cpu is not cleared for the switched-out task in switch_mm function. For additional explanations see the commit message by Guo Ren. The same approach is used by arc architecture, so another good comment is for switch_mm in arch/arc/include/asm/mmu_context.h. The patch [1] attempted to reduce the number of TLB flushes by deferring (and possibly avoiding) them for CPUs not running the task. Patch [1] has been merged. However we already have two bug reports from different vendors. So apparently something is missing in the approach suggested in [1]. In both cases the patch [0] fixed the issue. This patch series reverts [1] and replaces it by [0]. Regards, Sergey [0] https://lore.kernel.org/linux-riscv/20221111075902.798571-1-guoren@kernel.org/ [1] https://lore.kernel.org/linux-riscv/20220829205219.283543-1-geomatsi@gmail.com/ Guo Ren (1): riscv: asid: Fixup stale TLB entry cause application crash Sergey Matyukevich (1): Revert "riscv: mm: notify remote harts about mmu cache updates" arch/riscv/include/asm/mmu.h | 2 -- arch/riscv/include/asm/tlbflush.h | 18 -------------- arch/riscv/mm/context.c | 40 +++++++++++++++---------------- arch/riscv/mm/tlbflush.c | 28 +++++++++++++--------- 4 files changed, 37 insertions(+), 51 deletions(-) -- 2.39.2 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Matyukevich <geomatsi@gmail.com> To: linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>, Zong Li <zong.li@sifive.com>, Guo Ren <guoren@kernel.org>, Albert Ou <aou@eecs.berkeley.edu>, Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley <paul.walmsley@sifive.com>, Sergey Matyukevich <geomatsi@gmail.com> Subject: [PATCH 0/2] riscv: asid: switch to alternative way to fix stale TLB entries Date: Sun, 26 Feb 2023 18:01:35 +0300 [thread overview] Message-ID: <20230226150137.1919750-1-geomatsi@gmail.com> (raw) Hi all, Some time ago two different patches have been posted to fix stale TLB entries that caused applications crashes. The patch [0] suggested 'aggregating' mm_cpumask, i.e. current cpu is not cleared for the switched-out task in switch_mm function. For additional explanations see the commit message by Guo Ren. The same approach is used by arc architecture, so another good comment is for switch_mm in arch/arc/include/asm/mmu_context.h. The patch [1] attempted to reduce the number of TLB flushes by deferring (and possibly avoiding) them for CPUs not running the task. Patch [1] has been merged. However we already have two bug reports from different vendors. So apparently something is missing in the approach suggested in [1]. In both cases the patch [0] fixed the issue. This patch series reverts [1] and replaces it by [0]. Regards, Sergey [0] https://lore.kernel.org/linux-riscv/20221111075902.798571-1-guoren@kernel.org/ [1] https://lore.kernel.org/linux-riscv/20220829205219.283543-1-geomatsi@gmail.com/ Guo Ren (1): riscv: asid: Fixup stale TLB entry cause application crash Sergey Matyukevich (1): Revert "riscv: mm: notify remote harts about mmu cache updates" arch/riscv/include/asm/mmu.h | 2 -- arch/riscv/include/asm/tlbflush.h | 18 -------------- arch/riscv/mm/context.c | 40 +++++++++++++++---------------- arch/riscv/mm/tlbflush.c | 28 +++++++++++++--------- 4 files changed, 37 insertions(+), 51 deletions(-) -- 2.39.2
next reply other threads:[~2023-02-26 15:02 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-26 15:01 Sergey Matyukevich [this message] 2023-02-26 15:01 ` [PATCH 0/2] riscv: asid: switch to alternative way to fix stale TLB entries Sergey Matyukevich 2023-02-26 15:01 ` [PATCH 1/2] Revert "riscv: mm: notify remote harts about mmu cache updates" Sergey Matyukevich 2023-02-26 15:01 ` Sergey Matyukevich 2023-02-28 3:15 ` Guo Ren 2023-02-28 3:15 ` Guo Ren 2023-02-26 15:01 ` [PATCH 2/2] riscv: asid: Fixup stale TLB entry cause application crash Sergey Matyukevich 2023-02-26 15:01 ` Sergey Matyukevich 2023-02-26 16:44 ` Andrew Jones 2023-02-26 16:44 ` Andrew Jones 2023-03-10 2:30 ` [PATCH 0/2] riscv: asid: switch to alternative way to fix stale TLB entries patchwork-bot+linux-riscv 2023-03-10 2:30 ` patchwork-bot+linux-riscv
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230226150137.1919750-1-geomatsi@gmail.com \ --to=geomatsi@gmail.com \ --cc=aou@eecs.berkeley.edu \ --cc=guoren@kernel.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \ --cc=zong.li@sifive.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.