All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Matt Turner <mattst88@gmail.com>,
	Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: [RFC 11/12] drm/i915: Mark waits as explicit
Date: Tue,  7 Mar 2023 10:48:23 +0000	[thread overview]
Message-ID: <20230307104824.231094-12-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20230307104824.231094-1-tvrtko.ursulin@linux.intel.com>

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Use the previously added dma-fence API to mark the direct i915 waits as
explicit. This has no significant effect apart from following the new
pattern.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/i915_request.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
index 42b04cced6f0..dd8a9045086a 100644
--- a/drivers/gpu/drm/i915/i915_request.c
+++ b/drivers/gpu/drm/i915/i915_request.c
@@ -2045,7 +2045,8 @@ long i915_request_wait_timeout(struct i915_request *rq,
 		intel_rps_boost(rq);
 
 	wait.tsk = current;
-	if (dma_fence_add_callback(&rq->fence, &wait.cb, request_wait_wake))
+	if (dma_fence_add_wait_callback(&rq->fence, &wait.cb,
+					request_wait_wake))
 		goto out;
 
 	/*
-- 
2.37.2


WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Matt Turner <mattst88@gmail.com>
Subject: [Intel-gfx] [RFC 11/12] drm/i915: Mark waits as explicit
Date: Tue,  7 Mar 2023 10:48:23 +0000	[thread overview]
Message-ID: <20230307104824.231094-12-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20230307104824.231094-1-tvrtko.ursulin@linux.intel.com>

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Use the previously added dma-fence API to mark the direct i915 waits as
explicit. This has no significant effect apart from following the new
pattern.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/i915_request.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
index 42b04cced6f0..dd8a9045086a 100644
--- a/drivers/gpu/drm/i915/i915_request.c
+++ b/drivers/gpu/drm/i915/i915_request.c
@@ -2045,7 +2045,8 @@ long i915_request_wait_timeout(struct i915_request *rq,
 		intel_rps_boost(rq);
 
 	wait.tsk = current;
-	if (dma_fence_add_callback(&rq->fence, &wait.cb, request_wait_wake))
+	if (dma_fence_add_wait_callback(&rq->fence, &wait.cb,
+					request_wait_wake))
 		goto out;
 
 	/*
-- 
2.37.2


  parent reply	other threads:[~2023-03-07 10:49 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 10:48 [RFC v4 00/12] Waitboost drm syncobj waits Tvrtko Ursulin
2023-03-07 10:48 ` [Intel-gfx] " Tvrtko Ursulin
2023-03-07 10:48 ` [RFC 01/12] dma-fence: Move i915 helpers into common Tvrtko Ursulin
2023-03-07 10:48   ` [Intel-gfx] " Tvrtko Ursulin
2023-03-07 10:48 ` [RFC 02/12] dma-fence: Add callback initialization helper Tvrtko Ursulin
2023-03-07 10:48   ` [Intel-gfx] " Tvrtko Ursulin
2023-03-07 10:48 ` [RFC 03/12] drm/i915: Use fence " Tvrtko Ursulin
2023-03-07 10:48   ` [Intel-gfx] " Tvrtko Ursulin
2023-03-07 10:48 ` [RFC 04/12] drm/vmwgfx: " Tvrtko Ursulin
2023-03-07 10:48   ` [Intel-gfx] " Tvrtko Ursulin
2023-03-07 10:48 ` [RFC 05/12] dma-fence: Track explicit waiters Tvrtko Ursulin
2023-03-07 10:48   ` [Intel-gfx] " Tvrtko Ursulin
2023-03-07 10:48 ` [RFC 06/12] dma-fence: Export __dma_fence_add_callback Tvrtko Ursulin
2023-03-07 10:48   ` [Intel-gfx] " Tvrtko Ursulin
2023-03-07 10:48 ` [RFC 07/12] dma-fence-array: Propagate wait status to contained fences Tvrtko Ursulin
2023-03-07 10:48   ` [Intel-gfx] " Tvrtko Ursulin
2023-03-07 10:48 ` [RFC 08/12] dma-fence-chain: " Tvrtko Ursulin
2023-03-07 10:48   ` [Intel-gfx] " Tvrtko Ursulin
2023-03-07 10:48 ` [RFC 09/12] drm/syncobj: Mark syncobj waits as external waiters Tvrtko Ursulin
2023-03-07 10:48   ` [Intel-gfx] " Tvrtko Ursulin
2023-03-07 10:48 ` [RFC 10/12] drm/i915: Waitboost external waits Tvrtko Ursulin
2023-03-07 10:48   ` [Intel-gfx] " Tvrtko Ursulin
2023-03-07 10:48 ` Tvrtko Ursulin [this message]
2023-03-07 10:48   ` [Intel-gfx] [RFC 11/12] drm/i915: Mark waits as explicit Tvrtko Ursulin
2023-03-07 10:48 ` [RFC 12/12] drm/i915: Wait boost requests waited upon by others Tvrtko Ursulin
2023-03-07 10:48   ` [Intel-gfx] " Tvrtko Ursulin
2023-03-07 12:28 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for Waitboost drm syncobj waits (rev4) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230307104824.231094-12-tvrtko.ursulin@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mattst88@gmail.com \
    --cc=tvrtko.ursulin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.