[PATCH] test: simplify counts aggregation

From: Felipe Contreras <felipe.contreras@gmail.com>
To: git@vger.kernel.org
Cc: Fabian Stelzer <fs@gigacodes.de>,
	Brandon Casey <drafnel@gmail.com>,
	Felipe Contreras <felipe.contreras@gmail.com>
Subject: [PATCH] test: simplify counts aggregation
Date: Wed,  8 Mar 2023 03:05:36 -0600	[thread overview]
Message-ID: <20230308090536.2562917-1-felipe.contreras@gmail.com> (raw)

When the list of files as input was implemented in 6508eedf67
(t/aggregate-results: accomodate systems with small max argument list
length, 2010-06-01), a much simpler solution wasn't considered.

Let's just pass the pattern as an argument.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 t/Makefile             | 4 +---
 t/aggregate-results.sh | 2 +-
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/t/Makefile b/t/Makefile
index 2c2b252240..6bc878558f 100644
--- a/t/Makefile
+++ b/t/Makefile
@@ -140,9 +140,7 @@ aggregate-results-and-cleanup: $(T)
 	$(MAKE) clean
 
 aggregate-results:
-	for f in '$(TEST_RESULTS_DIRECTORY_SQ)'/t*-*.counts; do \
-		echo "$$f"; \
-	done | '$(SHELL_PATH_SQ)' ./aggregate-results.sh
+	'$(SHELL_PATH_SQ)' ./aggregate-results.sh '$(TEST_RESULTS_DIRECTORY_SQ)/t*-*.counts'
 
 valgrind:
 	$(MAKE) GIT_TEST_OPTS="$(GIT_TEST_OPTS) --valgrind"
diff --git a/t/aggregate-results.sh b/t/aggregate-results.sh
index 7f2b83bdc8..2efc2c37cd 100755
--- a/t/aggregate-results.sh
+++ b/t/aggregate-results.sh
@@ -8,7 +8,7 @@ broken=0
 total=0
 missing_prereq=
 
-while read file
+for file in $1
 do
 	while read type value
 	do
-- 
2.39.2

