All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Tony Lindgren <tony@atomide.com>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 7/9] regulator: rpi-panel-attiny: Drop of_match_ptr for ID table
Date: Fri, 10 Mar 2023 22:45:51 +0100	[thread overview]
Message-ID: <20230310214553.275450-7-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20230310214553.275450-1-krzysztof.kozlowski@linaro.org>

The driver can match only via the DT table so the table should be always
used and the of_match_ptr does not have any sense (this also allows ACPI
matching via PRP0001, even though it is not relevant here).

  drivers/regulator/rpi-panel-attiny-regulator.c:390:34: error: ‘attiny_dt_ids’ defined but not used [-Werror=unused-const-variable=]

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/regulator/rpi-panel-attiny-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/rpi-panel-attiny-regulator.c b/drivers/regulator/rpi-panel-attiny-regulator.c
index 34514976475e..3953fc1f389f 100644
--- a/drivers/regulator/rpi-panel-attiny-regulator.c
+++ b/drivers/regulator/rpi-panel-attiny-regulator.c
@@ -396,7 +396,7 @@ MODULE_DEVICE_TABLE(of, attiny_dt_ids);
 static struct i2c_driver attiny_regulator_driver = {
 	.driver = {
 		.name = "rpi_touchscreen_attiny",
-		.of_match_table = of_match_ptr(attiny_dt_ids),
+		.of_match_table = attiny_dt_ids,
 	},
 	.probe_new = attiny_i2c_probe,
 	.remove	= attiny_i2c_remove,
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	Tony Lindgren <tony@atomide.com>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 7/9] regulator: rpi-panel-attiny: Drop of_match_ptr for ID table
Date: Fri, 10 Mar 2023 22:45:51 +0100	[thread overview]
Message-ID: <20230310214553.275450-7-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20230310214553.275450-1-krzysztof.kozlowski@linaro.org>

The driver can match only via the DT table so the table should be always
used and the of_match_ptr does not have any sense (this also allows ACPI
matching via PRP0001, even though it is not relevant here).

  drivers/regulator/rpi-panel-attiny-regulator.c:390:34: error: ‘attiny_dt_ids’ defined but not used [-Werror=unused-const-variable=]

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/regulator/rpi-panel-attiny-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/rpi-panel-attiny-regulator.c b/drivers/regulator/rpi-panel-attiny-regulator.c
index 34514976475e..3953fc1f389f 100644
--- a/drivers/regulator/rpi-panel-attiny-regulator.c
+++ b/drivers/regulator/rpi-panel-attiny-regulator.c
@@ -396,7 +396,7 @@ MODULE_DEVICE_TABLE(of, attiny_dt_ids);
 static struct i2c_driver attiny_regulator_driver = {
 	.driver = {
 		.name = "rpi_touchscreen_attiny",
-		.of_match_table = of_match_ptr(attiny_dt_ids),
+		.of_match_table = attiny_dt_ids,
 	},
 	.probe_new = attiny_i2c_probe,
 	.remove	= attiny_i2c_remove,
-- 
2.34.1


  parent reply	other threads:[~2023-03-10 21:50 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 21:45 [PATCH 1/9] regulator: lp872x: Mark OF related data as maybe unused Krzysztof Kozlowski
2023-03-10 21:45 ` Krzysztof Kozlowski
2023-03-10 21:45 ` [PATCH 2/9] regulator: max20086: " Krzysztof Kozlowski
2023-03-10 21:45   ` Krzysztof Kozlowski
2023-03-12  9:42   ` Laurent Pinchart
2023-03-12  9:42     ` Laurent Pinchart
2023-03-12 10:03     ` Krzysztof Kozlowski
2023-03-12 10:03       ` Krzysztof Kozlowski
2023-03-10 21:45 ` [PATCH 3/9] regulator: mp8859: " Krzysztof Kozlowski
2023-03-10 21:45   ` Krzysztof Kozlowski
2023-03-10 21:45 ` [PATCH 4/9] regulator: mt6397-regulator: " Krzysztof Kozlowski
2023-03-10 21:45   ` Krzysztof Kozlowski
2023-03-13  8:45   ` AngeloGioacchino Del Regno
2023-03-13  8:45     ` AngeloGioacchino Del Regno
2023-03-10 21:45 ` [PATCH 5/9] regulator: qcom_rpm: Drop of_match_ptr for ID table Krzysztof Kozlowski
2023-03-10 21:45   ` Krzysztof Kozlowski
2023-03-10 21:45 ` [PATCH 6/9] regulator: pbias: " Krzysztof Kozlowski
2023-03-10 21:45   ` Krzysztof Kozlowski
2023-03-10 21:45 ` Krzysztof Kozlowski [this message]
2023-03-10 21:45   ` [PATCH 7/9] regulator: rpi-panel-attiny: " Krzysztof Kozlowski
2023-03-15  9:12   ` Neil Armstrong
2023-03-15  9:12     ` Neil Armstrong
2023-03-10 21:45 ` [PATCH 8/9] regulator: twl: " Krzysztof Kozlowski
2023-03-10 21:45   ` Krzysztof Kozlowski
2023-03-10 21:45 ` [PATCH 9/9] regulator: twl6030: " Krzysztof Kozlowski
2023-03-10 21:45   ` Krzysztof Kozlowski
2023-03-13 13:58 ` [PATCH 1/9] regulator: lp872x: Mark OF related data as maybe unused Mark Brown
2023-03-13 13:58   ` Mark Brown
2023-03-13 19:07 ` (subset) " Mark Brown
2023-03-13 19:07   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230310214553.275450-7-krzysztof.kozlowski@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=broonie@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.