All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH v4 03/10] media: samsung: exynos4-is: drop simple-bus from compatibles
Date: Mon, 13 Mar 2023 15:49:09 +0100	[thread overview]
Message-ID: <20230313144916.511884-4-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20230313144916.511884-1-krzysztof.kozlowski@linaro.org>

The FIMC camera node wrapper is not a bus, so using simple-bus fallback
compatible just to instantiate its children nodes was never correct.
Driver should explicitly populate all its children devices.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Changes since v1:
1. Do not depopulate on errors because it causes several errors.
---
 drivers/media/platform/samsung/exynos4-is/media-dev.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.c b/drivers/media/platform/samsung/exynos4-is/media-dev.c
index 22baa429ed5d..6839007edf1d 100644
--- a/drivers/media/platform/samsung/exynos4-is/media-dev.c
+++ b/drivers/media/platform/samsung/exynos4-is/media-dev.c
@@ -1440,6 +1440,10 @@ static int fimc_md_probe(struct platform_device *pdev)
 	if (!fmd)
 		return -ENOMEM;
 
+	ret = of_platform_populate(dev->of_node, NULL, NULL, dev);
+	if (ret < 0)
+		return -ENOMEM;
+
 	spin_lock_init(&fmd->slock);
 	INIT_LIST_HEAD(&fmd->pipelines);
 	fmd->pdev = pdev;
-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH v4 03/10] media: samsung: exynos4-is: drop simple-bus from compatibles
Date: Mon, 13 Mar 2023 15:49:09 +0100	[thread overview]
Message-ID: <20230313144916.511884-4-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20230313144916.511884-1-krzysztof.kozlowski@linaro.org>

The FIMC camera node wrapper is not a bus, so using simple-bus fallback
compatible just to instantiate its children nodes was never correct.
Driver should explicitly populate all its children devices.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Changes since v1:
1. Do not depopulate on errors because it causes several errors.
---
 drivers/media/platform/samsung/exynos4-is/media-dev.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.c b/drivers/media/platform/samsung/exynos4-is/media-dev.c
index 22baa429ed5d..6839007edf1d 100644
--- a/drivers/media/platform/samsung/exynos4-is/media-dev.c
+++ b/drivers/media/platform/samsung/exynos4-is/media-dev.c
@@ -1440,6 +1440,10 @@ static int fimc_md_probe(struct platform_device *pdev)
 	if (!fmd)
 		return -ENOMEM;
 
+	ret = of_platform_populate(dev->of_node, NULL, NULL, dev);
+	if (ret < 0)
+		return -ENOMEM;
+
 	spin_lock_init(&fmd->slock);
 	INIT_LIST_HEAD(&fmd->pipelines);
 	fmd->pdev = pdev;
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-03-13 14:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13 14:49 [PATCH v4 00/10] media: samsung: dt-bindings conversion and minor fixes Krzysztof Kozlowski
2023-03-13 14:49 ` Krzysztof Kozlowski
2023-03-13 14:49 ` [PATCH v4 01/10] media: dt-bindings: samsung-fimc: drop simple-bus Krzysztof Kozlowski
2023-03-13 14:49   ` Krzysztof Kozlowski
2023-03-13 14:49 ` [PATCH v4 02/10] media: samsung: exynos4-is: do not require pinctrl Krzysztof Kozlowski
2023-03-13 14:49   ` Krzysztof Kozlowski
2023-03-13 14:49 ` Krzysztof Kozlowski [this message]
2023-03-13 14:49   ` [PATCH v4 03/10] media: samsung: exynos4-is: drop simple-bus from compatibles Krzysztof Kozlowski
2023-03-13 14:49 ` [PATCH v4 04/10] media: dt-bindings: i2c: samsung,s5k6a3: convert to dtschema Krzysztof Kozlowski
2023-03-13 14:49   ` Krzysztof Kozlowski
2023-03-13 14:49 ` [PATCH v4 05/10] media: dt-bindings: i2c: samsung,s5k5baf: " Krzysztof Kozlowski
2023-03-13 14:49   ` Krzysztof Kozlowski
2023-03-13 14:49 ` [PATCH v4 06/10] media: dt-bindings: samsung,exynos4210-csis: " Krzysztof Kozlowski
2023-03-13 14:49   ` Krzysztof Kozlowski
2023-03-13 14:49 ` [PATCH v4 07/10] media: dt-bindings: samsung,exynos4212-fimc-lite: " Krzysztof Kozlowski
2023-03-13 14:49   ` Krzysztof Kozlowski
2023-03-13 14:49 ` [PATCH v4 08/10] media: dt-bindings: samsung,exynos4212-is: " Krzysztof Kozlowski
2023-03-13 14:49   ` Krzysztof Kozlowski
2023-03-13 14:49 ` [PATCH v4 09/10] media: dt-bindings: samsung,fimc: " Krzysztof Kozlowski
2023-03-13 14:49   ` Krzysztof Kozlowski
2023-03-13 14:49 ` [PATCH v4 10/10] media: dt-bindings: samsung,s5c73m3: " Krzysztof Kozlowski
2023-03-13 14:49   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230313144916.511884-4-krzysztof.kozlowski@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alim.akhtar@samsung.com \
    --cc=andrzej.hajda@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.nawrocki@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.