All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Christoph Lameter <cl@linux.com>
Cc: Aaron Tomlin <atomlin@atomlin.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Russell King <linux@armlinux.org.uk>,
	Huacai Chen <chenhuacai@kernel.org>,
	Heiko Carstens <hca@linux.ibm.com>,
	x86@kernel.org, Vlastimil Babka <vbabka@suse.cz>,
	Marcelo Tosatti <mtosatti@redhat.com>
Subject: [PATCH v5 11/12] mm/vmstat: refresh stats remotely instead of via work item
Date: Mon, 13 Mar 2023 13:25:18 -0300	[thread overview]
Message-ID: <20230313162634.535939407@redhat.com> (raw)
In-Reply-To: 20230313162507.032200398@redhat.com

Refresh per-CPU stats remotely, instead of queueing 
work items, for the stat_refresh procfs method.

This fixes sosreport hang (which uses vmstat_refresh) with
spinning SCHED_FIFO process.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

Index: linux-vmstat-remote/mm/vmstat.c
===================================================================
--- linux-vmstat-remote.orig/mm/vmstat.c
+++ linux-vmstat-remote/mm/vmstat.c
@@ -1901,11 +1901,20 @@ static DEFINE_PER_CPU(struct delayed_wor
 int sysctl_stat_interval __read_mostly = HZ;
 
 #ifdef CONFIG_PROC_FS
+#ifdef CONFIG_HAVE_CMPXCHG_LOCAL
+static int refresh_all_vm_stats(void);
+#else
 static void refresh_vm_stats(struct work_struct *work)
 {
 	refresh_cpu_vm_stats(true);
 }
 
+static int refresh_all_vm_stats(void)
+{
+	return schedule_on_each_cpu(refresh_vm_stats);
+}
+#endif
+
 int vmstat_refresh(struct ctl_table *table, int write,
 		   void *buffer, size_t *lenp, loff_t *ppos)
 {
@@ -1925,7 +1934,7 @@ int vmstat_refresh(struct ctl_table *tab
 	 * transiently negative values, report an error here if any of
 	 * the stats is negative, so we know to go looking for imbalance.
 	 */
-	err = schedule_on_each_cpu(refresh_vm_stats);
+	err = refresh_all_vm_stats();
 	if (err)
 		return err;
 	for (i = 0; i < NR_VM_ZONE_STAT_ITEMS; i++) {
@@ -2045,7 +2054,7 @@ static DECLARE_DEFERRABLE_WORK(shepherd,
 
 #ifdef CONFIG_HAVE_CMPXCHG_LOCAL
 /* Flush counters remotely if CPU uses cmpxchg to update its per-CPU counters */
-static void vmstat_shepherd(struct work_struct *w)
+static int refresh_all_vm_stats(void)
 {
 	int cpu;
 
@@ -2055,7 +2064,12 @@ static void vmstat_shepherd(struct work_
 		cond_resched();
 	}
 	cpus_read_unlock();
+	return 0;
+}
 
+static void vmstat_shepherd(struct work_struct *w)
+{
+	refresh_all_vm_stats();
 	schedule_delayed_work(&shepherd,
 		round_jiffies_relative(sysctl_stat_interval));
 }



  parent reply	other threads:[~2023-03-13 16:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13 16:25 [PATCH v5 00/12] fold per-CPU vmstats remotely Marcelo Tosatti
2023-03-13 16:25 ` [PATCH v5 01/12] this_cpu_cmpxchg: ARM64: switch this_cpu_cmpxchg to locked, add _local function Marcelo Tosatti
2023-03-13 16:25 ` [PATCH v5 02/12] this_cpu_cmpxchg: loongarch: " Marcelo Tosatti
2023-03-13 16:25 ` [PATCH v5 03/12] this_cpu_cmpxchg: S390: " Marcelo Tosatti
2023-03-13 16:25 ` [PATCH v5 04/12] this_cpu_cmpxchg: x86: " Marcelo Tosatti
2023-03-13 16:25 ` [PATCH v5 05/12] add this_cpu_cmpxchg_local and asm-generic definitions Marcelo Tosatti
2023-03-13 16:25 ` [PATCH v5 06/12] convert this_cpu_cmpxchg users to this_cpu_cmpxchg_local Marcelo Tosatti
2023-03-13 16:25 ` [PATCH v5 07/12] mm/vmstat: switch counter modification to cmpxchg Marcelo Tosatti
2023-03-13 16:25 ` [PATCH v5 08/12] vmstat: switch per-cpu vmstat counters to 32-bits Marcelo Tosatti
2023-03-13 16:25 ` [PATCH v5 09/12] mm/vmstat: use xchg in cpu_vm_stats_fold Marcelo Tosatti
2023-03-13 16:25 ` [PATCH v5 10/12] mm/vmstat: switch vmstat shepherd to flush per-CPU counters remotely Marcelo Tosatti
2023-03-13 16:25 ` Marcelo Tosatti [this message]
2023-03-13 16:25 ` [PATCH v5 12/12] vmstat: add pcp remote node draining via cpu_vm_stats_fold Marcelo Tosatti
2023-03-14 12:25 ` [PATCH v5 00/12] fold per-CPU vmstats remotely Michal Hocko
2023-03-14 12:59   ` Marcelo Tosatti
2023-03-14 13:00     ` Marcelo Tosatti
2023-03-14 14:31     ` Michal Hocko
2023-03-14 18:49       ` Marcelo Tosatti
2023-03-14 21:01         ` Michal Hocko
2023-03-15  0:29           ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230313162634.535939407@redhat.com \
    --to=mtosatti@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=atomlin@atomlin.com \
    --cc=chenhuacai@kernel.org \
    --cc=cl@linux.com \
    --cc=frederic@kernel.org \
    --cc=hca@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@armlinux.org.uk \
    --cc=vbabka@suse.cz \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.