All of lore.kernel.org
 help / color / mirror / Atom feed
From: Niklas Schnelle <schnelle@linux.ibm.com>
To: Arnd Bergmann <arnd@arndb.de>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Alan Stern" <stern@rowland.harvard.edu>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	linux-pci@vger.kernel.org, "Arnd Bergmann" <arnd@kernel.org>,
	linux-input@vger.kernel.org
Subject: [PATCH v3 14/38] Input: gameport: add ISA and HAS_IOPORT dependencies
Date: Tue, 14 Mar 2023 13:11:52 +0100	[thread overview]
Message-ID: <20230314121216.413434-15-schnelle@linux.ibm.com> (raw)
In-Reply-To: <20230314121216.413434-1-schnelle@linux.ibm.com>

In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
not being declared. As ISA already implies HAS_IOPORT we can simply add
this dependency and guard sections of code using inb()/outb() as
alternative access methods.

Co-developed-by: Arnd Bergmann <arnd@kernel.org>
Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
---
 drivers/input/gameport/Kconfig | 4 +++-
 include/linux/gameport.h       | 9 +++++++--
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/drivers/input/gameport/Kconfig b/drivers/input/gameport/Kconfig
index 5a2c2fb3217d..fe73b26e647a 100644
--- a/drivers/input/gameport/Kconfig
+++ b/drivers/input/gameport/Kconfig
@@ -25,6 +25,7 @@ if GAMEPORT
 
 config GAMEPORT_NS558
 	tristate "Classic ISA and PnP gameport support"
+	depends on ISA
 	help
 	  Say Y here if you have an ISA or PnP gameport.
 
@@ -35,6 +36,7 @@ config GAMEPORT_NS558
 
 config GAMEPORT_L4
 	tristate "PDPI Lightning 4 gamecard support"
+	depends on ISA
 	help
 	  Say Y here if you have a PDPI Lightning 4 gamecard.
 
@@ -53,7 +55,7 @@ config GAMEPORT_EMU10K1
 
 config GAMEPORT_FM801
 	tristate "ForteMedia FM801 gameport support"
-	depends on PCI
+	depends on PCI && HAS_IOPORT
 	help
 	  Say Y here if you have ForteMedia FM801 PCI audio controller
 	  (Abit AU10, Genius Sound Maker, HP Workstation zx2000,
diff --git a/include/linux/gameport.h b/include/linux/gameport.h
index 8c2f00018e89..4d5720022b63 100644
--- a/include/linux/gameport.h
+++ b/include/linux/gameport.h
@@ -167,16 +167,21 @@ static inline void gameport_trigger(struct gameport *gameport)
 {
 	if (gameport->trigger)
 		gameport->trigger(gameport);
+#ifdef CONFIG_HAS_IOPORT
 	else
 		outb(0xff, gameport->io);
+#endif
 }
 
 static inline unsigned char gameport_read(struct gameport *gameport)
 {
 	if (gameport->read)
 		return gameport->read(gameport);
-	else
-		return inb(gameport->io);
+#ifdef CONFIG_HAS_IOPORT
+	return inb(gameport->io);
+#else
+	return 0xff;
+#endif
 }
 
 static inline int gameport_cooked_read(struct gameport *gameport, int *axes, int *buttons)
-- 
2.37.2


  parent reply	other threads:[~2023-03-14 12:15 UTC|newest]

Thread overview: 163+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 12:11 [PATCH v3 00/38] Kconfig: Introduce HAS_IOPORT config option Niklas Schnelle
2023-03-14 12:11 ` Niklas Schnelle
2023-03-14 12:11 ` [PATCH v3 01/38] Kconfig: introduce HAS_IOPORT option and select it as necessary Niklas Schnelle
2023-03-14 12:11   ` Niklas Schnelle
2023-03-14 12:11   ` Niklas Schnelle
2023-03-14 12:11   ` Niklas Schnelle
2023-03-14 12:11   ` Niklas Schnelle
2023-03-14 12:11   ` Niklas Schnelle
2023-03-14 12:37   ` Johannes Berg
2023-03-14 12:37     ` Johannes Berg
2023-03-14 12:37     ` Johannes Berg
2023-03-14 12:37     ` Johannes Berg
2023-03-14 12:37     ` Johannes Berg
2023-03-14 12:37     ` Johannes Berg
2023-03-23 13:23     ` Niklas Schnelle
2023-03-23 13:23       ` Niklas Schnelle
2023-03-23 13:23       ` Niklas Schnelle
2023-03-23 13:23       ` Niklas Schnelle
2023-03-23 13:23       ` Niklas Schnelle
2023-03-23 13:23       ` Niklas Schnelle
2023-03-14 12:48   ` Geert Uytterhoeven
2023-03-14 12:48     ` Geert Uytterhoeven
2023-03-14 12:48     ` Geert Uytterhoeven
2023-03-14 12:48     ` Geert Uytterhoeven
2023-03-14 12:48     ` Geert Uytterhoeven
2023-03-14 12:48     ` Geert Uytterhoeven
2023-03-14 13:29   ` Arnd Bergmann
2023-03-14 13:29     ` Arnd Bergmann
2023-03-14 13:29     ` Arnd Bergmann
2023-03-14 13:29     ` Arnd Bergmann
2023-03-14 13:29     ` Arnd Bergmann
2023-03-14 13:29     ` Arnd Bergmann
2023-03-14 16:11     ` Niklas Schnelle
2023-03-14 16:11       ` Niklas Schnelle
2023-03-14 16:11       ` Niklas Schnelle
2023-03-14 16:11       ` Niklas Schnelle
2023-03-14 16:11       ` Niklas Schnelle
2023-03-14 16:11       ` Niklas Schnelle
2023-03-14 16:37   ` Niklas Schnelle
2023-03-14 16:37     ` Niklas Schnelle
2023-03-14 16:37     ` Niklas Schnelle
2023-03-14 16:37     ` Niklas Schnelle
2023-03-14 16:37     ` Niklas Schnelle
2023-03-14 16:37     ` Niklas Schnelle
2023-03-14 12:11 ` [PATCH v3 02/38] ata: add HAS_IOPORT dependencies Niklas Schnelle
2023-03-15  1:23   ` Damien Le Moal
2023-03-15  6:46     ` Arnd Bergmann
2023-03-15  7:15       ` Damien Le Moal
2023-03-15  7:15   ` Damien Le Moal
2023-03-15  8:39   ` Geert Uytterhoeven
2023-03-15  9:12     ` Damien Le Moal
2023-03-15 11:36       ` Geert Uytterhoeven
2023-03-15 23:57         ` Damien Le Moal
2023-03-16 15:21           ` Arnd Bergmann
2023-04-28 13:32             ` Niklas Schnelle
2023-03-14 12:11 ` [PATCH v3 03/38] char: impi, tpm: depend on HAS_IOPORT Niklas Schnelle
2023-03-14 12:20   ` Jarkko Sakkinen
2023-03-14 14:01     ` Arnd Bergmann
2023-03-14 13:52   ` Corey Minyard
2023-03-14 14:17   ` Geert Uytterhoeven
2023-03-14 15:08     ` Arnd Bergmann
2023-03-21 14:33   ` Jason Gunthorpe
2023-03-14 12:11 ` [PATCH v3 04/38] comedi: add HAS_IOPORT dependencies Niklas Schnelle
2023-03-14 12:11 ` [PATCH v3 05/38] counter: " Niklas Schnelle
2023-03-14 12:41   ` William Breathitt Gray
2023-04-28 13:27     ` Niklas Schnelle
2023-03-14 12:11 ` [PATCH v3 06/38] /dev/port: don't compile file operations without CONFIG_DEVPORT Niklas Schnelle
2023-03-14 12:11 ` [PATCH v3 07/38] drm: handle HAS_IOPORT dependencies Niklas Schnelle
2023-03-14 12:11   ` Niklas Schnelle
2023-03-15 11:54   ` Jani Nikula
2023-03-15 11:54     ` Jani Nikula
2023-03-15 11:54     ` Jani Nikula
2023-03-23 15:05     ` Niklas Schnelle
2023-03-23 15:05       ` Niklas Schnelle
2023-03-14 12:11 ` [PATCH v3 08/38] firmware: dmi-sysfs: handle HAS_IOPORT=n Niklas Schnelle
2023-03-14 12:11 ` [PATCH v3 09/38] gpio: add HAS_IOPORT dependencies Niklas Schnelle
2023-03-15  8:42   ` Linus Walleij
2023-04-28 14:41     ` Niklas Schnelle
2023-05-01 12:29       ` Linus Walleij
2023-03-14 12:11 ` [PATCH v3 10/38] hwmon: " Niklas Schnelle
2023-03-14 12:11 ` [PATCH v3 11/38] i2c: " Niklas Schnelle
2023-03-14 12:11 ` [PATCH v3 12/38] iio: ad7606: Kconfig: " Niklas Schnelle
2023-03-14 12:11 ` [PATCH v3 13/38] Input: " Niklas Schnelle
2023-03-15  8:22   ` Geert Uytterhoeven
2023-04-28 14:50     ` Niklas Schnelle
2023-03-14 12:11 ` Niklas Schnelle [this message]
2023-03-14 12:11 ` [PATCH v3 15/38] leds: " Niklas Schnelle
2023-03-16 16:14   ` Lee Jones
2023-03-23 12:42     ` Niklas Schnelle
2023-03-23 13:32       ` Arnd Bergmann
2023-03-23 14:02         ` Niklas Schnelle
2023-03-23 14:05           ` Arnd Bergmann
2023-03-23 16:11         ` Geert Uytterhoeven
2023-03-23 16:25           ` Arnd Bergmann
2023-03-23 14:53       ` Lee Jones
2023-03-23 15:33         ` Niklas Schnelle
2023-03-14 12:11 ` [PATCH v3 16/38] media: " Niklas Schnelle
2023-03-14 12:11 ` [PATCH v3 17/38] misc: " Niklas Schnelle
2023-03-14 12:11 ` [PATCH v3 18/38] mISDN: " Niklas Schnelle
2023-03-15  5:41   ` Jakub Kicinski
2023-03-14 12:11 ` [PATCH v3 19/38] mpt fusion: " Niklas Schnelle
2023-03-14 12:11 ` [Intel-wired-lan] [PATCH v3 20/38] net: handle " Niklas Schnelle
2023-03-14 12:11   ` Niklas Schnelle
2023-03-15  5:41   ` Jakub Kicinski
2023-03-15  5:41     ` Jakub Kicinski
2023-03-15  5:41     ` [Intel-wired-lan] " Jakub Kicinski
2023-03-15  9:47   ` Maciej W. Rozycki
2023-03-15  9:47     ` Maciej W. Rozycki
2023-03-14 12:11 ` [PATCH v3 21/38] parport: PC style parport depends on HAS_IOPORT Niklas Schnelle
2023-03-14 14:12   ` Arnd Bergmann
2023-05-02 13:40     ` Niklas Schnelle
2023-05-02 15:30   ` Bjorn Helgaas
2023-03-14 12:12 ` [PATCH v3 22/38] PCI: Make quirk using inw() depend " Niklas Schnelle
2023-03-14 12:12 ` [PATCH v3 23/38] PCI/sysfs: Make I/O resource " Niklas Schnelle
2023-03-14 16:05   ` Bjorn Helgaas
2023-03-14 12:12 ` [PATCH v3 24/38] pcmcia: add HAS_IOPORT dependencies Niklas Schnelle
2023-03-14 12:12 ` [PATCH v3 25/38] platform: " Niklas Schnelle
2023-03-15  2:21   ` Tzung-Bi Shih
2023-03-14 12:12 ` [PATCH v3 26/38] pnp: " Niklas Schnelle
2023-03-20 17:37   ` Rafael J. Wysocki
2023-03-21 13:56     ` Rafael J. Wysocki
2023-03-23 12:55       ` Niklas Schnelle
2023-03-24 18:45         ` Wysocki, Rafael J
2023-03-14 12:12 ` [PATCH v3 27/38] power: " Niklas Schnelle
2023-03-29 23:01   ` Sebastian Reichel
2023-03-14 12:12 ` [PATCH v3 28/38] rtc: " Niklas Schnelle
2023-03-14 12:52   ` Alexandre Belloni
2023-05-08 15:36     ` Niklas Schnelle
2023-05-08 20:01       ` Arnd Bergmann
2023-05-09  6:38         ` Geert Uytterhoeven
2023-05-09  8:22           ` Arnd Bergmann
2023-05-09  8:51             ` Geert Uytterhoeven
2023-05-09  9:46               ` Arnd Bergmann
2023-03-14 12:12 ` [PATCH v3 29/38] scsi: " Niklas Schnelle
2023-03-14 12:12 ` [PATCH v3 30/38] sound: " Niklas Schnelle
2023-03-14 12:33   ` Takashi Iwai
2023-03-14 12:33     ` Takashi Iwai
2023-05-08 16:41     ` Niklas Schnelle
2023-05-08 16:41       ` Niklas Schnelle
2023-03-14 12:12 ` [PATCH v3 31/38] speakup: add HAS_IOPORT dependency for SPEAKUP_SERIALIO Niklas Schnelle
2023-03-14 12:12 ` [PATCH v3 32/38] staging: add HAS_IOPORT dependencies Niklas Schnelle
2023-03-14 12:12 ` [PATCH v3 33/38] tty: serial: handle " Niklas Schnelle
2023-03-14 12:12 ` [PATCH v3 34/38] usb: " Niklas Schnelle
2023-03-14 14:56   ` Arnd Bergmann
2023-03-14 12:12 ` [PATCH v3 35/38] video: " Niklas Schnelle
2023-03-14 12:12   ` Niklas Schnelle
2023-03-15  8:16   ` Geert Uytterhoeven
2023-03-15  8:16     ` Geert Uytterhoeven
2023-03-15 10:19     ` Ville Syrjälä
2023-03-15 10:19       ` Ville Syrjälä
2023-03-23 14:17       ` Niklas Schnelle
2023-03-23 14:17         ` Niklas Schnelle
2023-03-23 16:08         ` Ville Syrjälä
2023-03-23 16:08           ` Ville Syrjälä
2023-05-08 17:09           ` Niklas Schnelle
2023-05-08 17:09             ` Niklas Schnelle
2023-03-14 12:12 ` [PATCH v3 36/38] watchdog: add " Niklas Schnelle
2023-03-14 14:21   ` Guenter Roeck
2023-03-14 12:12 ` [PATCH v3 37/38] wireless: " Niklas Schnelle
2023-03-15  5:26   ` Kalle Valo
2023-03-14 12:12 ` [PATCH v3 38/38] asm-generic/io.h: drop inb() etc for HAS_IOPORT=n Niklas Schnelle
2023-03-14 14:05 ` [PATCH v3 00/38] Kconfig: Introduce HAS_IOPORT config option Arnd Bergmann
2023-03-14 14:05   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230314121216.413434-15-schnelle@linux.ibm.com \
    --to=schnelle@linux.ibm.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=rafael@kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.