All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jochen Henneberg <jh@henneberg-systemdesign.com>
To: netdev@vger.kernel.org
Cc: Jochen Henneberg <jh@henneberg-systemdesign.com>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Ong Boon Leong <boon.leong.ong@intel.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH net V2 2/2] net: stmmac: Premature loop termination check was ignored on ZC rx
Date: Thu, 16 Mar 2023 08:59:40 +0100	[thread overview]
Message-ID: <20230316075940.695583-3-jh@henneberg-systemdesign.com> (raw)
In-Reply-To: <20230316075940.695583-1-jh@henneberg-systemdesign.com>

The premature loop termination check makes sense only in case of the
jump to read_again where the count may have been updated. But
read_again did not include the check.

Fixes: bba2556efad6 ("net: stmmac: Enable RX via AF_XDP zero-copy")
Signed-off-by: Jochen Henneberg <jh@henneberg-systemdesign.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index ea51c7c93101..4886668a54c5 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -5031,10 +5031,10 @@ static int stmmac_rx_zc(struct stmmac_priv *priv, int limit, u32 queue)
 			len = 0;
 		}
 
+read_again:
 		if (count >= limit)
 			break;
 
-read_again:
 		buf1_len = 0;
 		entry = next_entry;
 		buf = &rx_q->buf_pool[entry];
-- 
2.39.2


WARNING: multiple messages have this Message-ID (diff)
From: Jochen Henneberg <jh@henneberg-systemdesign.com>
To: netdev@vger.kernel.org
Cc: Jochen Henneberg <jh@henneberg-systemdesign.com>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Ong Boon Leong <boon.leong.ong@intel.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH net V2 2/2] net: stmmac: Premature loop termination check was ignored on ZC rx
Date: Thu, 16 Mar 2023 08:59:40 +0100	[thread overview]
Message-ID: <20230316075940.695583-3-jh@henneberg-systemdesign.com> (raw)
In-Reply-To: <20230316075940.695583-1-jh@henneberg-systemdesign.com>

The premature loop termination check makes sense only in case of the
jump to read_again where the count may have been updated. But
read_again did not include the check.

Fixes: bba2556efad6 ("net: stmmac: Enable RX via AF_XDP zero-copy")
Signed-off-by: Jochen Henneberg <jh@henneberg-systemdesign.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index ea51c7c93101..4886668a54c5 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -5031,10 +5031,10 @@ static int stmmac_rx_zc(struct stmmac_priv *priv, int limit, u32 queue)
 			len = 0;
 		}
 
+read_again:
 		if (count >= limit)
 			break;
 
-read_again:
 		buf1_len = 0;
 		entry = next_entry;
 		buf = &rx_q->buf_pool[entry];
-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-03-16  8:01 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 12:37 [PATCH net 0/2] net: stmmac: Premature loop termination check was ignored Jochen Henneberg
2023-03-14 12:37 ` Jochen Henneberg
2023-03-14 12:37 ` [PATCH net 1/2] " Jochen Henneberg
2023-03-14 12:37   ` Jochen Henneberg
2023-03-14 14:44   ` Piotr Raczynski
2023-03-14 14:44     ` Piotr Raczynski
2023-03-14 15:01     ` Jochen Henneberg
2023-03-14 15:01       ` Jochen Henneberg
2023-03-15  8:59       ` Piotr Raczynski
2023-03-15  8:59         ` Piotr Raczynski
2023-03-15  9:13         ` Jochen Henneberg
2023-03-15  9:13           ` Jochen Henneberg
2023-03-14 12:37 ` [PATCH net 2/2] " Jochen Henneberg
2023-03-14 12:37   ` Jochen Henneberg
2023-03-16  7:59 ` [PATCH net V2 0/2] " Jochen Henneberg
2023-03-16  7:59   ` Jochen Henneberg
2023-03-16  7:59   ` [PATCH net V2 1/2] net: stmmac: Premature loop termination check was ignored on rx Jochen Henneberg
2023-03-16  7:59     ` Jochen Henneberg
2023-03-17 12:32     ` Piotr Raczynski
2023-03-17 12:32       ` Piotr Raczynski
2023-03-18  5:21     ` Jakub Kicinski
2023-03-18  5:21       ` Jakub Kicinski
2023-03-18  8:38       ` Jochen Henneberg
2023-03-18  8:38         ` Jochen Henneberg
2023-03-19  2:01         ` Jakub Kicinski
2023-03-19  2:01           ` Jakub Kicinski
2023-03-20  9:04           ` Jochen Henneberg
2023-03-20  9:04             ` Jochen Henneberg
2023-03-20 18:36             ` Jakub Kicinski
2023-03-20 18:36               ` Jakub Kicinski
2023-03-21 18:53               ` Jochen Henneberg
2023-03-21 18:53                 ` Jochen Henneberg
2023-03-16  7:59   ` Jochen Henneberg [this message]
2023-03-16  7:59     ` [PATCH net V2 2/2] net: stmmac: Premature loop termination check was ignored on ZC rx Jochen Henneberg
2023-03-17 12:32     ` Piotr Raczynski
2023-03-17 12:32       ` Piotr Raczynski
2023-03-16 23:20   ` [PATCH net V2 0/2] net: stmmac: Premature loop termination check was ignored Horatiu Vultur
2023-03-16 23:20     ` Horatiu Vultur
2023-03-17 12:31   ` Piotr Raczynski
2023-03-17 12:31     ` Piotr Raczynski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230316075940.695583-3-jh@henneberg-systemdesign.com \
    --to=jh@henneberg-systemdesign.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=boon.leong.ong@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=joabreu@synopsys.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=peppe.cavallaro@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.