From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>, Abhinav Kumar <quic_abhinavk@quicinc.com> Cc: Stephen Boyd <swboyd@chromium.org>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Bjorn Andersson <andersson@kernel.org>, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: [PATCH v7 10/32] drm/msm/dpu: clean up SRC addresses when setting up SSPP for solid fill Date: Thu, 16 Mar 2023 19:16:31 +0300 [thread overview] Message-ID: <20230316161653.4106395-11-dmitry.baryshkov@linaro.org> (raw) In-Reply-To: <20230316161653.4106395-1-dmitry.baryshkov@linaro.org> Set SSPP_SRCn_ADDR registers to 0 while setting up solid fill, as we can not be sure that the previous address is still valid. Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> Tested-by: Abhinav Kumar <quic_abhinavk@quicinc.com> # sc7280 Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c index 3030cd3b253a..0a43c5682b2b 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -563,11 +563,16 @@ static void dpu_hw_sspp_setup_csc(struct dpu_hw_sspp *ctx, static void dpu_hw_sspp_setup_solidfill(struct dpu_sw_pipe *pipe, u32 color) { struct dpu_hw_sspp *ctx = pipe->sspp; + struct dpu_hw_sspp_cfg cfg; u32 idx; if (_sspp_subblk_offset(ctx, DPU_SSPP_SRC, &idx)) return; + /* cleanup source addresses */ + memset(&cfg, 0, sizeof(cfg)); + ctx->ops.setup_sourceaddress(pipe, &cfg); + if (pipe->multirect_index == DPU_SSPP_RECT_SOLO || pipe->multirect_index == DPU_SSPP_RECT_0) DPU_REG_WRITE(&ctx->hw, SSPP_SRC_CONSTANT_COLOR + idx, color); -- 2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>, Abhinav Kumar <quic_abhinavk@quicinc.com> Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Bjorn Andersson <andersson@kernel.org>, dri-devel@lists.freedesktop.org, Stephen Boyd <swboyd@chromium.org> Subject: [PATCH v7 10/32] drm/msm/dpu: clean up SRC addresses when setting up SSPP for solid fill Date: Thu, 16 Mar 2023 19:16:31 +0300 [thread overview] Message-ID: <20230316161653.4106395-11-dmitry.baryshkov@linaro.org> (raw) In-Reply-To: <20230316161653.4106395-1-dmitry.baryshkov@linaro.org> Set SSPP_SRCn_ADDR registers to 0 while setting up solid fill, as we can not be sure that the previous address is still valid. Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> Tested-by: Abhinav Kumar <quic_abhinavk@quicinc.com> # sc7280 Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c index 3030cd3b253a..0a43c5682b2b 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -563,11 +563,16 @@ static void dpu_hw_sspp_setup_csc(struct dpu_hw_sspp *ctx, static void dpu_hw_sspp_setup_solidfill(struct dpu_sw_pipe *pipe, u32 color) { struct dpu_hw_sspp *ctx = pipe->sspp; + struct dpu_hw_sspp_cfg cfg; u32 idx; if (_sspp_subblk_offset(ctx, DPU_SSPP_SRC, &idx)) return; + /* cleanup source addresses */ + memset(&cfg, 0, sizeof(cfg)); + ctx->ops.setup_sourceaddress(pipe, &cfg); + if (pipe->multirect_index == DPU_SSPP_RECT_SOLO || pipe->multirect_index == DPU_SSPP_RECT_0) DPU_REG_WRITE(&ctx->hw, SSPP_SRC_CONSTANT_COLOR + idx, color); -- 2.30.2
next prev parent reply other threads:[~2023-03-16 16:17 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-16 16:16 [PATCH v7 00/32] drm/msm/dpu: wide planes support Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 01/32] drm/msm/dpu: rename struct dpu_hw_pipe(_cfg) to dpu_hw_sspp(_cfg) Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 02/32] drm/msm/dpu: move SSPP allocation to the RM Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 03/32] drm/msm/dpu: move SSPP debugfs creation to dpu_kms.c Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 04/32] drm/msm/dpu: drop EAGAIN check from dpu_format_populate_layout Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 05/32] drm/msm/dpu: move pipe_hw to dpu_plane_state Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 06/32] drm/msm/dpu: drop dpu_plane_pipe function Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 07/32] drm/msm/dpu: introduce struct dpu_sw_pipe Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 08/32] drm/msm/dpu: use dpu_sw_pipe for dpu_hw_sspp callbacks Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 09/32] drm/msm/dpu: pass dpu_format to _dpu_hw_sspp_setup_scaler3() Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov [this message] 2023-03-16 16:16 ` [PATCH v7 10/32] drm/msm/dpu: clean up SRC addresses when setting up SSPP for solid fill Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 11/32] drm/msm/dpu: move stride programming to dpu_hw_sspp_setup_sourceaddress Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 12/32] drm/msm/dpu: remove dpu_hw_fmt_layout from struct dpu_hw_sspp_cfg Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 13/32] drm/msm/dpu: rename dpu_hw_sspp_cfg to dpu_sw_pipe_cfg Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 14/32] drm/msm/dpu: drop src_split and multirect check from dpu_crtc_atomic_check Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 15/32] drm/msm/dpu: don't use unsupported blend stages Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 16/32] drm/msm/dpu: move the rest of plane checks to dpu_plane_atomic_check() Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 17/32] drm/msm/dpu: drop redundant plane dst check from dpu_crtc_atomic_check() Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 18/32] drm/msm/dpu: rewrite plane's QoS-related functions to take dpu_sw_pipe and dpu_format Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 19/32] drm/msm/dpu: make _dpu_plane_calc_clk accept mode directly Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 20/32] drm/msm/dpu: add dpu_hw_sspp_cfg to dpu_plane_state Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 21/32] drm/msm/dpu: simplify dpu_plane_validate_src() Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 22/32] drm/msm/dpu: rework dpu_plane_sspp_atomic_update() Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 23/32] drm/msm/dpu: rework dpu_plane_atomic_check() Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 24/32] drm/msm/dpu: rework plane CSC setting Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 25/32] drm/msm/dpu: rework static color fill code Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 26/32] drm/msm/dpu: split pipe handling from _dpu_crtc_blend_setup_mixer Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 27/32] drm/msm/dpu: add support for wide planes Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-30 2:53 ` Abhinav Kumar 2023-03-30 2:53 ` Abhinav Kumar 2023-03-30 3:30 ` Dmitry Baryshkov 2023-03-30 3:30 ` Dmitry Baryshkov 2023-03-30 4:51 ` Abhinav Kumar 2023-03-30 4:51 ` Abhinav Kumar 2023-03-16 16:16 ` [PATCH v7 28/32] drm/msm/dpu: populate SmartDMA features in hw catalog Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 29/32] drm/msm/dpu: enable SmartDMA for the rest of the platforms Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 30/32] drm/msm/dpu: drop smart_dma_rev from dpu_caps Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 31/32] drm/msm/dpu: log the multirect_index in _dpu_crtc_blend_setup_pipe Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-28 13:32 ` Dmitry Baryshkov 2023-03-28 13:32 ` Dmitry Baryshkov 2023-03-16 16:16 ` [PATCH v7 32/32] drm/msm/dpu: remove unused dpu_plane_validate_multirect_v2 function Dmitry Baryshkov 2023-03-16 16:16 ` Dmitry Baryshkov 2023-03-28 13:32 ` Dmitry Baryshkov 2023-03-28 13:32 ` Dmitry Baryshkov 2023-03-28 22:37 ` [PATCH v7 00/32] drm/msm/dpu: wide planes support Dmitry Baryshkov 2023-03-28 22:37 ` Dmitry Baryshkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230316161653.4106395-11-dmitry.baryshkov@linaro.org \ --to=dmitry.baryshkov@linaro.org \ --cc=airlied@gmail.com \ --cc=andersson@kernel.org \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ --cc=swboyd@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.