From: Abel Vesa <abel.vesa@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>, Pavel Machek <pavel@ucw.cz>,
Len Brown <len.brown@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Saravana Kannan <saravanak@google.com>
Cc: linux-pm@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
Doug Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>
Subject: [RFC PATCH v2 0/5] Allow genpd providers to power off domains on sync state
Date: Mon, 20 Mar 2023 15:42:12 +0200 [thread overview]
Message-ID: <20230320134217.1685781-1-abel.vesa@linaro.org> (raw)
There have been already a couple of tries to make the genpd "disable
unused" late initcall skip the powering off of domains that might be
needed until later on (i.e. until some consumer probes). The conclusion
was that the provider could return -EBUSY from the power_off callback
until the provider's sync state has been reached. This patch series tries
to provide a proof-of-concept that is working on Qualcomm platforms.
I've been doing extensive testing on SM8450, but I've also spinned this
on my X13s (SC8280XP). Both patches that add the sync state callback to
the SC8280XP and SM8450 are here to provide context. Once we agree on
the form, I intend to add the sync state callback to all gdsc providers.
Currently, some of the gdsc providers might not reach sync state due to
list of consumers not probing yet (or at all). The sync state can be
enforced by writing 1 to the state_synced sysfs attribute of the
provider, thanks to Saravana's commit [1] which has been already merged.
[1] https://lore.kernel.org/r/20230304005355.746421-3-saravanak@google.com
V1 of this patchset was here:
https://lore.kernel.org/all/20230315132330.450877-1-abel.vesa@linaro.org/
Changes since v1:
* Added the qcom_cc sync state callback which calls in turn the gdsc one
* dropped extra semicolon from pm_domain.h
Abel Vesa (5):
PM: domains: Allow power off queuing from providers
soc: qcom: rpmhpd: Do proper power off when state synced
clk: qcom: gdsc: Avoid actual power off until sync state
clk: qcom: Add sync state callback to all SC8280XP providers
clk: qcom: Add sync state callback to all SM8450 providers
drivers/base/power/domain.c | 3 ++-
drivers/clk/qcom/camcc-sm8450.c | 1 +
drivers/clk/qcom/common.c | 19 +++++++++++++++++++
drivers/clk/qcom/common.h | 2 ++
drivers/clk/qcom/dispcc-sc8280xp.c | 1 +
drivers/clk/qcom/dispcc-sm8450.c | 1 +
drivers/clk/qcom/gcc-sc8280xp.c | 1 +
drivers/clk/qcom/gcc-sm8450.c | 1 +
drivers/clk/qcom/gdsc.c | 26 ++++++++++++++++++++++++++
drivers/clk/qcom/gdsc.h | 6 ++++++
drivers/clk/qcom/gpucc-sc8280xp.c | 1 +
drivers/soc/qcom/rpmhpd.c | 19 +++++++------------
include/linux/pm_domain.h | 6 ++++++
13 files changed, 74 insertions(+), 13 deletions(-)
--
2.34.1
next reply other threads:[~2023-03-20 13:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 13:42 Abel Vesa [this message]
2023-03-20 13:42 ` [RFC PATCH v2 1/5] PM: domains: Allow power off queuing from providers Abel Vesa
2023-03-20 17:09 ` kernel test robot
2023-03-20 19:22 ` kernel test robot
2023-03-20 22:28 ` kernel test robot
2023-03-21 13:01 ` Ulf Hansson
2023-03-20 13:42 ` [RFC PATCH v2 2/5] soc: qcom: rpmhpd: Do proper power off when state synced Abel Vesa
2023-03-20 13:42 ` [RFC PATCH v2 3/5] clk: qcom: gdsc: Avoid actual power off until sync state Abel Vesa
2023-03-20 13:42 ` [RFC PATCH v2 4/5] clk: qcom: Add sync state callback to all SC8280XP providers Abel Vesa
2023-03-20 13:42 ` [RFC PATCH v2 5/5] clk: qcom: Add sync state callback to all SM8450 providers Abel Vesa
2023-03-21 13:07 ` [RFC PATCH v2 0/5] Allow genpd providers to power off domains on sync state Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320134217.1685781-1-abel.vesa@linaro.org \
--to=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=len.brown@intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=mturquette@baylibre.com \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.