From: Biju Das <biju.das.jz@bp.renesas.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
Jiri Slaby <jirislaby@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-serial@vger.kernel.org,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: [PATCH v4 0/5] Renesas SCI fixes
Date: Tue, 21 Mar 2023 11:47:48 +0000 [thread overview]
Message-ID: <20230321114753.75038-1-biju.das.jz@bp.renesas.com> (raw)
RZ/G2UL SMARC EVK has sci pins exposed through PMOD1 interface.
On testing, found that irq handler, tx and rx is broken.
This series fixes these issues.
v3->v4:
* Updated the fixes tag for patch#2 and patch#3
* Replaced sci_port->is_rz_sci with dev->dev.of_node as regshift are only needed
for sh770x/sh7750/sh7760, which don't use DT yet.
* Dropped is_rz_sci variable from struct sci_port.
* Removed fixes tag from patch#4, as it is a feature enhancement to make tx
fully functional on RZ/G2L alike SOCs. With previous patch#3, eventhough
we get tx interrupts, still it is broken as characters entered on
uart terminal is not visible except for the first character.
* Updated commit header sci0 nodes->sci0 node for patch#5
* Removed PMOD USBUART reference and connection details as user can connect
anything on that PMOD1 pins.
* Renamed r9a07g043-smarc.dtso->r9a07g043-smarc-pmod.dtso
* Dropped unused header file dt-bindings/gpio/gpio.h
v2->v3:
* Cced stable@vger.kernel.org
* Added Rx, Tx and Tx end interrupt handler patch.
v1->v2:
* Replaced the wrong fixes tag
* Added a simpler check in sci_init_single() and added a check in
probe to catch invalid interrupt count.
Tested the SCI0 interface on RZ/G2UL by connecting to PMOD USBUART.
39: 0 GICv3 437 Level 1004d000.serial:rx err
40: 12 GICv3 438 Edge 1004d000.serial:rx full
41: 70 GICv3 439 Edge 1004d000.serial:tx empty
42: 18 GICv3 440 Level 1004d000.serial:tx end
Biju Das (5):
tty: serial: sh-sci: Fix transmit end interrupt handler
tty: serial: sh-sci: Fix Rx on RZ/G2L SCI
tty: serial: sh-sci: Fix Tx on SCI IP
tty: serial: sh-sci: Add support for tx end interrupt handling
arm64: dts: renesas: r9a07g044: Enable sci0 node using dt overlay
arch/arm64/boot/dts/renesas/Makefile | 1 +
.../dts/renesas/r9a07g043-smarc-pmod.dtso | 42 ++++++++++++
drivers/tty/serial/sh-sci.c | 66 +++++++++++++++++--
drivers/tty/serial/sh-sci.h | 3 +
4 files changed, 106 insertions(+), 6 deletions(-)
create mode 100644 arch/arm64/boot/dts/renesas/r9a07g043-smarc-pmod.dtso
--
2.25.1
next reply other threads:[~2023-03-21 11:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 11:47 Biju Das [this message]
2023-03-21 11:47 ` [PATCH v4 1/5] tty: serial: sh-sci: Fix transmit end interrupt handler Biju Das
2023-03-27 9:12 ` Geert Uytterhoeven
2023-03-21 11:47 ` [PATCH v4 2/5] tty: serial: sh-sci: Fix Rx on RZ/G2L SCI Biju Das
2023-03-27 9:15 ` Geert Uytterhoeven
2023-03-28 11:32 ` Biju Das
2023-03-29 9:01 ` Greg Kroah-Hartman
2023-03-29 9:06 ` Biju Das
2023-03-29 9:20 ` Greg Kroah-Hartman
2023-03-29 9:31 ` Biju Das
2023-03-21 11:47 ` [PATCH v4 3/5] tty: serial: sh-sci: Fix Tx on SCI IP Biju Das
2023-04-06 6:50 ` Biju Das
2023-03-21 11:47 ` [PATCH v4 4/5] tty: serial: sh-sci: Add support for tx end interrupt handling Biju Das
2023-03-21 11:47 ` [PATCH v4 5/5] arm64: dts: renesas: r9a07g044: Enable sci0 node using dt overlay Biju Das
2023-03-30 10:03 ` Geert Uytterhoeven
2023-03-30 10:06 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230321114753.75038-1-biju.das.jz@bp.renesas.com \
--to=biju.das.jz@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.