All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v2 2/8] media: videobuf2: Make bufs array dynamic allocated
Date: Fri, 24 Mar 2023 01:52:32 +0800	[thread overview]
Message-ID: <202303240148.lKRnUqW9-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20230321102855.346732-3-benjamin.gaignard@collabora.com>
References: <20230321102855.346732-3-benjamin.gaignard@collabora.com>
TO: Benjamin Gaignard <benjamin.gaignard@collabora.com>
TO: tfiga@chromium.org
TO: m.szyprowski@samsung.com
TO: mchehab@kernel.org
TO: ming.qian@nxp.com
TO: shijie.qin@nxp.com
TO: eagle.zhou@nxp.com
TO: bin.liu@mediatek.com
TO: matthias.bgg@gmail.com
TO: angelogioacchino.delregno@collabora.com
TO: tiffany.lin@mediatek.com
TO: andrew-ct.chen@mediatek.com
TO: yunfei.dong@mediatek.com
TO: stanimir.k.varbanov@gmail.com
TO: quic_vgarodia@quicinc.com
TO: agross@kernel.org
TO: andersson@kernel.org
TO: konrad.dybcio@linaro.org
TO: ezequiel@vanguardiasur.com.ar
TO: p.zabel@pengutronix.de
TO: daniel.almeida@collabora.com
TO: hverkuil-cisco@xs4all.nl
TO: laurent.pinchart@ideasonboard.com
TO: jernel@kernel.org
CC: linux-media@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: linux-arm-kernel@lists.infradead.org
CC: linux-mediatek@lists.infradead.org
CC: linux-arm-msm@vger.kernel.org
CC: linux-rockchip@lists.infradead.org
CC: kernel@collabora.com

Hi Benjamin,

I love your patch! Perhaps something to improve:

[auto build test WARNING on media-tree/master]
[also build test WARNING on linus/master v6.3-rc3 next-20230323]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Benjamin-Gaignard/media-videobuf2-Access-vb2_queue-bufs-array-through-helper-functions/20230321-183154
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/20230321102855.346732-3-benjamin.gaignard%40collabora.com
patch subject: [PATCH v2 2/8] media: videobuf2: Make bufs array dynamic allocated
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: arm64-randconfig-m041-20230319 (https://download.01.org/0day-ci/archive/20230324/202303240148.lKRnUqW9-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202303240148.lKRnUqW9-lkp@intel.com/

smatch warnings:
include/media/videobuf2-core.h:1272 vb2_queue_add_buffer() warn: sleeping in atomic context
drivers/media/common/videobuf2/videobuf2-core.c:2456 vb2_core_queue_init() warn: Please consider using kcalloc instead of kmalloc_array

vim +1272 include/media/videobuf2-core.h

3dd8c097541794 Ezequiel Garcia   2019-06-10  1257  
625d46c1c1fe8e Benjamin Gaignard 2023-03-21  1258  /**
625d46c1c1fe8e Benjamin Gaignard 2023-03-21  1259   * vb2_queue_add_buffer() - add a buffer to a queue
625d46c1c1fe8e Benjamin Gaignard 2023-03-21  1260   * @q:	pointer to &struct vb2_queue with videobuf2 queue.
625d46c1c1fe8e Benjamin Gaignard 2023-03-21  1261   * @vb:	pointer to &struct vb2_buffer to be added to the queue.
625d46c1c1fe8e Benjamin Gaignard 2023-03-21  1262   */
625d46c1c1fe8e Benjamin Gaignard 2023-03-21  1263  static inline bool vb2_queue_add_buffer(struct vb2_queue *q, struct vb2_buffer *vb)
625d46c1c1fe8e Benjamin Gaignard 2023-03-21  1264  {
487d3f14d12ecf Benjamin Gaignard 2023-03-21  1265  	bool ret = false;
487d3f14d12ecf Benjamin Gaignard 2023-03-21  1266  
487d3f14d12ecf Benjamin Gaignard 2023-03-21  1267  	spin_lock(&q->bufs_lock);
487d3f14d12ecf Benjamin Gaignard 2023-03-21  1268  
487d3f14d12ecf Benjamin Gaignard 2023-03-21  1269  	if (vb->index >= q->max_num_bufs) {
487d3f14d12ecf Benjamin Gaignard 2023-03-21  1270  		struct vb2_buffer **tmp;
487d3f14d12ecf Benjamin Gaignard 2023-03-21  1271  
487d3f14d12ecf Benjamin Gaignard 2023-03-21 @1272  		tmp = krealloc_array(q->bufs, q->max_num_bufs * 2, sizeof(*q->bufs), GFP_KERNEL);
487d3f14d12ecf Benjamin Gaignard 2023-03-21  1273  		if (!tmp)
487d3f14d12ecf Benjamin Gaignard 2023-03-21  1274  			goto realloc_failed;
487d3f14d12ecf Benjamin Gaignard 2023-03-21  1275  
487d3f14d12ecf Benjamin Gaignard 2023-03-21  1276  		q->max_num_bufs *= 2;
487d3f14d12ecf Benjamin Gaignard 2023-03-21  1277  		q->bufs = tmp;
487d3f14d12ecf Benjamin Gaignard 2023-03-21  1278  	}
487d3f14d12ecf Benjamin Gaignard 2023-03-21  1279  
487d3f14d12ecf Benjamin Gaignard 2023-03-21  1280  	if (vb->index < q->max_num_bufs) {
625d46c1c1fe8e Benjamin Gaignard 2023-03-21  1281  		q->bufs[vb->index] = vb;
487d3f14d12ecf Benjamin Gaignard 2023-03-21  1282  		ret = true;
625d46c1c1fe8e Benjamin Gaignard 2023-03-21  1283  	}
625d46c1c1fe8e Benjamin Gaignard 2023-03-21  1284  
487d3f14d12ecf Benjamin Gaignard 2023-03-21  1285  realloc_failed:
487d3f14d12ecf Benjamin Gaignard 2023-03-21  1286  	spin_unlock(&q->bufs_lock);
487d3f14d12ecf Benjamin Gaignard 2023-03-21  1287  
487d3f14d12ecf Benjamin Gaignard 2023-03-21  1288  	return ret;
625d46c1c1fe8e Benjamin Gaignard 2023-03-21  1289  }
625d46c1c1fe8e Benjamin Gaignard 2023-03-21  1290  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

             reply	other threads:[~2023-03-23 17:52 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23 17:52 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-03-21 10:28 [PATCH v2 0/8] Add DELETE_BUF ioctl Benjamin Gaignard
2023-03-21 10:28 ` [PATCH v2 2/8] media: videobuf2: Make bufs array dynamic allocated Benjamin Gaignard
2023-03-21 10:28   ` Benjamin Gaignard
2023-03-21 10:28   ` Benjamin Gaignard
2023-03-21 18:16   ` Laurent Pinchart
2023-03-21 18:16     ` Laurent Pinchart
2023-03-21 18:16     ` Laurent Pinchart
2023-03-22  8:10     ` Benjamin Gaignard
2023-05-19 10:04     ` Tomasz Figa
2023-05-19 10:04       ` Tomasz Figa
2023-05-19 10:04       ` Tomasz Figa
2023-05-22 12:27       ` Benjamin Gaignard
2023-03-24  5:01   ` Dan Carpenter
2023-03-24  5:01     ` Dan Carpenter
2023-03-24  5:01     ` Dan Carpenter
2023-03-24  8:11     ` Benjamin Gaignard
2023-03-24  8:11       ` Benjamin Gaignard
2023-03-24  8:11       ` Benjamin Gaignard
2023-03-24  8:31       ` Hans Verkuil
2023-03-24  8:31         ` Hans Verkuil
2023-03-24  8:31         ` Hans Verkuil
2023-03-24  8:48         ` Laurent Pinchart
2023-03-24  8:48           ` Laurent Pinchart
2023-03-24  8:48           ` Laurent Pinchart
2023-03-24  8:52           ` Hans Verkuil
2023-03-24  8:52             ` Hans Verkuil
2023-03-24  8:52             ` Hans Verkuil
2023-03-24  8:56             ` Benjamin Gaignard
2023-03-24  8:56               ` Benjamin Gaignard
2023-03-24  8:56               ` Benjamin Gaignard
2023-05-19 10:00               ` Tomasz Figa
2023-05-19 10:00                 ` Tomasz Figa
2023-05-19 10:00                 ` Tomasz Figa
2023-03-24 13:02   ` Dmitry Osipenko
2023-03-24 13:02     ` Dmitry Osipenko
2023-03-24 13:02     ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202303240148.lKRnUqW9-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=error27@gmail.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.