From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
To: linux-media@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Hans Verkuil <hverkuil-cisco@xs4all.nl>
Subject: [PATCH v2 0/2] media: i2c: adv7604: Fix handling of video adjustments
Date: Sat, 25 Mar 2023 22:56:08 +0200 [thread overview]
Message-ID: <20230325205610.22583-1-laurent.pinchart+renesas@ideasonboard.com> (raw)
Hello,
This small series fixes two issues with video adjustments (brightness,
contrast, saturation and hue) in the adv7604 driver. Patch 1/2 makes
those controls effective (they currently have no effect), and patch 2/2
fixes the range of the hue control.
I have successfully tested the series with an ADV7612, and Hans with the
ADV7604. The ADV7604 and ADV7611 documentation of the hue control
differs from the ADV7612, but I believe that's because earlier
documentation was incorrect.
In patch 2/2 I've decided to represent the hue value as an unsigned
8-bit integer, mapping to the [0°, 360°[ range. Using a signed value
would map to the [-180°, 180°[ range instead, without making any other
difference (and without requiring any modification to the patch other
than changing the range). I don't have a strong preference between the
two options, and I'm pretty sure we can freely pick one without any fear
of an impact on existing userspace applications as patch 1/2 shows that
the hue control has currently no effect.
Compared to v1, this version fixes a typo in the commit message of patch
2/2.
Laurent Pinchart (2):
media: i2c: adv7604: Enable video adjustment
media: i2c: adv7604: Fix range of hue control
drivers/media/i2c/adv7604.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--
Regards,
Laurent Pinchart
next reply other threads:[~2023-03-25 20:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 20:56 Laurent Pinchart [this message]
2023-03-25 20:56 ` [PATCH v2 1/2] media: i2c: adv7604: Enable video adjustment Laurent Pinchart
2023-03-25 20:56 ` [PATCH v2 2/2] media: i2c: adv7604: Fix range of hue control Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230325205610.22583-1-laurent.pinchart+renesas@ideasonboard.com \
--to=laurent.pinchart+renesas@ideasonboard.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.