All of lore.kernel.org
 help / color / mirror / Atom feed
From: Caio Novais <caionovais@usp.br>
To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: "Felipe Clark" <felipe.clark@amd.com>,
	"Wenjing Liu" <wenjing.liu@amd.com>,
	"Maíra Canal" <mairacanal@riseup.net>,
	"Mario Limonciello" <mario.limonciello@amd.com>,
	"Jun Lei" <Jun.Lei@amd.com>,
	"Charlene Liu" <Charlene.Liu@amd.com>,
	"Gabe Teeger" <gabe.teeger@amd.com>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	"Taimur Hassan" <Syed.Hassan@amd.com>,
	"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
	"Alvin Lee" <alvin.lee2@amd.com>,
	"George Shen" <George.Shen@amd.com>,
	"Hamza Mahfooz" <hamza.mahfooz@amd.com>,
	"Chaitanya Dhere" <chaitanya.dhere@amd.com>,
	"Alan Liu" <HaoPing.Liu@amd.com>,
	"Mukul Joshi" <mukul.joshi@amd.com>,
	"André Almeida" <andrealmeid@igalia.com>,
	"Jingwen Zhu" <Jingwen.Zhu@amd.com>,
	"Guo Zhengkui" <guozhengkui@vivo.com>,
	"Leo Li" <sunpeng.li@amd.com>, "Melissa Wen" <mwen@igalia.com>,
	"Le Ma" <le.ma@amd.com>,
	"Jiapeng Chong" <jiapeng.chong@linux.alibaba.com>,
	"Caio Novais" <caionovais@usp.br>,
	"Martin Leung" <Martin.Leung@amd.com>,
	"Ryan Lin" <tsung-hua.lin@amd.com>,
	"Brian Chang" <Brian.Chang@amd.com>,
	"Sung Joon Kim" <sungjoon.kim@amd.com>,
	"Yifan Zhang" <yifan1.zhang@amd.com>,
	"Jack Xiao" <Jack.Xiao@amd.com>,
	"Dillon Varone" <Dillon.Varone@amd.com>,
	"Tom Chung" <chiahsuan.chung@amd.com>,
	"Wesley Chalmers" <Wesley.Chalmers@amd.com>,
	"Qingqing Zhuo" <qingqing.zhuo@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>, "Zhan Liu" <zhan.liu@amd.com>,
	"Roman Li" <Roman.Li@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Wayne Lin" <wayne.lin@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Ethan Wellenreiter" <Ethan.Wellenreiter@amd.com>,
	"Nicholas Kazlauskas" <Nicholas.Kazlauskas@amd.com>,
	"Joshua Ashton" <joshua@froggi.es>,
	"Hawking Zhang" <Hawking.Zhang@amd.com>
Subject: [PATCH 11/12] drm/amd/display: Remove unused variable 'scl_enable'
Date: Mon, 27 Mar 2023 20:33:52 -0300	[thread overview]
Message-ID: <20230327233353.64081-12-caionovais@usp.br> (raw)
In-Reply-To: <20230327233353.64081-1-caionovais@usp.br>

Compiling AMD GPU drivers displays a warning:

drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_rq_dlg_calc_31.c: In function ‘dml_rq_dlg_get_dlg_params’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_rq_dlg_calc_31.c:905:14: warning: variable ‘scl_enable’ set but not used [-Wunused-but-set-variable]

Get rid of it by removing the variable.

Signed-off-by: Caio Novais <caionovais@usp.br>
---
 .../gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c   | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c
index 35d10b4d018b..2244e4fb8c96 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c
@@ -902,7 +902,6 @@ static void dml_rq_dlg_get_dlg_params(
 	double hratio_c;
 	double vratio_l;
 	double vratio_c;
-	bool scl_enable;
 
 	unsigned int swath_width_ub_l;
 	unsigned int dpte_groups_per_row_ub_l;
@@ -1020,7 +1019,6 @@ static void dml_rq_dlg_get_dlg_params(
 	hratio_c = scl->hscl_ratio_c;
 	vratio_l = scl->vscl_ratio;
 	vratio_c = scl->vscl_ratio_c;
-	scl_enable = scl->scl_enable;
 
 	swath_width_ub_l = rq_dlg_param->rq_l.swath_width_ub;
 	dpte_groups_per_row_ub_l = rq_dlg_param->rq_l.dpte_groups_per_row_ub;
-- 
2.40.0


WARNING: multiple messages have this Message-ID (diff)
From: Caio Novais <caionovais@usp.br>
To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: "Felipe Clark" <felipe.clark@amd.com>,
	"Wenjing Liu" <wenjing.liu@amd.com>,
	"Maíra Canal" <mairacanal@riseup.net>,
	"Mario Limonciello" <mario.limonciello@amd.com>,
	"Jun Lei" <Jun.Lei@amd.com>, "David Airlie" <airlied@gmail.com>,
	"Charlene Liu" <Charlene.Liu@amd.com>,
	"Gabe Teeger" <gabe.teeger@amd.com>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	"Taimur Hassan" <Syed.Hassan@amd.com>,
	"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
	"Alvin Lee" <alvin.lee2@amd.com>,
	"George Shen" <George.Shen@amd.com>,
	"Hamza Mahfooz" <hamza.mahfooz@amd.com>,
	"Chaitanya Dhere" <chaitanya.dhere@amd.com>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Alan Liu" <HaoPing.Liu@amd.com>,
	"Mukul Joshi" <mukul.joshi@amd.com>,
	"André Almeida" <andrealmeid@igalia.com>,
	"Jingwen Zhu" <Jingwen.Zhu@amd.com>,
	"Guo Zhengkui" <guozhengkui@vivo.com>,
	"Leo Li" <sunpeng.li@amd.com>, "Melissa Wen" <mwen@igalia.com>,
	"Le Ma" <le.ma@amd.com>,
	"Jiapeng Chong" <jiapeng.chong@linux.alibaba.com>,
	"Caio Novais" <caionovais@usp.br>,
	"Martin Leung" <Martin.Leung@amd.com>,
	"Ryan Lin" <tsung-hua.lin@amd.com>,
	"Brian Chang" <Brian.Chang@amd.com>,
	"Sung Joon Kim" <sungjoon.kim@amd.com>,
	"Yifan Zhang" <yifan1.zhang@amd.com>,
	"Jack Xiao" <Jack.Xiao@amd.com>,
	"Dillon Varone" <Dillon.Varone@amd.com>,
	"Tom Chung" <chiahsuan.chung@amd.com>,
	"Wesley Chalmers" <Wesley.Chalmers@amd.com>,
	"Qingqing Zhuo" <qingqing.zhuo@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>, "Zhan Liu" <zhan.liu@amd.com>,
	"Roman Li" <Roman.Li@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Wayne Lin" <wayne.lin@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Ethan Wellenreiter" <Ethan.Wellenreiter@amd.com>,
	"Nicholas Kazlauskas" <Nicholas.Kazlauskas@amd.com>,
	"Joshua Ashton" <joshua@froggi.es>,
	"Hawking Zhang" <Hawking.Zhang@amd.com>
Subject: [PATCH 11/12] drm/amd/display: Remove unused variable 'scl_enable'
Date: Mon, 27 Mar 2023 20:33:52 -0300	[thread overview]
Message-ID: <20230327233353.64081-12-caionovais@usp.br> (raw)
In-Reply-To: <20230327233353.64081-1-caionovais@usp.br>

Compiling AMD GPU drivers displays a warning:

drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_rq_dlg_calc_31.c: In function ‘dml_rq_dlg_get_dlg_params’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_rq_dlg_calc_31.c:905:14: warning: variable ‘scl_enable’ set but not used [-Wunused-but-set-variable]

Get rid of it by removing the variable.

Signed-off-by: Caio Novais <caionovais@usp.br>
---
 .../gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c   | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c
index 35d10b4d018b..2244e4fb8c96 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c
@@ -902,7 +902,6 @@ static void dml_rq_dlg_get_dlg_params(
 	double hratio_c;
 	double vratio_l;
 	double vratio_c;
-	bool scl_enable;
 
 	unsigned int swath_width_ub_l;
 	unsigned int dpte_groups_per_row_ub_l;
@@ -1020,7 +1019,6 @@ static void dml_rq_dlg_get_dlg_params(
 	hratio_c = scl->hscl_ratio_c;
 	vratio_l = scl->vscl_ratio;
 	vratio_c = scl->vscl_ratio_c;
-	scl_enable = scl->scl_enable;
 
 	swath_width_ub_l = rq_dlg_param->rq_l.swath_width_ub;
 	dpte_groups_per_row_ub_l = rq_dlg_param->rq_l.dpte_groups_per_row_ub;
-- 
2.40.0


WARNING: multiple messages have this Message-ID (diff)
From: Caio Novais <caionovais@usp.br>
To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	"Jack Xiao" <Jack.Xiao@amd.com>,
	"Hawking Zhang" <Hawking.Zhang@amd.com>, "Le Ma" <le.ma@amd.com>,
	"Mario Limonciello" <mario.limonciello@amd.com>,
	"Yifan Zhang" <yifan1.zhang@amd.com>,
	"Mukul Joshi" <mukul.joshi@amd.com>, "Jun Lei" <Jun.Lei@amd.com>,
	"Wenjing Liu" <wenjing.liu@amd.com>,
	"Alan Liu" <HaoPing.Liu@amd.com>,
	"Caio Novais" <caionovais@usp.br>,
	"Joshua Ashton" <joshua@froggi.es>,
	"Guo Zhengkui" <guozhengkui@vivo.com>,
	"Nicholas Kazlauskas" <Nicholas.Kazlauskas@amd.com>,
	"Zhan Liu" <zhan.liu@amd.com>, "Wayne Lin" <wayne.lin@amd.com>,
	"Charlene Liu" <Charlene.Liu@amd.com>,
	"Martin Leung" <Martin.Leung@amd.com>,
	"Tom Chung" <chiahsuan.chung@amd.com>,
	"Alvin Lee" <alvin.lee2@amd.com>,
	"George Shen" <George.Shen@amd.com>,
	"Qingqing Zhuo" <qingqing.zhuo@amd.com>,
	"Roman Li" <Roman.Li@amd.com>,
	"Wesley Chalmers" <Wesley.Chalmers@amd.com>,
	"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
	"Jingwen Zhu" <Jingwen.Zhu@amd.com>,
	"Melissa Wen" <mwen@igalia.com>,
	"Felipe Clark" <felipe.clark@amd.com>,
	"Sung Joon Kim" <sungjoon.kim@amd.com>,
	"Dillon Varone" <Dillon.Varone@amd.com>,
	"Ethan Wellenreiter" <Ethan.Wellenreiter@amd.com>,
	"Taimur Hassan" <Syed.Hassan@amd.com>,
	"Maíra Canal" <mairacanal@riseup.net>,
	"Brian Chang" <Brian.Chang@amd.com>,
	"Gabe Teeger" <gabe.teeger@amd.com>,
	"André Almeida" <andrealmeid@igalia.com>,
	"Chaitanya Dhere" <chaitanya.dhere@amd.com>,
	"Jiapeng Chong" <jiapeng.chong@linux.alibaba.com>,
	"Ryan Lin" <tsung-hua.lin@amd.com>,
	"Hamza Mahfooz" <hamza.mahfooz@amd.com>
Subject: [PATCH 11/12] drm/amd/display: Remove unused variable 'scl_enable'
Date: Mon, 27 Mar 2023 20:33:52 -0300	[thread overview]
Message-ID: <20230327233353.64081-12-caionovais@usp.br> (raw)
In-Reply-To: <20230327233353.64081-1-caionovais@usp.br>

Compiling AMD GPU drivers displays a warning:

drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_rq_dlg_calc_31.c: In function ‘dml_rq_dlg_get_dlg_params’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_rq_dlg_calc_31.c:905:14: warning: variable ‘scl_enable’ set but not used [-Wunused-but-set-variable]

Get rid of it by removing the variable.

Signed-off-by: Caio Novais <caionovais@usp.br>
---
 .../gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c   | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c
index 35d10b4d018b..2244e4fb8c96 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c
@@ -902,7 +902,6 @@ static void dml_rq_dlg_get_dlg_params(
 	double hratio_c;
 	double vratio_l;
 	double vratio_c;
-	bool scl_enable;
 
 	unsigned int swath_width_ub_l;
 	unsigned int dpte_groups_per_row_ub_l;
@@ -1020,7 +1019,6 @@ static void dml_rq_dlg_get_dlg_params(
 	hratio_c = scl->hscl_ratio_c;
 	vratio_l = scl->vscl_ratio;
 	vratio_c = scl->vscl_ratio_c;
-	scl_enable = scl->scl_enable;
 
 	swath_width_ub_l = rq_dlg_param->rq_l.swath_width_ub;
 	dpte_groups_per_row_ub_l = rq_dlg_param->rq_l.dpte_groups_per_row_ub;
-- 
2.40.0


  parent reply	other threads:[~2023-03-27 23:36 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-27 23:33 [PATCH 00/12] drm/amd: Remove unused variables Caio Novais
2023-03-27 23:33 ` Caio Novais
2023-03-27 23:33 ` Caio Novais
2023-03-27 23:33 ` [PATCH 01/12] drm/amd: Remove unused variable 'r' Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:46   ` Alex Deucher
2023-03-27 23:46     ` Alex Deucher
2023-03-27 23:33 ` [PATCH 02/12] drm/amd: Remove unused variable 'value0' Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:48   ` Alex Deucher
2023-03-27 23:48     ` Alex Deucher
2023-03-27 23:33 ` [PATCH 03/12] drm/amd/display: Remove unused variable 'pixel_width' Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:33 ` [PATCH 04/12] drm/amd/display: Remove unused variable 'hubp' Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:33 ` [PATCH 05/12] drm/amd/display: Remove unused variable 'speakers' Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:33 ` [PATCH 06/12] drm/amd/display: Remove unused variable 'mc_vm_apt_default' Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:33 ` [PATCH 07/12] drm/amd/display: Remove unused variable 'optc' Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:33 ` [PATCH 08/12] drm/amd/display: Remove two unused variables 'speakers' and 'channels' and remove unused function 'speakers_to_channels' Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:33 ` [PATCH 09/12] drm/amd/display: Remove two unused variables 'is_pipe_split_expected' and 'state' Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:50   ` Alex Deucher
2023-03-27 23:50     ` Alex Deucher
2023-03-27 23:33 ` [PATCH 10/12] drm/amd/display: Remove unused variable 'cursor_bpp' Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:33 ` Caio Novais [this message]
2023-03-27 23:33   ` [PATCH 11/12] drm/amd/display: Remove unused variable 'scl_enable' Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:33 ` [PATCH 12/12] drm/amd/display: Remove two unused variables 'result_write_min_hblank' and 'hblank_size' Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:33   ` Caio Novais
2023-03-27 23:53   ` Alex Deucher
2023-03-27 23:53     ` Alex Deucher
2023-03-27 23:53     ` Alex Deucher
2023-03-28 10:16 ` [PATCH 00/12] drm/amd: Remove unused variables Jani Nikula
2023-03-28 10:16   ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230327233353.64081-12-caionovais@usp.br \
    --to=caionovais@usp.br \
    --cc=Brian.Chang@amd.com \
    --cc=Charlene.Liu@amd.com \
    --cc=Dillon.Varone@amd.com \
    --cc=Ethan.Wellenreiter@amd.com \
    --cc=George.Shen@amd.com \
    --cc=HaoPing.Liu@amd.com \
    --cc=Hawking.Zhang@amd.com \
    --cc=Jack.Xiao@amd.com \
    --cc=Jingwen.Zhu@amd.com \
    --cc=Jun.Lei@amd.com \
    --cc=Martin.Leung@amd.com \
    --cc=Nicholas.Kazlauskas@amd.com \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=Roman.Li@amd.com \
    --cc=Syed.Hassan@amd.com \
    --cc=Wesley.Chalmers@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=alvin.lee2@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=andrealmeid@igalia.com \
    --cc=aurabindo.pillai@amd.com \
    --cc=chaitanya.dhere@amd.com \
    --cc=chiahsuan.chung@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=felipe.clark@amd.com \
    --cc=gabe.teeger@amd.com \
    --cc=guozhengkui@vivo.com \
    --cc=hamza.mahfooz@amd.com \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=joshua@froggi.es \
    --cc=le.ma@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mairacanal@riseup.net \
    --cc=mario.limonciello@amd.com \
    --cc=mukul.joshi@amd.com \
    --cc=mwen@igalia.com \
    --cc=qingqing.zhuo@amd.com \
    --cc=sungjoon.kim@amd.com \
    --cc=sunpeng.li@amd.com \
    --cc=tsung-hua.lin@amd.com \
    --cc=wayne.lin@amd.com \
    --cc=wenjing.liu@amd.com \
    --cc=yifan1.zhang@amd.com \
    --cc=zhan.liu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.