All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michael.christie@oracle.com>
To: bvanassche@acm.org, hch@lst.de, martin.petersen@oracle.com,
	linux-scsi@vger.kernel.org,
	james.bottomley@hansenpartnership.com,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	snitzer@kernel.org, axboe@kernel.dk,
	linux-nvme@lists.infradead.org, chaitanyak@nvidia.com,
	kbusch@kernel.org, target-devel@vger.kernel.org
Cc: Mike Christie <michael.christie@oracle.com>
Subject: [PATCH v6 15/18] scsi: target: Allow backends to hook into PR handling
Date: Fri,  7 Apr 2023 15:05:48 -0500	[thread overview]
Message-ID: <20230407200551.12660-16-michael.christie@oracle.com> (raw)
In-Reply-To: <20230407200551.12660-1-michael.christie@oracle.com>

For the cases where you want to export a device to a VM via a single
I_T nexus and want to passthrough the PR handling to the physical/real
device you have to use pscsi or tcmu. Both are good for specific uses
however for the case where you want good performance, and are not using
SCSI devices directly (using DM/MD RAID or multipath devices) then we are
out of luck.

The following patches allow iblock to mimimally hook into the LIO PR code
and then pass the PR handling to the physical device. Note that like with
the tcmu an pscsi cases it's only supported when you export the device via
one I_T nexus.

This patch adds the initial LIO callouts. The next patch will modify
iblock.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
 drivers/target/target_core_pr.c      | 62 +++++++++++++++++++++++++++-
 include/target/target_core_backend.h |  4 ++
 2 files changed, 65 insertions(+), 1 deletion(-)

diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c
index 1493b1d01194..e16ef7d676af 100644
--- a/drivers/target/target_core_pr.c
+++ b/drivers/target/target_core_pr.c
@@ -3538,6 +3538,25 @@ core_scsi3_emulate_pro_register_and_move(struct se_cmd *cmd, u64 res_key,
 	return ret;
 }
 
+static sense_reason_t
+target_try_pr_out_pt(struct se_cmd *cmd, u8 sa, u64 res_key, u64 sa_res_key,
+		     u8 type, bool aptpl, bool all_tg_pt, bool spec_i_pt)
+{
+	struct exec_cmd_ops *ops = cmd->protocol_data;
+
+	if (!cmd->se_sess || !cmd->se_lun) {
+		pr_err("SPC-3 PR: se_sess || struct se_lun is NULL!\n");
+		return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
+	}
+
+	if (!ops->execute_pr_out) {
+		pr_err("SPC-3 PR: Device has been configured for PR passthrough but it's not supported by the backend.\n");
+		return TCM_UNSUPPORTED_SCSI_OPCODE;
+	}
+
+	return ops->execute_pr_out(cmd, sa, res_key, sa_res_key, type, aptpl);
+}
+
 /*
  * See spc4r17 section 6.14 Table 170
  */
@@ -3641,6 +3660,12 @@ target_scsi3_emulate_pr_out(struct se_cmd *cmd)
 		return TCM_PARAMETER_LIST_LENGTH_ERROR;
 	}
 
+	if (dev->transport_flags & TRANSPORT_FLAG_PASSTHROUGH_PGR) {
+		ret = target_try_pr_out_pt(cmd, sa, res_key, sa_res_key, type,
+					   aptpl, all_tg_pt, spec_i_pt);
+		goto done;
+	}
+
 	/*
 	 * (core_scsi3_emulate_pro_* function parameters
 	 * are defined by spc4r17 Table 174:
@@ -3682,6 +3707,7 @@ target_scsi3_emulate_pr_out(struct se_cmd *cmd)
 		return TCM_INVALID_CDB_FIELD;
 	}
 
+done:
 	if (!ret)
 		target_complete_cmd(cmd, SAM_STAT_GOOD);
 	return ret;
@@ -4039,9 +4065,37 @@ core_scsi3_pri_read_full_status(struct se_cmd *cmd)
 	return 0;
 }
 
+static sense_reason_t target_try_pr_in_pt(struct se_cmd *cmd, u8 sa)
+{
+	struct exec_cmd_ops *ops = cmd->protocol_data;
+	unsigned char *buf;
+	sense_reason_t ret;
+
+	if (cmd->data_length < 8) {
+		pr_err("PRIN SA SCSI Data Length: %u too small\n",
+		       cmd->data_length);
+		return TCM_INVALID_CDB_FIELD;
+	}
+
+	if (!ops->execute_pr_in) {
+		pr_err("SPC-3 PR: Device has been configured for PR passthrough but it's not supported by the backend.\n");
+		return TCM_UNSUPPORTED_SCSI_OPCODE;
+	}
+
+	buf = transport_kmap_data_sg(cmd);
+	if (!buf)
+		return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
+
+	ret = ops->execute_pr_in(cmd, sa, buf);
+
+	transport_kunmap_data_sg(cmd);
+	return ret;
+}
+
 sense_reason_t
 target_scsi3_emulate_pr_in(struct se_cmd *cmd)
 {
+	u8 sa = cmd->t_task_cdb[1] & 0x1f;
 	sense_reason_t ret;
 
 	/*
@@ -4060,7 +4114,12 @@ target_scsi3_emulate_pr_in(struct se_cmd *cmd)
 		return TCM_RESERVATION_CONFLICT;
 	}
 
-	switch (cmd->t_task_cdb[1] & 0x1f) {
+	if (cmd->se_dev->transport_flags & TRANSPORT_FLAG_PASSTHROUGH_PGR) {
+		ret = target_try_pr_in_pt(cmd, sa);
+		goto done;
+	}
+
+	switch (sa) {
 	case PRI_READ_KEYS:
 		ret = core_scsi3_pri_read_keys(cmd);
 		break;
@@ -4079,6 +4138,7 @@ target_scsi3_emulate_pr_in(struct se_cmd *cmd)
 		return TCM_INVALID_CDB_FIELD;
 	}
 
+done:
 	if (!ret)
 		target_complete_cmd(cmd, SAM_STAT_GOOD);
 	return ret;
diff --git a/include/target/target_core_backend.h b/include/target/target_core_backend.h
index c5df78959532..739df993aa5e 100644
--- a/include/target/target_core_backend.h
+++ b/include/target/target_core_backend.h
@@ -69,6 +69,10 @@ struct exec_cmd_ops {
 	sense_reason_t (*execute_write_same)(struct se_cmd *cmd);
 	sense_reason_t (*execute_unmap)(struct se_cmd *cmd,
 				sector_t lba, sector_t nolb);
+	sense_reason_t (*execute_pr_out)(struct se_cmd *cmd, u8 sa, u64 key,
+					 u64 sa_key, u8 type, bool aptpl);
+	sense_reason_t (*execute_pr_in)(struct se_cmd *cmd, u8 sa,
+					unsigned char *param_data);
 };
 
 int	transport_backend_register(const struct target_backend_ops *);
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Mike Christie <michael.christie@oracle.com>
To: bvanassche@acm.org, hch@lst.de, martin.petersen@oracle.com,
	linux-scsi@vger.kernel.org,
	james.bottomley@hansenpartnership.com,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	snitzer@kernel.org, axboe@kernel.dk,
	linux-nvme@lists.infradead.org, chaitanyak@nvidia.com,
	kbusch@kernel.org, target-devel@vger.kernel.org
Cc: Mike Christie <michael.christie@oracle.com>
Subject: [dm-devel] [PATCH v6 15/18] scsi: target: Allow backends to hook into PR handling
Date: Fri,  7 Apr 2023 15:05:48 -0500	[thread overview]
Message-ID: <20230407200551.12660-16-michael.christie@oracle.com> (raw)
In-Reply-To: <20230407200551.12660-1-michael.christie@oracle.com>

For the cases where you want to export a device to a VM via a single
I_T nexus and want to passthrough the PR handling to the physical/real
device you have to use pscsi or tcmu. Both are good for specific uses
however for the case where you want good performance, and are not using
SCSI devices directly (using DM/MD RAID or multipath devices) then we are
out of luck.

The following patches allow iblock to mimimally hook into the LIO PR code
and then pass the PR handling to the physical device. Note that like with
the tcmu an pscsi cases it's only supported when you export the device via
one I_T nexus.

This patch adds the initial LIO callouts. The next patch will modify
iblock.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
 drivers/target/target_core_pr.c      | 62 +++++++++++++++++++++++++++-
 include/target/target_core_backend.h |  4 ++
 2 files changed, 65 insertions(+), 1 deletion(-)

diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c
index 1493b1d01194..e16ef7d676af 100644
--- a/drivers/target/target_core_pr.c
+++ b/drivers/target/target_core_pr.c
@@ -3538,6 +3538,25 @@ core_scsi3_emulate_pro_register_and_move(struct se_cmd *cmd, u64 res_key,
 	return ret;
 }
 
+static sense_reason_t
+target_try_pr_out_pt(struct se_cmd *cmd, u8 sa, u64 res_key, u64 sa_res_key,
+		     u8 type, bool aptpl, bool all_tg_pt, bool spec_i_pt)
+{
+	struct exec_cmd_ops *ops = cmd->protocol_data;
+
+	if (!cmd->se_sess || !cmd->se_lun) {
+		pr_err("SPC-3 PR: se_sess || struct se_lun is NULL!\n");
+		return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
+	}
+
+	if (!ops->execute_pr_out) {
+		pr_err("SPC-3 PR: Device has been configured for PR passthrough but it's not supported by the backend.\n");
+		return TCM_UNSUPPORTED_SCSI_OPCODE;
+	}
+
+	return ops->execute_pr_out(cmd, sa, res_key, sa_res_key, type, aptpl);
+}
+
 /*
  * See spc4r17 section 6.14 Table 170
  */
@@ -3641,6 +3660,12 @@ target_scsi3_emulate_pr_out(struct se_cmd *cmd)
 		return TCM_PARAMETER_LIST_LENGTH_ERROR;
 	}
 
+	if (dev->transport_flags & TRANSPORT_FLAG_PASSTHROUGH_PGR) {
+		ret = target_try_pr_out_pt(cmd, sa, res_key, sa_res_key, type,
+					   aptpl, all_tg_pt, spec_i_pt);
+		goto done;
+	}
+
 	/*
 	 * (core_scsi3_emulate_pro_* function parameters
 	 * are defined by spc4r17 Table 174:
@@ -3682,6 +3707,7 @@ target_scsi3_emulate_pr_out(struct se_cmd *cmd)
 		return TCM_INVALID_CDB_FIELD;
 	}
 
+done:
 	if (!ret)
 		target_complete_cmd(cmd, SAM_STAT_GOOD);
 	return ret;
@@ -4039,9 +4065,37 @@ core_scsi3_pri_read_full_status(struct se_cmd *cmd)
 	return 0;
 }
 
+static sense_reason_t target_try_pr_in_pt(struct se_cmd *cmd, u8 sa)
+{
+	struct exec_cmd_ops *ops = cmd->protocol_data;
+	unsigned char *buf;
+	sense_reason_t ret;
+
+	if (cmd->data_length < 8) {
+		pr_err("PRIN SA SCSI Data Length: %u too small\n",
+		       cmd->data_length);
+		return TCM_INVALID_CDB_FIELD;
+	}
+
+	if (!ops->execute_pr_in) {
+		pr_err("SPC-3 PR: Device has been configured for PR passthrough but it's not supported by the backend.\n");
+		return TCM_UNSUPPORTED_SCSI_OPCODE;
+	}
+
+	buf = transport_kmap_data_sg(cmd);
+	if (!buf)
+		return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
+
+	ret = ops->execute_pr_in(cmd, sa, buf);
+
+	transport_kunmap_data_sg(cmd);
+	return ret;
+}
+
 sense_reason_t
 target_scsi3_emulate_pr_in(struct se_cmd *cmd)
 {
+	u8 sa = cmd->t_task_cdb[1] & 0x1f;
 	sense_reason_t ret;
 
 	/*
@@ -4060,7 +4114,12 @@ target_scsi3_emulate_pr_in(struct se_cmd *cmd)
 		return TCM_RESERVATION_CONFLICT;
 	}
 
-	switch (cmd->t_task_cdb[1] & 0x1f) {
+	if (cmd->se_dev->transport_flags & TRANSPORT_FLAG_PASSTHROUGH_PGR) {
+		ret = target_try_pr_in_pt(cmd, sa);
+		goto done;
+	}
+
+	switch (sa) {
 	case PRI_READ_KEYS:
 		ret = core_scsi3_pri_read_keys(cmd);
 		break;
@@ -4079,6 +4138,7 @@ target_scsi3_emulate_pr_in(struct se_cmd *cmd)
 		return TCM_INVALID_CDB_FIELD;
 	}
 
+done:
 	if (!ret)
 		target_complete_cmd(cmd, SAM_STAT_GOOD);
 	return ret;
diff --git a/include/target/target_core_backend.h b/include/target/target_core_backend.h
index c5df78959532..739df993aa5e 100644
--- a/include/target/target_core_backend.h
+++ b/include/target/target_core_backend.h
@@ -69,6 +69,10 @@ struct exec_cmd_ops {
 	sense_reason_t (*execute_write_same)(struct se_cmd *cmd);
 	sense_reason_t (*execute_unmap)(struct se_cmd *cmd,
 				sector_t lba, sector_t nolb);
+	sense_reason_t (*execute_pr_out)(struct se_cmd *cmd, u8 sa, u64 key,
+					 u64 sa_key, u8 type, bool aptpl);
+	sense_reason_t (*execute_pr_in)(struct se_cmd *cmd, u8 sa,
+					unsigned char *param_data);
 };
 
 int	transport_backend_register(const struct target_backend_ops *);
-- 
2.25.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


  parent reply	other threads:[~2023-04-07 20:09 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-07 20:05 [PATCH v6 00/18] Use block pr_ops in LIO Mike Christie
2023-04-07 20:05 ` [dm-devel] " Mike Christie
2023-04-07 20:05 ` [PATCH v6 01/18] block: Add PR callouts for read keys and reservation Mike Christie
2023-04-07 20:05   ` [dm-devel] " Mike Christie
2023-04-11  7:09   ` Hannes Reinecke
2023-04-11  7:09     ` [dm-devel] " Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 02/18] block: Rename BLK_STS_NEXUS to BLK_STS_RESV_CONFLICT Mike Christie
2023-04-07 20:05   ` [dm-devel] " Mike Christie
2023-04-08  8:05   ` Chaitanya Kulkarni
2023-04-08  8:05     ` [dm-devel] " Chaitanya Kulkarni
2023-04-11  5:33   ` Christoph Hellwig
2023-04-11  5:33     ` [dm-devel] " Christoph Hellwig
2023-04-11  7:09   ` Hannes Reinecke
2023-04-11  7:09     ` [dm-devel] " Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 03/18] scsi: Rename sd_pr_command Mike Christie
2023-04-07 20:05   ` [dm-devel] " Mike Christie
2023-04-11  7:10   ` Hannes Reinecke
2023-04-11  7:10     ` [dm-devel] " Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 04/18] scsi: Move sd_pr_type to scsi_common Mike Christie
2023-04-07 20:05   ` [dm-devel] " Mike Christie
2023-04-07 20:08   ` Bart Van Assche
2023-04-07 20:08     ` [dm-devel] " Bart Van Assche
2023-04-11  5:33   ` Christoph Hellwig
2023-04-11  5:33     ` [dm-devel] " Christoph Hellwig
2023-04-11  7:11   ` Hannes Reinecke
2023-04-11  7:11     ` [dm-devel] " Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 05/18] scsi: Add support for block PR read keys/reservation Mike Christie
2023-04-07 20:05   ` [dm-devel] " Mike Christie
2023-04-11  7:13   ` Hannes Reinecke
2023-04-11  7:13     ` [dm-devel] " Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 06/18] dm: " Mike Christie
2023-04-07 20:05   ` [dm-devel] " Mike Christie
2023-04-11  7:13   ` Hannes Reinecke
2023-04-11  7:13     ` [dm-devel] " Hannes Reinecke
2023-04-17 19:13   ` Mike Snitzer
2023-04-17 19:13     ` [dm-devel] " Mike Snitzer
2023-04-07 20:05 ` [PATCH v6 07/18] nvme: Fix reservation status related structs Mike Christie
2023-04-07 20:05   ` [dm-devel] " Mike Christie
2023-04-11  5:34   ` Christoph Hellwig
2023-04-11  5:34     ` [dm-devel] " Christoph Hellwig
2023-04-11  7:15   ` Hannes Reinecke
2023-04-11  7:15     ` [dm-devel] " Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 08/18] nvme: Don't hardcode the data len for pr commands Mike Christie
2023-04-07 20:05   ` [dm-devel] " Mike Christie
2023-04-11  7:15   ` Hannes Reinecke
2023-04-11  7:15     ` [dm-devel] " Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 09/18] nvme: Move pr code to it's own file Mike Christie
2023-04-07 20:05   ` [dm-devel] " Mike Christie
2023-04-11  5:35   ` Christoph Hellwig
2023-04-11  5:35     ` [dm-devel] " Christoph Hellwig
2023-04-11  7:17   ` Hannes Reinecke
2023-04-11  7:17     ` [dm-devel] " Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 10/18] nvme: Add helper to send pr command Mike Christie
2023-04-07 20:05   ` [dm-devel] " Mike Christie
2023-04-08  8:07   ` Chaitanya Kulkarni
2023-04-08  8:07     ` [dm-devel] " Chaitanya Kulkarni
2023-04-11  7:18   ` Hannes Reinecke
2023-04-11  7:18     ` [dm-devel] " Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 11/18] nvme: Add pr_ops read_keys support Mike Christie
2023-04-07 20:05   ` [dm-devel] " Mike Christie
2023-04-08  8:11   ` Chaitanya Kulkarni
2023-04-08  8:11     ` [dm-devel] " Chaitanya Kulkarni
2023-04-11  7:20   ` Hannes Reinecke
2023-04-11  7:20     ` [dm-devel] " Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 12/18] nvme: Add a nvme_pr_type enum Mike Christie
2023-04-07 20:05   ` [dm-devel] " Mike Christie
2023-04-11  7:29   ` Hannes Reinecke
2023-04-11  7:29     ` [dm-devel] " Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 13/18] nvme: Add pr_ops read_reservation support Mike Christie
2023-04-07 20:05   ` [dm-devel] " Mike Christie
2023-04-11  5:35   ` Christoph Hellwig
2023-04-11  5:35     ` [dm-devel] " Christoph Hellwig
2023-04-11  7:30   ` Hannes Reinecke
2023-04-11  7:30     ` [dm-devel] " Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 14/18] scsi: target: Rename sbc_ops to exec_cmd_ops Mike Christie
2023-04-07 20:05   ` [dm-devel] " Mike Christie
2023-04-11  7:30   ` Hannes Reinecke
2023-04-11  7:30     ` Hannes Reinecke
2023-04-07 20:05 ` Mike Christie [this message]
2023-04-07 20:05   ` [dm-devel] [PATCH v6 15/18] scsi: target: Allow backends to hook into PR handling Mike Christie
2023-04-11  7:31   ` Hannes Reinecke
2023-04-11  7:31     ` [dm-devel] " Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 16/18] scsi: target: Pass struct target_opcode_descriptor to enabled Mike Christie
2023-04-07 20:05   ` [dm-devel] " Mike Christie
2023-04-11  5:36   ` Christoph Hellwig
2023-04-11  5:36     ` [dm-devel] " Christoph Hellwig
2023-04-11  7:31   ` Hannes Reinecke
2023-04-11  7:31     ` [dm-devel] " Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 17/18] scsi: target: Report and detect unsupported PR commands Mike Christie
2023-04-07 20:05   ` [dm-devel] " Mike Christie
2023-04-11  5:36   ` Christoph Hellwig
2023-04-11  5:36     ` [dm-devel] " Christoph Hellwig
2023-04-11  7:32   ` Hannes Reinecke
2023-04-11  7:32     ` [dm-devel] " Hannes Reinecke
2023-04-07 20:05 ` [PATCH v6 18/18] scsi: target: Add block PR support to iblock Mike Christie
2023-04-07 20:05   ` [dm-devel] " Mike Christie
2023-04-11  5:36   ` Christoph Hellwig
2023-04-11  5:36     ` [dm-devel] " Christoph Hellwig
2023-04-11  7:33   ` Hannes Reinecke
2023-04-11  7:33     ` [dm-devel] " Hannes Reinecke
2023-04-12  9:36 ` [PATCH v6 00/18] Use block pr_ops in LIO Naresh Kamboju
2023-04-12  9:36   ` [dm-devel] " Naresh Kamboju
2023-04-12 10:25   ` Naresh Kamboju
2023-04-12 10:25     ` [dm-devel] " Naresh Kamboju
2023-04-12 18:28     ` Mike Christie
2023-04-12 18:28       ` [dm-devel] " Mike Christie
2023-04-13  9:50       ` Naresh Kamboju
2023-04-13  9:50         ` [dm-devel] " Naresh Kamboju
2023-04-12 10:57 ` Naresh Kamboju
2023-04-12 10:57   ` [dm-devel] " Naresh Kamboju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230407200551.12660-16-michael.christie@oracle.com \
    --to=michael.christie@oracle.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=chaitanyak@nvidia.com \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=snitzer@kernel.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.