From: Ping Cheng <pinglinux@gmail.com>
To: linux-input@vger.kernel.org
Cc: jkosina@suse.cz, jason.gerecke@wacom.com, aaron.skomra@wacom.com,
joshua.dickens@wacom.com, Ping Cheng <ping.cheng@wacom.com>
Subject: [PATCH] HID: wacom: Set a default resolution for older tablets
Date: Sun, 9 Apr 2023 09:42:29 -0700 [thread overview]
Message-ID: <20230409164229.29777-1-ping.cheng@wacom.com> (raw)
Some older tablets may not report physical maximum for X/Y
coordinates. Set a default to prevent undefined resolution.
Signed-off-by: Ping Cheng <ping.cheng@wacom.com>
---
drivers/hid/wacom_wac.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
index 9312d611db8e..e499b447d48c 100644
--- a/drivers/hid/wacom_wac.c
+++ b/drivers/hid/wacom_wac.c
@@ -1895,6 +1895,7 @@ static void wacom_map_usage(struct input_dev *input, struct hid_usage *usage,
int fmax = field->logical_maximum;
unsigned int equivalent_usage = wacom_equivalent_usage(usage->hid);
int resolution_code = code;
+ int resolution = hidinput_calc_abs_res(field, resolution_code);
if (equivalent_usage == HID_DG_TWIST) {
resolution_code = ABS_RZ;
@@ -1915,8 +1916,15 @@ static void wacom_map_usage(struct input_dev *input, struct hid_usage *usage,
switch (type) {
case EV_ABS:
input_set_abs_params(input, code, fmin, fmax, fuzz, 0);
- input_abs_set_res(input, code,
- hidinput_calc_abs_res(field, resolution_code));
+
+ /* older tablet may miss physical usage */
+ if ((code == ABS_X || code == ABS_Y) && !resolution) {
+ resolution = WACOM_INTUOS_RES;
+ hid_warn(input,
+ "Wacom usage (%d) missing resolution \n",
+ code);
+ }
+ input_abs_set_res(input, code, resolution);
break;
case EV_KEY:
case EV_MSC:
--
2.39.2
next reply other threads:[~2023-04-09 16:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-09 16:42 Ping Cheng [this message]
2023-04-13 14:37 ` [PATCH] HID: wacom: Set a default resolution for older tablets Benjamin Tissoires
2023-04-13 23:30 ` Ping Cheng
2023-04-14 7:55 ` Greg KH
2023-05-09 1:05 ` Ping Cheng
2023-05-09 2:34 ` Bagas Sanjaya
2023-05-09 2:44 ` Greg KH
2023-05-11 0:06 ` Ping Cheng
2023-05-13 7:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230409164229.29777-1-ping.cheng@wacom.com \
--to=pinglinux@gmail.com \
--cc=aaron.skomra@wacom.com \
--cc=jason.gerecke@wacom.com \
--cc=jkosina@suse.cz \
--cc=joshua.dickens@wacom.com \
--cc=linux-input@vger.kernel.org \
--cc=ping.cheng@wacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.