All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Denose <jdenose@chromium.org>
To: lyude@redhat.com
Cc: aduggan@synaptics.com, amandhoot12@gmail.com,
	dmitry.torokhov@gmail.com, jdenose@chromium.org,
	jdenose@google.com, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org, markpearson@lenovo.com,
	wsa+renesas@sang-engineering.com
Subject: [PATCH v2] Input: synaptics - disable intertouch for Lenovo L440
Date: Fri, 14 Apr 2023 11:41:15 -0500	[thread overview]
Message-ID: <20230414092353.v2.1.Ieb687047a5b75c7b7ee5dd258207ef5ca9a3b728@changeid> (raw)
In-Reply-To: <063c8f77c216ffac463532023009124542d54c19.camel@redhat.com>

When intertouch is enabled for the L440 a (deep)sleep/resume
cycle causes the touchpad driver to hang which causes the
touchpad to become unresponsive. Disable intertouch resolves
this issue and the touchpad is fine after resume from sleep.

Additionally, when the PNP id for the L440 is only removed
from the topbuttonpad_pnp_ids list, a message is logged to
enable psmouse.synaptics_intertouch, which would cause the
sleep/resume issue again. By removing the PNP id from
topbutton_pnp_ids and then adding it to the
forcepad_pnp_ids array, intertouch is disabled and the
message is not logged.

Signed-off-by: Jonathan Denose <jdenose@google.com>
---

Changes in v2:
- remove debug statement

 drivers/input/mouse/synaptics.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index fa021af8506e4..b7218b7652c20 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -150,7 +150,6 @@ static const char * const topbuttonpad_pnp_ids[] = {
 	"LEN2001", /* Edge E431 */
 	"LEN2002", /* Edge E531 */
 	"LEN2003",
-	"LEN2004", /* L440 */
 	"LEN2005",
 	"LEN2006", /* Edge E440/E540 */
 	"LEN2007",
@@ -198,6 +197,7 @@ static const char * const smbus_pnp_ids[] = {
 static const char * const forcepad_pnp_ids[] = {
 	"SYN300D",
 	"SYN3014",
+	"LEN2004", /* L440 */
 	NULL
 };
 
-- 
2.39.2


  reply	other threads:[~2023-04-14 16:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-12 22:54 [PATCH] Input: synaptics - disable intertouch for Lenovo L440 Jonathan Denose
2023-04-13 20:47 ` Lyude Paul
2023-04-14 16:41   ` Jonathan Denose [this message]
     [not found]     ` <CALNJtpXLHHSV8YshUnk0opLNMUJpT7DgBNRYXoP2Yn-fnA8vPA@mail.gmail.com>
2023-04-17 18:52       ` [PATCH v2] " Jonathan Denose
2023-04-17 20:14         ` Andrew Duggan
2023-04-24 19:11           ` Jonathan Denose
2023-05-02  3:11             ` Dmitry Torokhov
2023-05-04  3:32               ` Jeffery Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230414092353.v2.1.Ieb687047a5b75c7b7ee5dd258207ef5ca9a3b728@changeid \
    --to=jdenose@chromium.org \
    --cc=aduggan@synaptics.com \
    --cc=amandhoot12@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jdenose@google.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lyude@redhat.com \
    --cc=markpearson@lenovo.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.