All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Moessbauer <felix.moessbauer@siemens.com>
To: cip-dev@lists.cip-project.org
Cc: jan.kiszka@siemens.com, quirin.gylstorff@siemens.com,
	Felix Moessbauer <felix.moessbauer@siemens.com>
Subject: [isar-cip-core][PATCH 1/1] fix operator precedence in ebg and swupdate
Date: Wed, 19 Apr 2023 10:48:59 +0800	[thread overview]
Message-ID: <20230419024859.19550-1-felix.moessbauer@siemens.com> (raw)

Instead of using the += operator, we need to use the :append operator to
append IMAGE_FSTYPES to a target. Otherwise, the additional types are
evaluated first and by that, weak assignments ( ?= ) are ignored.

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 kas/opt/swupdate.yml                 | 2 +-
 recipes-core/images/efibootguard.inc | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kas/opt/swupdate.yml b/kas/opt/swupdate.yml
index 2899d6c..29b7dd6 100644
--- a/kas/opt/swupdate.yml
+++ b/kas/opt/swupdate.yml
@@ -20,7 +20,7 @@ local_conf_header:
 
   wic-swu: |
     IMAGE_TYPEDEP:wic += "squashfs"
-    IMAGE_FSTYPES += "swu"
+    IMAGE_FSTYPES:append = " swu"
     # squashfs is already compressed
     SWU_COMPRESSION_TYPE = ""
     WKS_FILE ?= "${MACHINE}-${SWUPDATE_BOOTLOADER}.wks.in"
diff --git a/recipes-core/images/efibootguard.inc b/recipes-core/images/efibootguard.inc
index bb1aa1d..23fb215 100644
--- a/recipes-core/images/efibootguard.inc
+++ b/recipes-core/images/efibootguard.inc
@@ -18,4 +18,4 @@ IMAGE_INSTALL:append:buster = " efibootguard"
 WIC_IMAGER_INSTALL:append = " efibootguard:${DISTRO_ARCH}"
 WDOG_TIMEOUT ?= "60"
 WICVARS += "WDOG_TIMEOUT KERNEL_IMAGE INITRD_IMAGE DTB_FILES"
-IMAGE_FSTYPES += "wic"
+IMAGE_FSTYPES:append = " wic"
-- 
2.39.2



             reply	other threads:[~2023-04-19 13:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19  2:48 Felix Moessbauer [this message]
2023-04-19  8:25 ` [isar-cip-core][PATCH 1/1] fix operator precedence in ebg and swupdate Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230419024859.19550-1-felix.moessbauer@siemens.com \
    --to=felix.moessbauer@siemens.com \
    --cc=cip-dev@lists.cip-project.org \
    --cc=jan.kiszka@siemens.com \
    --cc=quirin.gylstorff@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.