From: Atish Patra <atishp@rivosinc.com> To: linux-kernel@vger.kernel.org Cc: "Rajnesh Kanwal" <rkanwal@rivosinc.com>, "Atish Patra" <atishp@rivosinc.com>, "Alexandre Ghiti" <alex@ghiti.fr>, "Andrew Jones" <ajones@ventanamicro.com>, "Andrew Morton" <akpm@linux-foundation.org>, "Anup Patel" <anup@brainfault.org>, "Atish Patra" <atishp@atishpatra.org>, "Björn Töpel" <bjorn@rivosinc.com>, "Suzuki K Poulose" <suzuki.poulose@arm.com>, "Will Deacon" <will@kernel.org>, "Marc Zyngier" <maz@kernel.org>, "Sean Christopherson" <seanjc@google.com>, linux-coco@lists.linux.dev, "Dylan Reid" <dylan@rivosinc.com>, abrestic@rivosinc.com, "Samuel Ortiz" <sameo@rivosinc.com>, "Christoph Hellwig" <hch@infradead.org>, "Conor Dooley" <conor.dooley@microchip.com>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Guo Ren" <guoren@kernel.org>, "Heiko Stuebner" <heiko@sntech.de>, "Jiri Slaby" <jirislaby@kernel.org>, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, "Mayuresh Chitale" <mchitale@ventanamicro.com>, "Palmer Dabbelt" <palmer@dabbelt.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Paul Walmsley" <paul.walmsley@sifive.com>, "Uladzislau Rezki" <urezki@gmail.com> Subject: [RFC 01/48] mm/vmalloc: Introduce arch hooks to notify ioremap/unmap changes Date: Wed, 19 Apr 2023 15:16:29 -0700 [thread overview] Message-ID: <20230419221716.3603068-2-atishp@rivosinc.com> (raw) In-Reply-To: <20230419221716.3603068-1-atishp@rivosinc.com> From: Rajnesh Kanwal <rkanwal@rivosinc.com> In virtualization, the guest may need notify the host about the ioremap regions. This is a common usecase in confidential computing where the host only provides MMIO emulation for the regions specified by the guest. Add a pair if arch specific callbacks to track the ioremapped regions. This patch is based on pkvm patches. A generic arch config can be added similar to pkvm if this is going to be the final solution. The device authorization/filtering approach is very different from this and we may prefer that one as it provides more flexibility in terms of which devices are allowed for the confidential guests. Signed-off-by: Rajnesh Kanwal <rkanwal@rivosinc.com> Signed-off-by: Atish Patra <atishp@rivosinc.com> --- mm/vmalloc.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index bef6cf2..023630e 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -304,6 +304,14 @@ static int vmap_range_noflush(unsigned long addr, unsigned long end, return err; } +__weak void ioremap_phys_range_hook(phys_addr_t phys_addr, size_t size, pgprot_t prot) +{ +} + +__weak void iounmap_phys_range_hook(phys_addr_t phys_addr, size_t size) +{ +} + int ioremap_page_range(unsigned long addr, unsigned long end, phys_addr_t phys_addr, pgprot_t prot) { @@ -315,6 +323,10 @@ int ioremap_page_range(unsigned long addr, unsigned long end, if (!err) kmsan_ioremap_page_range(addr, end, phys_addr, prot, ioremap_max_page_shift); + + if (!err) + ioremap_phys_range_hook(phys_addr, end - addr, prot); + return err; } @@ -2772,6 +2784,10 @@ void vunmap(const void *addr) addr); return; } + + if (vm->flags & VM_IOREMAP) + iounmap_phys_range_hook(vm->phys_addr, get_vm_area_size(vm)); + kfree(vm); } EXPORT_SYMBOL(vunmap); -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Atish Patra <atishp@rivosinc.com> To: linux-kernel@vger.kernel.org Cc: "Rajnesh Kanwal" <rkanwal@rivosinc.com>, "Atish Patra" <atishp@rivosinc.com>, "Alexandre Ghiti" <alex@ghiti.fr>, "Andrew Jones" <ajones@ventanamicro.com>, "Andrew Morton" <akpm@linux-foundation.org>, "Anup Patel" <anup@brainfault.org>, "Atish Patra" <atishp@atishpatra.org>, "Björn Töpel" <bjorn@rivosinc.com>, "Suzuki K Poulose" <suzuki.poulose@arm.com>, "Will Deacon" <will@kernel.org>, "Marc Zyngier" <maz@kernel.org>, "Sean Christopherson" <seanjc@google.com>, linux-coco@lists.linux.dev, "Dylan Reid" <dylan@rivosinc.com>, abrestic@rivosinc.com, "Samuel Ortiz" <sameo@rivosinc.com>, "Christoph Hellwig" <hch@infradead.org>, "Conor Dooley" <conor.dooley@microchip.com>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Guo Ren" <guoren@kernel.org>, "Heiko Stuebner" <heiko@sntech.de>, "Jiri Slaby" <jirislaby@kernel.org>, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, "Mayuresh Chitale" <mchitale@ventanamicro.com>, "Palmer Dabbelt" <palmer@dabbelt.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Paul Walmsley" <paul.walmsley@sifive.com>, "Uladzislau Rezki" <urezki@gmail.com> Subject: [RFC 01/48] mm/vmalloc: Introduce arch hooks to notify ioremap/unmap changes Date: Wed, 19 Apr 2023 15:16:29 -0700 [thread overview] Message-ID: <20230419221716.3603068-2-atishp@rivosinc.com> (raw) In-Reply-To: <20230419221716.3603068-1-atishp@rivosinc.com> From: Rajnesh Kanwal <rkanwal@rivosinc.com> In virtualization, the guest may need notify the host about the ioremap regions. This is a common usecase in confidential computing where the host only provides MMIO emulation for the regions specified by the guest. Add a pair if arch specific callbacks to track the ioremapped regions. This patch is based on pkvm patches. A generic arch config can be added similar to pkvm if this is going to be the final solution. The device authorization/filtering approach is very different from this and we may prefer that one as it provides more flexibility in terms of which devices are allowed for the confidential guests. Signed-off-by: Rajnesh Kanwal <rkanwal@rivosinc.com> Signed-off-by: Atish Patra <atishp@rivosinc.com> --- mm/vmalloc.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index bef6cf2..023630e 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -304,6 +304,14 @@ static int vmap_range_noflush(unsigned long addr, unsigned long end, return err; } +__weak void ioremap_phys_range_hook(phys_addr_t phys_addr, size_t size, pgprot_t prot) +{ +} + +__weak void iounmap_phys_range_hook(phys_addr_t phys_addr, size_t size) +{ +} + int ioremap_page_range(unsigned long addr, unsigned long end, phys_addr_t phys_addr, pgprot_t prot) { @@ -315,6 +323,10 @@ int ioremap_page_range(unsigned long addr, unsigned long end, if (!err) kmsan_ioremap_page_range(addr, end, phys_addr, prot, ioremap_max_page_shift); + + if (!err) + ioremap_phys_range_hook(phys_addr, end - addr, prot); + return err; } @@ -2772,6 +2784,10 @@ void vunmap(const void *addr) addr); return; } + + if (vm->flags & VM_IOREMAP) + iounmap_phys_range_hook(vm->phys_addr, get_vm_area_size(vm)); + kfree(vm); } EXPORT_SYMBOL(vunmap); -- 2.25.1 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-04-19 22:17 UTC|newest] Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-04-19 22:16 [RFC 00/48] RISC-V CoVE support Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` Atish Patra [this message] 2023-04-19 22:16 ` [RFC 01/48] mm/vmalloc: Introduce arch hooks to notify ioremap/unmap changes Atish Patra 2023-04-20 19:42 ` Lorenzo Stoakes 2023-04-20 19:42 ` Lorenzo Stoakes 2023-04-20 22:01 ` Atish Kumar Patra 2023-04-20 22:01 ` Atish Kumar Patra 2023-04-19 22:16 ` [RFC 02/48] RISC-V: KVM: Improve KVM error reporting to the user space Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 03/48] RISC-V: KVM: Invoke aia_update with preempt disabled/irq enabled Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 04/48] RISC-V: KVM: Add a helper function to get pgd size Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 05/48] RISC-V: Add COVH SBI extensions definitions Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 06/48] RISC-V: KVM: Implement COVH SBI extension Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 07/48] RISC-V: KVM: Add a barebone CoVE implementation Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 08/48] RISC-V: KVM: Add UABI to support static memory region attestation Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 09/48] RISC-V: KVM: Add CoVE related nacl helpers Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 10/48] RISC-V: KVM: Implement static memory region measurement Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-20 15:17 ` Sean Christopherson 2023-04-20 15:17 ` Sean Christopherson 2023-04-21 18:50 ` Atish Kumar Patra 2023-04-21 18:50 ` Atish Kumar Patra 2023-04-19 22:16 ` [RFC 11/48] RISC-V: KVM: Use the new VM IOCTL for measuring pages Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 12/48] RISC-V: KVM: Exit to the user space for trap redirection Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 13/48] RISC-V: KVM: Return early for gstage modifications Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 14/48] RISC-V: KVM: Skip dirty logging updates for TVM Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 15/48] RISC-V: KVM: Add a helper function to trigger fence ops Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 16/48] RISC-V: KVM: Skip most VCPU requests for TVMs Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 17/48] RISC-V : KVM: Skip vmid/hgatp management " Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 18/48] RISC-V: KVM: Skip TLB " Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 19/48] RISC-V: KVM: Register memory regions as confidential " Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 20/48] RISC-V: KVM: Add gstage mapping " Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 21/48] RISC-V: KVM: Handle SBI call forward from the TSM Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 22/48] RISC-V: KVM: Implement vcpu load/put functions for CoVE guests Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 23/48] RISC-V: KVM: Wireup TVM world switch Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 24/48] RISC-V: KVM: Update timer functionality for TVMs Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 25/48] RISC-V: KVM: Skip HVIP update " Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 26/48] RISC-V: Add COVI extension definitions Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 27/48] RISC-V: KVM: Implement COVI SBI extension Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 28/48] RISC-V: KVM: Add interrupt management functions for TVM Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 29/48] RISC-V: KVM: Skip AIA CSR updates for TVMs Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 30/48] RISC-V: KVM: Perform limited operations in hardware enable/disable Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:16 ` [RFC 31/48] RISC-V: KVM: Indicate no support user space emulated IRQCHIP Atish Patra 2023-04-19 22:16 ` Atish Patra 2023-04-19 22:17 ` [RFC 32/48] RISC-V: KVM: Add AIA support for TVMs Atish Patra 2023-04-19 22:17 ` Atish Patra 2023-04-19 22:17 ` [RFC 33/48] RISC-V: KVM: Hookup TVM VCPU init/destroy Atish Patra 2023-04-19 22:17 ` Atish Patra 2023-04-19 22:17 ` [RFC 34/48] RISC-V: KVM: Initialize CoVE Atish Patra 2023-04-19 22:17 ` Atish Patra 2023-04-19 22:17 ` [RFC 35/48] RISC-V: KVM: Add TVM init/destroy calls Atish Patra 2023-04-19 22:17 ` Atish Patra 2023-04-19 22:17 ` [RFC 36/48] RISC-V: KVM: Read/write gprs from/to shmem in case of TVM VCPU Atish Patra 2023-04-19 22:17 ` Atish Patra 2023-04-19 22:17 ` [RFC 37/48] RISC-V: Add COVG SBI extension definitions Atish Patra 2023-04-19 22:17 ` Atish Patra 2023-04-19 22:17 ` [RFC 38/48] RISC-V: Add CoVE guest config and helper functions Atish Patra 2023-04-19 22:17 ` Atish Patra 2023-04-19 22:17 ` [RFC 39/48] RISC-V: Implement COVG SBI extension Atish Patra 2023-04-19 22:17 ` Atish Patra 2023-04-19 22:17 ` [RFC 40/48] RISC-V: COVE: Add COVH invalidate, validate, promote, demote and remove APIs Atish Patra 2023-04-19 22:17 ` Atish Patra 2023-04-19 22:17 ` [RFC 41/48] RISC-V: KVM: Add host side support to handle COVG SBI calls Atish Patra 2023-04-19 22:17 ` Atish Patra 2023-04-19 22:17 ` [RFC 42/48] RISC-V: Allow host to inject any ext interrupt id to a CoVE guest Atish Patra 2023-04-19 22:17 ` Atish Patra 2023-04-19 22:17 ` [RFC 43/48] RISC-V: Add base memory encryption functions Atish Patra 2023-04-19 22:17 ` Atish Patra 2023-04-19 22:17 ` [RFC 44/48] RISC-V: Add cc_platform_has() for RISC-V for CoVE Atish Patra 2023-04-19 22:17 ` Atish Patra 2023-04-19 22:17 ` [RFC 45/48] RISC-V: ioremap: Implement for arch specific ioremap hooks Atish Patra 2023-04-19 22:17 ` Atish Patra 2023-04-20 22:15 ` Dave Hansen 2023-04-20 22:15 ` Dave Hansen 2023-04-21 19:24 ` Atish Kumar Patra 2023-04-21 19:24 ` Atish Kumar Patra 2023-04-24 13:48 ` Dave Hansen 2023-04-24 13:48 ` Dave Hansen 2023-04-25 8:00 ` Atish Kumar Patra 2023-04-25 8:00 ` Atish Kumar Patra 2023-04-25 13:10 ` Dave Hansen 2023-04-25 13:10 ` Dave Hansen 2023-04-26 8:02 ` Atish Kumar Patra 2023-04-26 8:02 ` Atish Kumar Patra 2023-04-26 10:30 ` Anup Patel 2023-04-26 10:30 ` Anup Patel 2023-04-26 13:55 ` Andrew Bresticker 2023-04-26 13:55 ` Andrew Bresticker 2023-04-19 22:17 ` [RFC 46/48] riscv/virtio: Have CoVE guests enforce restricted virtio memory access Atish Patra 2023-04-19 22:17 ` Atish Patra 2023-04-19 22:17 ` [RFC 47/48] RISC-V: Add shared bounce buffer to support DBCN for CoVE Guest Atish Patra 2023-04-19 22:17 ` Atish Patra 2023-04-19 22:17 ` [RFC 48/48] drivers/hvc: sbi: Disable HVC console for TVMs Atish Patra 2023-04-19 22:17 ` Atish Patra 2023-04-19 22:58 ` [RFC 00/48] RISC-V CoVE support Atish Patra 2023-04-19 22:58 ` Atish Patra 2023-04-20 16:30 ` Sean Christopherson 2023-04-20 16:30 ` Sean Christopherson 2023-04-20 19:13 ` Atish Kumar Patra 2023-04-20 19:13 ` Atish Kumar Patra 2023-04-20 20:21 ` Sean Christopherson 2023-04-20 20:21 ` Sean Christopherson 2023-04-21 15:35 ` Michael Roth 2023-04-21 15:35 ` Michael Roth 2023-04-24 12:23 ` Christophe de Dinechin 2023-04-24 12:23 ` Christophe de Dinechin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230419221716.3603068-2-atishp@rivosinc.com \ --to=atishp@rivosinc.com \ --cc=abrestic@rivosinc.com \ --cc=ajones@ventanamicro.com \ --cc=akpm@linux-foundation.org \ --cc=alex@ghiti.fr \ --cc=anup@brainfault.org \ --cc=atishp@atishpatra.org \ --cc=bjorn@rivosinc.com \ --cc=conor.dooley@microchip.com \ --cc=dylan@rivosinc.com \ --cc=gregkh@linuxfoundation.org \ --cc=guoren@kernel.org \ --cc=hch@infradead.org \ --cc=heiko@sntech.de \ --cc=jirislaby@kernel.org \ --cc=kvm-riscv@lists.infradead.org \ --cc=kvm@vger.kernel.org \ --cc=linux-coco@lists.linux.dev \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-riscv@lists.infradead.org \ --cc=maz@kernel.org \ --cc=mchitale@ventanamicro.com \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=pbonzini@redhat.com \ --cc=rkanwal@rivosinc.com \ --cc=sameo@rivosinc.com \ --cc=seanjc@google.com \ --cc=suzuki.poulose@arm.com \ --cc=urezki@gmail.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.