All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
	"Darrick J. Wong" <djwong@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Howells <dhowells@redhat.com>,
	Matthew Wilcox <willy@infradead.org>,
	linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
	linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 13/17] block: don't plug in blkdev_write_iter
Date: Mon, 24 Apr 2023 07:49:22 +0200	[thread overview]
Message-ID: <20230424054926.26927-14-hch@lst.de> (raw)
In-Reply-To: <20230424054926.26927-1-hch@lst.de>

Remove the no needed plug in blkdev_write_iter.  For direct I/O that
issues more than a single I/O, the plug is already done in
__blkdev_direct_IO, and for synchronous buffered writes, the plug
is done in writeback_inodes_wb / wb_writeback, while for the other
cases a plug doesn't make sense.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/fops.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/block/fops.c b/block/fops.c
index c194939b851cfb..b670aa7c5bb745 100644
--- a/block/fops.c
+++ b/block/fops.c
@@ -520,7 +520,6 @@ static ssize_t blkdev_write_iter(struct kiocb *iocb, struct iov_iter *from)
 	struct block_device *bdev = iocb->ki_filp->private_data;
 	struct inode *bd_inode = bdev->bd_inode;
 	loff_t size = bdev_nr_bytes(bdev);
-	struct blk_plug plug;
 	size_t shorted = 0;
 	ssize_t ret;
 
@@ -545,12 +544,10 @@ static ssize_t blkdev_write_iter(struct kiocb *iocb, struct iov_iter *from)
 		iov_iter_truncate(from, size);
 	}
 
-	blk_start_plug(&plug);
 	ret = __generic_file_write_iter(iocb, from);
 	if (ret > 0)
 		ret = generic_write_sync(iocb, ret);
 	iov_iter_reexpand(from, iov_iter_count(from) + shorted);
-	blk_finish_plug(&plug);
 	return ret;
 }
 
-- 
2.39.2


WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-nfs@vger.kernel.org,
	cluster-devel@redhat.com, linux-xfs@vger.kernel.org,
	Miklos Szeredi <miklos@szeredi.hu>,
	"Darrick J. Wong" <djwong@kernel.org>,
	linux-kernel@vger.kernel.org,
	Matthew Wilcox <willy@infradead.org>,
	linux-f2fs-devel@lists.sourceforge.net,
	David Howells <dhowells@redhat.com>,
	linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-ext4@vger.kernel.org, ceph-devel@vger.kernel.org
Subject: [f2fs-dev] [PATCH 13/17] block: don't plug in blkdev_write_iter
Date: Mon, 24 Apr 2023 07:49:22 +0200	[thread overview]
Message-ID: <20230424054926.26927-14-hch@lst.de> (raw)
In-Reply-To: <20230424054926.26927-1-hch@lst.de>

Remove the no needed plug in blkdev_write_iter.  For direct I/O that
issues more than a single I/O, the plug is already done in
__blkdev_direct_IO, and for synchronous buffered writes, the plug
is done in writeback_inodes_wb / wb_writeback, while for the other
cases a plug doesn't make sense.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/fops.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/block/fops.c b/block/fops.c
index c194939b851cfb..b670aa7c5bb745 100644
--- a/block/fops.c
+++ b/block/fops.c
@@ -520,7 +520,6 @@ static ssize_t blkdev_write_iter(struct kiocb *iocb, struct iov_iter *from)
 	struct block_device *bdev = iocb->ki_filp->private_data;
 	struct inode *bd_inode = bdev->bd_inode;
 	loff_t size = bdev_nr_bytes(bdev);
-	struct blk_plug plug;
 	size_t shorted = 0;
 	ssize_t ret;
 
@@ -545,12 +544,10 @@ static ssize_t blkdev_write_iter(struct kiocb *iocb, struct iov_iter *from)
 		iov_iter_truncate(from, size);
 	}
 
-	blk_start_plug(&plug);
 	ret = __generic_file_write_iter(iocb, from);
 	if (ret > 0)
 		ret = generic_write_sync(iocb, ret);
 	iov_iter_reexpand(from, iov_iter_count(from) + shorted);
-	blk_finish_plug(&plug);
 	return ret;
 }
 
-- 
2.39.2



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 13/17] block: don't plug in blkdev_write_iter
Date: Mon, 24 Apr 2023 07:49:22 +0200	[thread overview]
Message-ID: <20230424054926.26927-14-hch@lst.de> (raw)
In-Reply-To: <20230424054926.26927-1-hch@lst.de>

Remove the no needed plug in blkdev_write_iter.  For direct I/O that
issues more than a single I/O, the plug is already done in
__blkdev_direct_IO, and for synchronous buffered writes, the plug
is done in writeback_inodes_wb / wb_writeback, while for the other
cases a plug doesn't make sense.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/fops.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/block/fops.c b/block/fops.c
index c194939b851cfb..b670aa7c5bb745 100644
--- a/block/fops.c
+++ b/block/fops.c
@@ -520,7 +520,6 @@ static ssize_t blkdev_write_iter(struct kiocb *iocb, struct iov_iter *from)
 	struct block_device *bdev = iocb->ki_filp->private_data;
 	struct inode *bd_inode = bdev->bd_inode;
 	loff_t size = bdev_nr_bytes(bdev);
-	struct blk_plug plug;
 	size_t shorted = 0;
 	ssize_t ret;
 
@@ -545,12 +544,10 @@ static ssize_t blkdev_write_iter(struct kiocb *iocb, struct iov_iter *from)
 		iov_iter_truncate(from, size);
 	}
 
-	blk_start_plug(&plug);
 	ret = __generic_file_write_iter(iocb, from);
 	if (ret > 0)
 		ret = generic_write_sync(iocb, ret);
 	iov_iter_reexpand(from, iov_iter_count(from) + shorted);
-	blk_finish_plug(&plug);
 	return ret;
 }
 
-- 
2.39.2


  parent reply	other threads:[~2023-04-24  5:51 UTC|newest]

Thread overview: 122+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-24  5:49 RFC: allow building a kernel without buffer_heads Christoph Hellwig
2023-04-24  5:49 ` [Cluster-devel] " Christoph Hellwig
2023-04-24  5:49 ` [f2fs-dev] " Christoph Hellwig
2023-04-24  5:49 ` [PATCH 01/17] fs: unexport buffer_check_dirty_writeback Christoph Hellwig
2023-04-24  5:49   ` [Cluster-devel] " Christoph Hellwig
2023-04-24  5:49   ` [f2fs-dev] " Christoph Hellwig
2023-05-19 14:17   ` Hannes Reinecke
2023-05-19 14:17     ` [Cluster-devel] " Hannes Reinecke
2023-05-19 14:17     ` [f2fs-dev] " Hannes Reinecke
2023-07-06  0:18   ` patchwork-bot+f2fs
2023-07-06  0:18     ` [Cluster-devel] " patchwork-bot+f2fs
2023-07-06  0:18     ` patchwork-bot+f2fs
2023-09-04 18:11   ` patchwork-bot+f2fs
2023-09-04 18:11     ` [Cluster-devel] " patchwork-bot+f2fs
2023-09-04 18:11     ` patchwork-bot+f2fs
2023-04-24  5:49 ` [PATCH 02/17] fs: remove the special !CONFIG_BLOCK def_blk_fops Christoph Hellwig
2023-04-24  5:49   ` [Cluster-devel] " Christoph Hellwig
2023-04-24  5:49   ` [f2fs-dev] " Christoph Hellwig
2023-04-24 19:22   ` Randy Dunlap
2023-04-24 19:22     ` [Cluster-devel] " Randy Dunlap
2023-04-24 19:22     ` [f2fs-dev] " Randy Dunlap
2023-04-24 19:37     ` Keith Busch
2023-04-24 19:37       ` [Cluster-devel] " Keith Busch
2023-04-24 19:37       ` [f2fs-dev] " Keith Busch
2023-04-24  5:49 ` [PATCH 03/17] fs: rename and move block_page_mkwrite_return Christoph Hellwig
2023-04-24  5:49   ` [Cluster-devel] " Christoph Hellwig
2023-04-24  5:49   ` [f2fs-dev] " Christoph Hellwig
2023-04-24 12:30   ` Matthew Wilcox
2023-04-24 12:30     ` [Cluster-devel] " Matthew Wilcox
2023-04-24 12:30     ` [f2fs-dev] " Matthew Wilcox
2023-04-24 12:42     ` Christoph Hellwig
2023-04-24 12:42       ` [Cluster-devel] " Christoph Hellwig
2023-04-24 12:42       ` [f2fs-dev] " Christoph Hellwig
2023-04-24  5:49 ` [PATCH 04/17] fs: remove emergency_thaw_bdev Christoph Hellwig
2023-04-24  5:49   ` [Cluster-devel] " Christoph Hellwig
2023-04-24  5:49   ` [f2fs-dev] " Christoph Hellwig
2023-04-24  5:49 ` [PATCH 05/17] filemap: update ki_pos in generic_perform_write Christoph Hellwig
2023-04-24  5:49   ` [Cluster-devel] " Christoph Hellwig
2023-04-24  5:49   ` [f2fs-dev] " Christoph Hellwig
2023-04-24 18:54   ` [Cluster-devel] " Andreas Gruenbacher
2023-04-24 18:54     ` Andreas Gruenbacher
2023-04-24 18:54     ` [f2fs-dev] " Andreas Gruenbacher
2023-04-24  5:49 ` [PATCH 06/17] filemap: add a kiocb_write_and_wait helper Christoph Hellwig
2023-04-24  5:49   ` [Cluster-devel] " Christoph Hellwig
2023-04-24  5:49   ` [f2fs-dev] " Christoph Hellwig
2023-04-24  5:49 ` [PATCH 07/17] filemap: add a kiocb_invalidate_pages helper Christoph Hellwig
2023-04-24  5:49   ` [Cluster-devel] " Christoph Hellwig
2023-04-24  5:49   ` [f2fs-dev] " Christoph Hellwig
2023-04-24  5:49 ` [PATCH 08/17] filemap: add a kiocb_invalidate_post_write helper Christoph Hellwig
2023-04-24  5:49   ` [Cluster-devel] " Christoph Hellwig
2023-04-24  5:49   ` [f2fs-dev] " Christoph Hellwig
2023-04-24  5:49 ` [PATCH 09/17] fs: factor out a direct_write_fallback helper Christoph Hellwig
2023-04-24  5:49   ` [Cluster-devel] " Christoph Hellwig
2023-04-24  5:49   ` [f2fs-dev] " Christoph Hellwig
2023-04-24  5:49 ` [PATCH 10/17] iomap: use kiocb_write_and_wait and kiocb_invalidate_pages Christoph Hellwig
2023-04-24  5:49   ` [Cluster-devel] " Christoph Hellwig
2023-04-24  5:49   ` [f2fs-dev] " Christoph Hellwig
2023-04-24  5:49 ` [PATCH 11/17] iomap: assign current->backing_dev_info in iomap_file_buffered_write Christoph Hellwig
2023-04-24  5:49   ` [Cluster-devel] " Christoph Hellwig
2023-04-24  5:49   ` [f2fs-dev] " Christoph Hellwig
2023-04-24  6:18   ` Darrick J. Wong
2023-04-24  6:18     ` [Cluster-devel] " Darrick J. Wong
2023-04-24  6:18     ` [f2fs-dev] " Darrick J. Wong
2023-04-24  6:22     ` Christoph Hellwig
2023-04-24  6:22       ` [Cluster-devel] " Christoph Hellwig
2023-04-24  6:22       ` [f2fs-dev] " Christoph Hellwig
2023-04-24  5:49 ` [PATCH 12/17] fuse: use direct_write_fallback Christoph Hellwig
2023-04-24  5:49   ` [Cluster-devel] " Christoph Hellwig
2023-04-24  5:49   ` [f2fs-dev] " Christoph Hellwig
2023-04-24  5:49 ` Christoph Hellwig [this message]
2023-04-24  5:49   ` [Cluster-devel] [PATCH 13/17] block: don't plug in blkdev_write_iter Christoph Hellwig
2023-04-24  5:49   ` [f2fs-dev] " Christoph Hellwig
2023-04-24  5:49 ` [PATCH 14/17] block: open code __generic_file_write_iter for blkdev writes Christoph Hellwig
2023-04-24  5:49   ` [Cluster-devel] " Christoph Hellwig
2023-04-24  5:49   ` [f2fs-dev] " Christoph Hellwig
2023-05-24 22:23   ` Luis Chamberlain
2023-05-24 22:23     ` [Cluster-devel] " Luis Chamberlain
2023-05-24 22:23     ` [f2fs-dev] " Luis Chamberlain
2023-04-24  5:49 ` [PATCH 15/17] block: stop setting ->direct_IO Christoph Hellwig
2023-04-24  5:49   ` [Cluster-devel] " Christoph Hellwig
2023-04-24  5:49   ` [f2fs-dev] " Christoph Hellwig
2023-04-24  5:49 ` [PATCH 16/17] block: use iomap for writes to block devices Christoph Hellwig
2023-04-24  5:49   ` [Cluster-devel] " Christoph Hellwig
2023-04-24  5:49   ` [f2fs-dev] " Christoph Hellwig
     [not found]   ` <CGME20230426130921eucas1p279078812be7e8d50c1305e47cea53661@eucas1p2.samsung.com>
2023-04-26 13:00     ` Pankaj Raghav
2023-04-26 13:00       ` [Cluster-devel] " Pankaj Raghav
2023-05-19 14:22   ` Hannes Reinecke
2023-05-19 14:22     ` [Cluster-devel] " Hannes Reinecke
2023-05-19 14:22     ` [f2fs-dev] " Hannes Reinecke
2023-05-23 22:27     ` Dave Chinner
2023-05-23 22:27       ` [Cluster-devel] " Dave Chinner
2023-05-23 22:27       ` [f2fs-dev] " Dave Chinner via Linux-f2fs-devel
2023-05-24 13:33       ` Matthew Wilcox
2023-05-24 13:33         ` [Cluster-devel] " Matthew Wilcox
2023-05-24 13:33         ` [f2fs-dev] " Matthew Wilcox
2023-07-20 12:09         ` Christoph Hellwig
2023-07-20 12:09           ` [Cluster-devel] " Christoph Hellwig
2023-07-20 12:09           ` [f2fs-dev] " Christoph Hellwig
2023-07-20 12:06     ` Christoph Hellwig
2023-07-20 12:06       ` [Cluster-devel] " Christoph Hellwig
2023-07-20 12:06       ` [f2fs-dev] " Christoph Hellwig
2023-07-20 12:16       ` Hannes Reinecke
2023-07-20 12:16         ` [Cluster-devel] " Hannes Reinecke
2023-07-20 12:16         ` [f2fs-dev] " Hannes Reinecke
2023-04-24  5:49 ` [PATCH 17/17] fs: add CONFIG_BUFFER_HEAD Christoph Hellwig
2023-04-24  5:49   ` [Cluster-devel] " Christoph Hellwig
2023-04-24  5:49   ` [f2fs-dev] " Christoph Hellwig
2023-04-29  0:11   ` Luis Chamberlain
2023-04-29  0:11     ` [Cluster-devel] " Luis Chamberlain
2023-04-29  0:11     ` [f2fs-dev] " Luis Chamberlain
2023-04-29  1:20     ` Matthew Wilcox
2023-04-29  1:20       ` [Cluster-devel] " Matthew Wilcox
2023-04-29  1:20       ` [f2fs-dev] " Matthew Wilcox
2023-05-01  3:14       ` Luis Chamberlain
2023-05-01  3:14         ` [Cluster-devel] " Luis Chamberlain
2023-05-01  3:14         ` [f2fs-dev] " Luis Chamberlain
2023-05-01 15:46         ` Matthew Wilcox
2023-05-01 15:46           ` [Cluster-devel] " Matthew Wilcox
2023-05-01 15:46           ` [f2fs-dev] " Matthew Wilcox
2023-05-01 16:00           ` Pankaj Raghav
2023-05-01 16:00             ` [Cluster-devel] " Pankaj Raghav
2023-05-01 16:00             ` [f2fs-dev] " Pankaj Raghav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230424054926.26927-14-hch@lst.de \
    --to=hch@lst.de \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=ceph-devel@vger.kernel.org \
    --cc=cluster-devel@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=djwong@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.