All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
To: "axboe @ kernel . dk" <axboe@kernel.dk>
Cc: agruenba@redhat.com, cluster-devel@redhat.com,
	damien.lemoal@wdc.com, dm-devel@redhat.com, hare@suse.de,
	hch@lst.de, jfs-discussion@lists.sourceforge.net, kch@nvidia.com,
	linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, linux-raid@vger.kernel.org,
	ming.lei@redhat.com, rpeterso@redhat.com, shaggy@kernel.org,
	snitzer@kernel.org, song@kernel.org, willy@infradead.org,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>
Subject: [PATCH v5 06/20] md: raid5-log: use __bio_add_page to add single page
Date: Tue,  2 May 2023 12:19:20 +0200	[thread overview]
Message-ID: <20230502101934.24901-7-johannes.thumshirn@wdc.com> (raw)
In-Reply-To: <20230502101934.24901-1-johannes.thumshirn@wdc.com>

The raid5 log metadata submission code uses bio_add_page() to add a page
to a newly created bio. bio_add_page() can fail, but the return value is
never checked.

Use __bio_add_page() as adding a single page to a newly created bio is
guaranteed to succeed.

This brings us a step closer to marking bio_add_page() as __must_check.

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Acked-by: Song Liu <song@kernel.org>
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 drivers/md/raid5-cache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
index 46182b955aef..852b265c5db4 100644
--- a/drivers/md/raid5-cache.c
+++ b/drivers/md/raid5-cache.c
@@ -792,7 +792,7 @@ static struct r5l_io_unit *r5l_new_meta(struct r5l_log *log)
 	io->current_bio = r5l_bio_alloc(log);
 	io->current_bio->bi_end_io = r5l_log_endio;
 	io->current_bio->bi_private = io;
-	bio_add_page(io->current_bio, io->meta_page, PAGE_SIZE, 0);
+	__bio_add_page(io->current_bio, io->meta_page, PAGE_SIZE, 0);
 
 	r5_reserve_log_entry(log, io);
 
-- 
2.40.0


WARNING: multiple messages have this Message-ID (diff)
From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
To: "axboe @ kernel . dk" <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, damien.lemoal@wdc.com,
	kch@nvidia.com, agruenba@redhat.com, shaggy@kernel.org,
	song@kernel.org, Johannes Thumshirn <johannes.thumshirn@wdc.com>,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>,
	snitzer@kernel.org, jfs-discussion@lists.sourceforge.net,
	willy@infradead.org, ming.lei@redhat.com,
	cluster-devel@redhat.com, linux-mm@kvack.org,
	dm-devel@redhat.com, linux-fsdevel@vger.kernel.org,
	linux-raid@vger.kernel.org, hch@lst.de, rpeterso@redhat.com
Subject: [dm-devel] [PATCH v5 06/20] md: raid5-log: use __bio_add_page to add single page
Date: Tue,  2 May 2023 12:19:20 +0200	[thread overview]
Message-ID: <20230502101934.24901-7-johannes.thumshirn@wdc.com> (raw)
In-Reply-To: <20230502101934.24901-1-johannes.thumshirn@wdc.com>

The raid5 log metadata submission code uses bio_add_page() to add a page
to a newly created bio. bio_add_page() can fail, but the return value is
never checked.

Use __bio_add_page() as adding a single page to a newly created bio is
guaranteed to succeed.

This brings us a step closer to marking bio_add_page() as __must_check.

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Acked-by: Song Liu <song@kernel.org>
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 drivers/md/raid5-cache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
index 46182b955aef..852b265c5db4 100644
--- a/drivers/md/raid5-cache.c
+++ b/drivers/md/raid5-cache.c
@@ -792,7 +792,7 @@ static struct r5l_io_unit *r5l_new_meta(struct r5l_log *log)
 	io->current_bio = r5l_bio_alloc(log);
 	io->current_bio->bi_end_io = r5l_log_endio;
 	io->current_bio->bi_private = io;
-	bio_add_page(io->current_bio, io->meta_page, PAGE_SIZE, 0);
+	__bio_add_page(io->current_bio, io->meta_page, PAGE_SIZE, 0);
 
 	r5_reserve_log_entry(log, io);
 
-- 
2.40.0

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


WARNING: multiple messages have this Message-ID (diff)
From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v5 06/20] md: raid5-log: use __bio_add_page to add single page
Date: Tue,  2 May 2023 12:19:20 +0200	[thread overview]
Message-ID: <20230502101934.24901-7-johannes.thumshirn@wdc.com> (raw)
In-Reply-To: <20230502101934.24901-1-johannes.thumshirn@wdc.com>

The raid5 log metadata submission code uses bio_add_page() to add a page
to a newly created bio. bio_add_page() can fail, but the return value is
never checked.

Use __bio_add_page() as adding a single page to a newly created bio is
guaranteed to succeed.

This brings us a step closer to marking bio_add_page() as __must_check.

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Acked-by: Song Liu <song@kernel.org>
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 drivers/md/raid5-cache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
index 46182b955aef..852b265c5db4 100644
--- a/drivers/md/raid5-cache.c
+++ b/drivers/md/raid5-cache.c
@@ -792,7 +792,7 @@ static struct r5l_io_unit *r5l_new_meta(struct r5l_log *log)
 	io->current_bio = r5l_bio_alloc(log);
 	io->current_bio->bi_end_io = r5l_log_endio;
 	io->current_bio->bi_private = io;
-	bio_add_page(io->current_bio, io->meta_page, PAGE_SIZE, 0);
+	__bio_add_page(io->current_bio, io->meta_page, PAGE_SIZE, 0);
 
 	r5_reserve_log_entry(log, io);
 
-- 
2.40.0


  parent reply	other threads:[~2023-05-02 10:21 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-02 10:19 [PATCH v5 00/20] bio: check return values of bio_add_page Johannes Thumshirn
2023-05-02 10:19 ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 10:19 ` [dm-devel] " Johannes Thumshirn
2023-05-02 10:19 ` [PATCH v5 01/20] swap: use __bio_add_page to add page to bio Johannes Thumshirn
2023-05-02 10:19   ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 10:19   ` [dm-devel] " Johannes Thumshirn
2023-05-02 10:19 ` [PATCH v5 02/20] drbd: " Johannes Thumshirn
2023-05-02 10:19   ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 10:19   ` [dm-devel] " Johannes Thumshirn
2023-05-02 10:19 ` [PATCH v5 03/20] dm: dm-zoned: use __bio_add_page for adding single metadata page Johannes Thumshirn
2023-05-02 10:19   ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 10:19   ` [dm-devel] " Johannes Thumshirn
2023-05-02 10:19 ` [PATCH v5 04/20] fs: buffer: use __bio_add_page to add single page to bio Johannes Thumshirn
2023-05-02 10:19   ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 10:19   ` [dm-devel] " Johannes Thumshirn
2023-05-30  5:41   ` gouhao
2023-05-30  6:02   ` gouhao
2023-05-30  6:02     ` [Cluster-devel] [PATCH " gouhao
2023-05-30  6:02     ` [dm-devel] " gouhao
2023-05-02 10:19 ` [dm-devel] [PATCH v5 05/20] md: use __bio_add_page to add single page Johannes Thumshirn
2023-05-02 10:19   ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 10:19   ` Johannes Thumshirn
2023-05-02 10:19 ` Johannes Thumshirn [this message]
2023-05-02 10:19   ` [Cluster-devel] [PATCH v5 06/20] md: raid5-log: " Johannes Thumshirn
2023-05-02 10:19   ` [dm-devel] " Johannes Thumshirn
2023-05-02 10:19 ` [dm-devel] [PATCH v5 07/20] md: raid5: use __bio_add_page to add single page to new bio Johannes Thumshirn
2023-05-02 10:19   ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 10:19   ` Johannes Thumshirn
2023-05-02 10:19 ` [PATCH v5 08/20] jfs: logmgr: use __bio_add_page to add single page to bio Johannes Thumshirn
2023-05-02 10:19   ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 10:19   ` [dm-devel] " Johannes Thumshirn
2023-05-02 10:19 ` [dm-devel] [PATCH v5 09/20] gfs2: use __bio_add_page for adding " Johannes Thumshirn
2023-05-02 10:19   ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 10:19   ` Johannes Thumshirn
2023-05-02 11:51   ` Bob Peterson
2023-05-02 11:51     ` [Cluster-devel] " Bob Peterson
2023-05-02 11:51     ` [dm-devel] " Bob Peterson
2023-05-02 11:53     ` Johannes Thumshirn
2023-05-02 11:53       ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 11:53       ` [dm-devel] " Johannes Thumshirn
2023-05-02 10:19 ` [dm-devel] [PATCH v5 10/20] zonefs: " Johannes Thumshirn
2023-05-02 10:19   ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 10:19   ` Johannes Thumshirn
2023-05-02 10:19 ` [dm-devel] [PATCH v5 11/20] zram: " Johannes Thumshirn
2023-05-02 10:19   ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 10:19   ` Johannes Thumshirn
2023-05-02 10:19 ` [dm-devel] [PATCH v5 12/20] floppy: " Johannes Thumshirn
2023-05-02 10:19   ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 10:19   ` Johannes Thumshirn
2023-05-02 10:19 ` [dm-devel] [PATCH v5 13/20] md: check for failure when adding pages in alloc_behind_master_bio Johannes Thumshirn
2023-05-02 10:19   ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 10:19   ` Johannes Thumshirn
2023-05-02 10:19 ` [dm-devel] [PATCH v5 14/20] md: raid1: use __bio_add_page for adding single page to bio Johannes Thumshirn
2023-05-02 10:19   ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 10:19   ` Johannes Thumshirn
2023-05-02 10:19 ` [dm-devel] [PATCH v5 15/20] md: raid1: check if adding pages to resync bio fails Johannes Thumshirn
2023-05-02 10:19   ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 10:19   ` Johannes Thumshirn
2023-05-02 10:19 ` [dm-devel] [PATCH v5 16/20] dm-crypt: check if adding pages to clone " Johannes Thumshirn
2023-05-02 10:19   ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 10:19   ` Johannes Thumshirn
2023-05-30 15:13   ` [dm-devel] " Mikulas Patocka
2023-05-30 15:13     ` [Cluster-devel] " Mikulas Patocka
2023-05-30 15:13     ` Mikulas Patocka
2023-05-30 15:49     ` Mike Snitzer
2023-05-30 15:49       ` [Cluster-devel] " Mike Snitzer
2023-05-30 15:49       ` [dm-devel] " Mike Snitzer
2023-05-30 19:43       ` Mikulas Patocka
2023-05-30 19:43         ` [Cluster-devel] " Mikulas Patocka
2023-05-30 19:43         ` [dm-devel] " Mikulas Patocka
2023-06-01 18:46         ` Mike Snitzer
2023-06-01 18:46           ` [Cluster-devel] " Mike Snitzer
2023-06-01 18:46           ` Mike Snitzer
2023-05-02 10:19 ` [dm-devel] [PATCH v5 17/20] block: mark bio_add_page as __must_check Johannes Thumshirn
2023-05-02 10:19   ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 10:19   ` Johannes Thumshirn
2023-05-02 10:19 ` [dm-devel] [PATCH v5 18/20] block: add __bio_add_folio Johannes Thumshirn
2023-05-02 10:19   ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 10:19   ` Johannes Thumshirn
2023-05-02 10:19 ` [dm-devel] [PATCH v5 19/20] fs: iomap: use __bio_add_folio where possible Johannes Thumshirn
2023-05-02 10:19   ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 10:19   ` Johannes Thumshirn
2023-05-02 10:19 ` [dm-devel] [PATCH v5 20/20] block: mark bio_add_folio as __must_check Johannes Thumshirn
2023-05-02 10:19   ` [Cluster-devel] " Johannes Thumshirn
2023-05-02 10:19   ` Johannes Thumshirn
2023-05-05  8:09 ` [PATCH v5 00/20] bio: check return values of bio_add_page Johannes Thumshirn
2023-05-05  8:09   ` [Cluster-devel] " Johannes Thumshirn
2023-05-05  8:09   ` [dm-devel] " Johannes Thumshirn
2023-05-05 14:11   ` Jens Axboe
2023-05-05 14:11     ` [Cluster-devel] " Jens Axboe
2023-05-05 14:11     ` [dm-devel] " Jens Axboe
2023-05-24 10:04     ` Johannes Thumshirn
2023-05-24 10:04       ` [Cluster-devel] " Johannes Thumshirn
2023-05-24 10:04       ` [dm-devel] " Johannes Thumshirn
2023-05-24 15:02 ` Jens Axboe
2023-05-24 15:02   ` [Cluster-devel] " Jens Axboe
2023-05-24 15:02   ` [dm-devel] " Jens Axboe
2023-05-26  6:37   ` Johannes Thumshirn
2023-05-26  6:37     ` [Cluster-devel] " Johannes Thumshirn
2023-05-26  6:37     ` [dm-devel] " Johannes Thumshirn
2023-05-30 15:14     ` Jens Axboe
2023-05-30 15:14       ` [Cluster-devel] " Jens Axboe
2023-05-30 15:14       ` [dm-devel] " Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230502101934.24901-7-johannes.thumshirn@wdc.com \
    --to=johannes.thumshirn@wdc.com \
    --cc=agruenba@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=cluster-devel@redhat.com \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=damien.lemoal@wdc.com \
    --cc=dm-devel@redhat.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jfs-discussion@lists.sourceforge.net \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=rpeterso@redhat.com \
    --cc=shaggy@kernel.org \
    --cc=snitzer@kernel.org \
    --cc=song@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.