All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: alsa-devel@alsa-project.org
Cc: Takashi Iwai <tiwai@suse.de>
Subject: [PATCH v2 4/7] ALSA: pcm: playback silence - remove extra code
Date: Fri,  5 May 2023 17:52:41 +0200	[thread overview]
Message-ID: <20230505155244.2312199-4-oswald.buddenhagen@gmx.de> (raw)
In-Reply-To: <20230505155244.2312199-1-oswald.buddenhagen@gmx.de>

From: Jaroslav Kysela <perex@perex.cz>

The removed condition handles de facto only one situation where
runtime->silence_filled variable is equal to runtime->buffer_size,
because this variable cannot go over the buffer size. This case is
implicitly caught by the required comparison of the noise distance
with the threshold.

Suggested-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
---
v2:
- improved language of commit message
---
 sound/core/pcm_lib.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
index 5ddb74a12030..a1838130c830 100644
--- a/sound/core/pcm_lib.c
+++ b/sound/core/pcm_lib.c
@@ -61,8 +61,6 @@ void snd_pcm_playback_silence(struct snd_pcm_substream *substream, snd_pcm_ufram
 				runtime->silence_filled = 0;
 			runtime->silence_start = appl_ptr;
 		}
-		if (runtime->silence_filled >= runtime->buffer_size)
-			return;
 		/* initialization outside pointer updates */
 		if (new_hw_ptr == ULONG_MAX)
 			new_hw_ptr = runtime->status->hw_ptr;
-- 
2.40.0.152.g15d061e6df


  parent reply	other threads:[~2023-05-05 15:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05 15:52 [PATCH v2 1/7] ALSA: pcm: Revert "ALSA: pcm: rewrite snd_pcm_playback_silence()" Oswald Buddenhagen
2023-05-05 15:52 ` [PATCH v2 2/7] ALSA: pcm: fix playback silence - use the actual new_hw_ptr for the threshold mode Oswald Buddenhagen
2023-05-05 15:52 ` [PATCH v2 3/7] ALSA: pcm: fix playback silence - correct incremental silencing Oswald Buddenhagen
2023-05-05 15:52 ` Oswald Buddenhagen [this message]
2023-05-05 15:52 ` [PATCH v2 5/7] ALSA: pcm: playback silence - move silence variable updates to separate function Oswald Buddenhagen
2023-05-05 15:52 ` [PATCH v2 6/7] ALSA: pcm: simplify top-up mode init in snd_pcm_playback_silence() Oswald Buddenhagen
2023-05-05 15:52 ` [PATCH v2 7/7] ALSA: pcm: use exit controlled loop " Oswald Buddenhagen
2023-05-05 16:25 ` [PATCH v2 1/7] ALSA: pcm: Revert "ALSA: pcm: rewrite snd_pcm_playback_silence()" Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230505155244.2312199-4-oswald.buddenhagen@gmx.de \
    --to=oswald.buddenhagen@gmx.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.