All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Peter Xu <peterx@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>,
	Leonardo Bras <leobras@redhat.com>,
	Lukas Straub <lukasstraub2@web.de>
Subject: [PATCH 13/13] migration: Initialize and cleanup decompression in migration.c
Date: Mon,  8 May 2023 17:26:57 +0200	[thread overview]
Message-ID: <20230508152657.66701-14-quintela@redhat.com> (raw)
In-Reply-To: <20230508152657.66701-1-quintela@redhat.com>

From: Lukas Straub <lukasstraub2@web.de>

This fixes compress with colo.

Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 migration/migration.c | 9 +++++++++
 migration/ram.c       | 5 -----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/migration/migration.c b/migration/migration.c
index 232e387109..0ee07802a5 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -26,6 +26,7 @@
 #include "sysemu/cpu-throttle.h"
 #include "rdma.h"
 #include "ram.h"
+#include "ram-compress.h"
 #include "migration/global_state.h"
 #include "migration/misc.h"
 #include "migration.h"
@@ -228,6 +229,7 @@ void migration_incoming_state_destroy(void)
     struct MigrationIncomingState *mis = migration_incoming_get_current();
 
     multifd_load_cleanup();
+    compress_threads_load_cleanup();
 
     if (mis->to_src_file) {
         /* Tell source that we are done */
@@ -500,6 +502,12 @@ process_incoming_migration_co(void *opaque)
     Error *local_err = NULL;
 
     assert(mis->from_src_file);
+
+    if (compress_threads_load_setup(mis->from_src_file)) {
+        error_report("Failed to setup decompress threads");
+        goto fail;
+    }
+
     mis->migration_incoming_co = qemu_coroutine_self();
     mis->largest_page_size = qemu_ram_pagesize_largest();
     postcopy_state_set(POSTCOPY_INCOMING_NONE);
@@ -565,6 +573,7 @@ fail:
     qemu_fclose(mis->from_src_file);
 
     multifd_load_cleanup();
+    compress_threads_load_cleanup();
 
     exit(EXIT_FAILURE);
 }
diff --git a/migration/ram.c b/migration/ram.c
index ee4ab31f25..f78e9912cd 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -3558,10 +3558,6 @@ void colo_release_ram_cache(void)
  */
 static int ram_load_setup(QEMUFile *f, void *opaque)
 {
-    if (compress_threads_load_setup(f)) {
-        return -1;
-    }
-
     xbzrle_load_setup();
     ramblock_recv_map_init();
 
@@ -3577,7 +3573,6 @@ static int ram_load_cleanup(void *opaque)
     }
 
     xbzrle_load_cleanup();
-    compress_threads_load_cleanup();
 
     RAMBLOCK_FOREACH_NOT_IGNORED(rb) {
         g_free(rb->receivedmap);
-- 
2.40.0



  parent reply	other threads:[~2023-05-08 15:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-08 15:26 [PATCH 00/13] Migration PULL request (20230508 edition) Juan Quintela
2023-05-08 15:26 ` [PATCH 01/13] qtest/migration-test.c: Add tests with compress enabled Juan Quintela
2023-05-08 15:26 ` [PATCH 02/13] qtest/migration-test.c: Add postcopy " Juan Quintela
2023-05-08 15:26 ` [PATCH 03/13] ram.c: Let the compress threads return a CompressResult enum Juan Quintela
2023-05-08 15:26 ` [PATCH 04/13] ram.c: Dont change param->block in the compress thread Juan Quintela
2023-05-08 15:26 ` [PATCH 05/13] ram.c: Reset result after sending queued data Juan Quintela
2023-05-08 15:26 ` [PATCH 06/13] ram.c: Do not call save_page_header() from compress threads Juan Quintela
2023-05-08 15:26 ` [PATCH 07/13] ram.c: Call update_compress_thread_counts from compress_send_queued_data Juan Quintela
2023-05-08 15:26 ` [PATCH 08/13] ram.c: Remove last ram.c dependency from the core compress code Juan Quintela
2023-05-08 15:26 ` [PATCH 09/13] ram.c: Move core compression code into its own file Juan Quintela
2023-05-08 15:26 ` [PATCH 10/13] ram.c: Move core decompression " Juan Quintela
2023-05-08 15:26 ` [PATCH 11/13] ram compress: Assert that the file buffer matches the result Juan Quintela
2023-05-08 15:26 ` [PATCH 12/13] ram-compress.c: Make target independent Juan Quintela
2023-05-08 15:26 ` Juan Quintela [this message]
2023-05-08 16:50 ` [PATCH 00/13] Migration PULL request (20230508 edition) Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230508152657.66701-14-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=leobras@redhat.com \
    --cc=lukasstraub2@web.de \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.