From: Chen Jiahao <chenjiahao16@huawei.com>
To: <linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
<kexec@lists.infradead.org>, <linux-doc@vger.kernel.org>
Cc: <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<conor.dooley@microchip.com>, <guoren@kernel.org>,
<heiko@sntech.de>, <bjorn@rivosinc.com>, <alex@ghiti.fr>,
<akpm@linux-foundation.org>, <atishp@rivosinc.com>,
<bhe@redhat.com>, <thunder.leizhen@huawei.com>,
<horms@kernel.org>
Subject: [PATCH -next v5 0/2] support allocating crashkernel above 4G explicitly on riscv
Date: Thu, 11 May 2023 16:51:37 +0800 [thread overview]
Message-ID: <20230511085139.1039088-1-chenjiahao16@huawei.com> (raw)
On riscv, the current crash kernel allocation logic is trying to
allocate within 32bit addressible memory region by default, if
failed, try to allocate without 4G restriction.
In need of saving DMA zone memory while allocating a relatively large
crash kernel region, allocating the reserved memory top down in
high memory, without overlapping the DMA zone, is a mature solution.
Hence this patchset introduces the parameter option crashkernel=X,[high,low].
One can reserve the crash kernel from high memory above DMA zone range
by explicitly passing "crashkernel=X,high"; or reserve a memory range
below 4G with "crashkernel=X,low". Besides, there are few rules need
to take notice:
1. "crashkernel=X,[high,low]" will be ignored if "crashkernel=size"
is specified.
2. "crashkernel=X,low" is valid only when "crashkernel=X,high" is passed
and there is enough memory to be allocated under 4G.
3. When allocating crashkernel above 4G and no "crashkernel=X,low" is
specified, a 128M low memory will be allocated automatically for
swiotlb bounce buffer.
See Documentation/admin-guide/kernel-parameters.txt for more information.
To verify loading the crashkernel, adapted kexec-tools is attached below:
https://github.com/chenjh005/kexec-tools/tree/build-test-riscv-v2
Following test cases have been performed as expected:
1) crashkernel=256M //low=256M
2) crashkernel=1G //low=1G
3) crashkernel=4G //high=4G, low=128M(default)
4) crashkernel=4G crashkernel=256M,high //high=4G, low=128M(default), high is ignored
5) crashkernel=4G crashkernel=256M,low //high=4G, low=128M(default), low is ignored
6) crashkernel=4G,high //high=4G, low=128M(default)
7) crashkernel=256M,low //low=0M, invalid
8) crashkernel=4G,high crashkernel=256M,low //high=4G, low=256M
9) crashkernel=4G,high crashkernel=4G,low //high=0M, low=0M, invalid
10) crashkernel=512M@0xd0000000 //low=512M
Changes since [v5]:
1. Update the crashkernel allocation logic when crashkernel=X,high
is specified. In this case, region above 4G will directly get
reserved as crashkernel, rather than trying lower 32bit allocation
first.
Changes since [v4]:
1. Update some imprecise code comments for cmdline parsing.
Changes since [v3]:
1. Update to print warning and return explicitly on failure when
crashkernel=size@offset is specified. Not changing the result
in this case but making the logic more straightforward.
2. Some minor cleanup.
Changes since [v2]:
1. Update the allocation logic to ensure the high crashkernel
region is reserved strictly above dma32_phys_limit.
2. Clean up some minor format problems.
Chen Jiahao (2):
riscv: kdump: Implement crashkernel=X,[high,low]
docs: kdump: Update the crashkernel description for riscv
.../admin-guide/kernel-parameters.txt | 15 ++--
arch/riscv/kernel/setup.c | 5 ++
arch/riscv/mm/init.c | 73 +++++++++++++++++--
3 files changed, 79 insertions(+), 14 deletions(-)
--
2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Chen Jiahao <chenjiahao16@huawei.com>
To: <linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
<kexec@lists.infradead.org>, <linux-doc@vger.kernel.org>
Cc: <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<conor.dooley@microchip.com>, <guoren@kernel.org>,
<heiko@sntech.de>, <bjorn@rivosinc.com>, <alex@ghiti.fr>,
<akpm@linux-foundation.org>, <atishp@rivosinc.com>,
<bhe@redhat.com>, <thunder.leizhen@huawei.com>,
<horms@kernel.org>
Subject: [PATCH -next v5 0/2] support allocating crashkernel above 4G explicitly on riscv
Date: Thu, 11 May 2023 16:51:37 +0800 [thread overview]
Message-ID: <20230511085139.1039088-1-chenjiahao16@huawei.com> (raw)
On riscv, the current crash kernel allocation logic is trying to
allocate within 32bit addressible memory region by default, if
failed, try to allocate without 4G restriction.
In need of saving DMA zone memory while allocating a relatively large
crash kernel region, allocating the reserved memory top down in
high memory, without overlapping the DMA zone, is a mature solution.
Hence this patchset introduces the parameter option crashkernel=X,[high,low].
One can reserve the crash kernel from high memory above DMA zone range
by explicitly passing "crashkernel=X,high"; or reserve a memory range
below 4G with "crashkernel=X,low". Besides, there are few rules need
to take notice:
1. "crashkernel=X,[high,low]" will be ignored if "crashkernel=size"
is specified.
2. "crashkernel=X,low" is valid only when "crashkernel=X,high" is passed
and there is enough memory to be allocated under 4G.
3. When allocating crashkernel above 4G and no "crashkernel=X,low" is
specified, a 128M low memory will be allocated automatically for
swiotlb bounce buffer.
See Documentation/admin-guide/kernel-parameters.txt for more information.
To verify loading the crashkernel, adapted kexec-tools is attached below:
https://github.com/chenjh005/kexec-tools/tree/build-test-riscv-v2
Following test cases have been performed as expected:
1) crashkernel=256M //low=256M
2) crashkernel=1G //low=1G
3) crashkernel=4G //high=4G, low=128M(default)
4) crashkernel=4G crashkernel=256M,high //high=4G, low=128M(default), high is ignored
5) crashkernel=4G crashkernel=256M,low //high=4G, low=128M(default), low is ignored
6) crashkernel=4G,high //high=4G, low=128M(default)
7) crashkernel=256M,low //low=0M, invalid
8) crashkernel=4G,high crashkernel=256M,low //high=4G, low=256M
9) crashkernel=4G,high crashkernel=4G,low //high=0M, low=0M, invalid
10) crashkernel=512M@0xd0000000 //low=512M
Changes since [v5]:
1. Update the crashkernel allocation logic when crashkernel=X,high
is specified. In this case, region above 4G will directly get
reserved as crashkernel, rather than trying lower 32bit allocation
first.
Changes since [v4]:
1. Update some imprecise code comments for cmdline parsing.
Changes since [v3]:
1. Update to print warning and return explicitly on failure when
crashkernel=size@offset is specified. Not changing the result
in this case but making the logic more straightforward.
2. Some minor cleanup.
Changes since [v2]:
1. Update the allocation logic to ensure the high crashkernel
region is reserved strictly above dma32_phys_limit.
2. Clean up some minor format problems.
Chen Jiahao (2):
riscv: kdump: Implement crashkernel=X,[high,low]
docs: kdump: Update the crashkernel description for riscv
.../admin-guide/kernel-parameters.txt | 15 ++--
arch/riscv/kernel/setup.c | 5 ++
arch/riscv/mm/init.c | 73 +++++++++++++++++--
3 files changed, 79 insertions(+), 14 deletions(-)
--
2.31.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Chen Jiahao <chenjiahao16@huawei.com>
To: <linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
<kexec@lists.infradead.org>, <linux-doc@vger.kernel.org>
Cc: <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<conor.dooley@microchip.com>, <guoren@kernel.org>,
<heiko@sntech.de>, <bjorn@rivosinc.com>, <alex@ghiti.fr>,
<akpm@linux-foundation.org>, <atishp@rivosinc.com>,
<bhe@redhat.com>, <thunder.leizhen@huawei.com>,
<horms@kernel.org>
Subject: [PATCH -next v5 0/2] support allocating crashkernel above 4G explicitly on riscv
Date: Thu, 11 May 2023 16:51:37 +0800 [thread overview]
Message-ID: <20230511085139.1039088-1-chenjiahao16@huawei.com> (raw)
On riscv, the current crash kernel allocation logic is trying to
allocate within 32bit addressible memory region by default, if
failed, try to allocate without 4G restriction.
In need of saving DMA zone memory while allocating a relatively large
crash kernel region, allocating the reserved memory top down in
high memory, without overlapping the DMA zone, is a mature solution.
Hence this patchset introduces the parameter option crashkernel=X,[high,low].
One can reserve the crash kernel from high memory above DMA zone range
by explicitly passing "crashkernel=X,high"; or reserve a memory range
below 4G with "crashkernel=X,low". Besides, there are few rules need
to take notice:
1. "crashkernel=X,[high,low]" will be ignored if "crashkernel=size"
is specified.
2. "crashkernel=X,low" is valid only when "crashkernel=X,high" is passed
and there is enough memory to be allocated under 4G.
3. When allocating crashkernel above 4G and no "crashkernel=X,low" is
specified, a 128M low memory will be allocated automatically for
swiotlb bounce buffer.
See Documentation/admin-guide/kernel-parameters.txt for more information.
To verify loading the crashkernel, adapted kexec-tools is attached below:
https://github.com/chenjh005/kexec-tools/tree/build-test-riscv-v2
Following test cases have been performed as expected:
1) crashkernel=256M //low=256M
2) crashkernel=1G //low=1G
3) crashkernel=4G //high=4G, low=128M(default)
4) crashkernel=4G crashkernel=256M,high //high=4G, low=128M(default), high is ignored
5) crashkernel=4G crashkernel=256M,low //high=4G, low=128M(default), low is ignored
6) crashkernel=4G,high //high=4G, low=128M(default)
7) crashkernel=256M,low //low=0M, invalid
8) crashkernel=4G,high crashkernel=256M,low //high=4G, low=256M
9) crashkernel=4G,high crashkernel=4G,low //high=0M, low=0M, invalid
10) crashkernel=512M@0xd0000000 //low=512M
Changes since [v5]:
1. Update the crashkernel allocation logic when crashkernel=X,high
is specified. In this case, region above 4G will directly get
reserved as crashkernel, rather than trying lower 32bit allocation
first.
Changes since [v4]:
1. Update some imprecise code comments for cmdline parsing.
Changes since [v3]:
1. Update to print warning and return explicitly on failure when
crashkernel=size@offset is specified. Not changing the result
in this case but making the logic more straightforward.
2. Some minor cleanup.
Changes since [v2]:
1. Update the allocation logic to ensure the high crashkernel
region is reserved strictly above dma32_phys_limit.
2. Clean up some minor format problems.
Chen Jiahao (2):
riscv: kdump: Implement crashkernel=X,[high,low]
docs: kdump: Update the crashkernel description for riscv
.../admin-guide/kernel-parameters.txt | 15 ++--
arch/riscv/kernel/setup.c | 5 ++
arch/riscv/mm/init.c | 73 +++++++++++++++++--
3 files changed, 79 insertions(+), 14 deletions(-)
--
2.31.1
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next reply other threads:[~2023-05-11 8:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 8:51 Chen Jiahao [this message]
2023-05-11 8:51 ` [PATCH -next v5 0/2] support allocating crashkernel above 4G explicitly on riscv Chen Jiahao
2023-05-11 8:51 ` Chen Jiahao
2023-05-11 8:51 ` [PATCH -next v5 1/2] riscv: kdump: Implement crashkernel=X,[high,low] Chen Jiahao
2023-05-11 8:51 ` Chen Jiahao
2023-05-11 8:51 ` Chen Jiahao
2023-06-04 3:50 ` Baoquan He
2023-06-04 3:50 ` Baoquan He
2023-06-04 3:50 ` Baoquan He
2023-06-15 9:49 ` chenjiahao (C)
2023-06-15 9:49 ` chenjiahao (C)
2023-06-15 9:49 ` chenjiahao (C)
2023-07-01 9:51 ` chenjiahao (C)
2023-07-01 9:51 ` chenjiahao (C)
2023-07-01 9:51 ` chenjiahao (C)
2023-07-02 4:06 ` Baoquan He
2023-07-02 4:06 ` Baoquan He
2023-07-02 4:06 ` Baoquan He
2023-07-04 3:51 ` chenjiahao (C)
2023-07-04 3:51 ` chenjiahao (C)
2023-07-04 3:51 ` chenjiahao (C)
2023-05-11 8:51 ` [PATCH -next v5 2/2] docs: kdump: Update the crashkernel description for riscv Chen Jiahao
2023-05-11 8:51 ` Chen Jiahao
2023-05-11 8:51 ` Chen Jiahao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230511085139.1039088-1-chenjiahao16@huawei.com \
--to=chenjiahao16@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=atishp@rivosinc.com \
--cc=bhe@redhat.com \
--cc=bjorn@rivosinc.com \
--cc=conor.dooley@microchip.com \
--cc=guoren@kernel.org \
--cc=heiko@sntech.de \
--cc=horms@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.