From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com> To: rafael@kernel.org, daniel.lezcano@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: amitk@kernel.org, rui.zhang@intel.com, andrew.smirnov@gmail.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, alice.guo@nxp.com, Pankit Garg <pankit.garg@nxp.com>, Peng Fan <peng.fan@nxp.com> Subject: [PATCH 1/3] thermal: qoriq_thermal: No need to program site adjustment register Date: Tue, 16 May 2023 16:37:44 +0800 [thread overview] Message-ID: <20230516083746.63436-2-peng.fan@oss.nxp.com> (raw) In-Reply-To: <20230516083746.63436-1-peng.fan@oss.nxp.com> From: Pankit Garg <pankit.garg@nxp.com> No need to program site adjustment register, as programming these registers do not give accurate value and also these registers are not mentioned in Reference Manual. Signed-off-by: Pankit Garg <pankit.garg@nxp.com> Signed-off-by: Peng Fan <peng.fan@nxp.com> --- drivers/thermal/qoriq_thermal.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c index e58756323457..b806a0929459 100644 --- a/drivers/thermal/qoriq_thermal.c +++ b/drivers/thermal/qoriq_thermal.c @@ -208,8 +208,6 @@ static int qoriq_tmu_calibration(struct device *dev, static void qoriq_tmu_init_device(struct qoriq_tmu_data *data) { - int i; - /* Disable interrupt, using polling instead */ regmap_write(data->regmap, REGS_TIER, TIER_DISABLE); @@ -220,8 +218,6 @@ static void qoriq_tmu_init_device(struct qoriq_tmu_data *data) } else { regmap_write(data->regmap, REGS_V2_TMTMIR, TMTMIR_DEFAULT); regmap_write(data->regmap, REGS_V2_TEUMR(0), TEUMR0_V2); - for (i = 0; i < SITES_MAX; i++) - regmap_write(data->regmap, REGS_V2_TMSAR(i), TMSARA_V2); } /* Disable monitoring */ -- 2.37.1
WARNING: multiple messages have this Message-ID (diff)
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com> To: rafael@kernel.org, daniel.lezcano@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: amitk@kernel.org, rui.zhang@intel.com, andrew.smirnov@gmail.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, alice.guo@nxp.com, Pankit Garg <pankit.garg@nxp.com>, Peng Fan <peng.fan@nxp.com> Subject: [PATCH 1/3] thermal: qoriq_thermal: No need to program site adjustment register Date: Tue, 16 May 2023 16:37:44 +0800 [thread overview] Message-ID: <20230516083746.63436-2-peng.fan@oss.nxp.com> (raw) In-Reply-To: <20230516083746.63436-1-peng.fan@oss.nxp.com> From: Pankit Garg <pankit.garg@nxp.com> No need to program site adjustment register, as programming these registers do not give accurate value and also these registers are not mentioned in Reference Manual. Signed-off-by: Pankit Garg <pankit.garg@nxp.com> Signed-off-by: Peng Fan <peng.fan@nxp.com> --- drivers/thermal/qoriq_thermal.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c index e58756323457..b806a0929459 100644 --- a/drivers/thermal/qoriq_thermal.c +++ b/drivers/thermal/qoriq_thermal.c @@ -208,8 +208,6 @@ static int qoriq_tmu_calibration(struct device *dev, static void qoriq_tmu_init_device(struct qoriq_tmu_data *data) { - int i; - /* Disable interrupt, using polling instead */ regmap_write(data->regmap, REGS_TIER, TIER_DISABLE); @@ -220,8 +218,6 @@ static void qoriq_tmu_init_device(struct qoriq_tmu_data *data) } else { regmap_write(data->regmap, REGS_V2_TMTMIR, TMTMIR_DEFAULT); regmap_write(data->regmap, REGS_V2_TEUMR(0), TEUMR0_V2); - for (i = 0; i < SITES_MAX; i++) - regmap_write(data->regmap, REGS_V2_TMSAR(i), TMSARA_V2); } /* Disable monitoring */ -- 2.37.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-16 8:33 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-16 8:37 [PATCH 0/3] thermal: qoriq_thermal: support TMU 2.1 Peng Fan (OSS) 2023-05-16 8:37 ` Peng Fan (OSS) 2023-05-16 8:37 ` Peng Fan (OSS) [this message] 2023-05-16 8:37 ` [PATCH 1/3] thermal: qoriq_thermal: No need to program site adjustment register Peng Fan (OSS) 2023-05-16 8:37 ` [PATCH 2/3] thermal: qoriq_thermal: only enable supported sensors Peng Fan (OSS) 2023-05-16 8:37 ` Peng Fan (OSS) 2023-05-31 11:03 ` Daniel Lezcano 2023-05-31 11:03 ` Daniel Lezcano 2023-05-31 12:05 ` Peng Fan 2023-05-31 12:05 ` Peng Fan 2023-05-31 12:35 ` Daniel Lezcano 2023-05-31 12:35 ` Daniel Lezcano 2023-05-31 13:00 ` Peng Fan 2023-05-31 13:00 ` Peng Fan 2023-06-01 9:52 ` Peng Fan 2023-06-01 9:52 ` Peng Fan 2023-06-02 13:11 ` Daniel Lezcano 2023-06-02 13:11 ` Daniel Lezcano 2023-06-07 6:01 ` Sebastian Krzyszkowiak 2023-06-07 6:01 ` Sebastian Krzyszkowiak 2023-06-07 8:28 ` Daniel Lezcano 2023-06-07 8:28 ` Daniel Lezcano 2023-06-07 17:42 ` Sebastian Krzyszkowiak 2023-06-07 17:42 ` Sebastian Krzyszkowiak 2023-06-07 19:10 ` Daniel Lezcano 2023-06-07 19:10 ` Daniel Lezcano 2023-06-12 6:23 ` Sebastian Krzyszkowiak 2023-06-15 2:29 ` Peng Fan 2023-06-15 2:29 ` Peng Fan 2023-06-15 2:53 ` Sebastian Krzyszkowiak 2023-06-15 2:53 ` Sebastian Krzyszkowiak 2023-06-15 4:04 ` Peng Fan 2023-06-15 4:04 ` Peng Fan 2023-06-15 10:36 ` Daniel Lezcano 2023-06-15 10:36 ` Daniel Lezcano 2023-06-15 11:48 ` Daniel Lezcano 2023-06-15 11:48 ` Daniel Lezcano 2023-06-15 12:07 ` Peng Fan 2023-06-15 12:07 ` Peng Fan 2023-06-15 13:49 ` Daniel Lezcano 2023-06-15 13:49 ` Daniel Lezcano 2023-06-16 1:06 ` Peng Fan 2023-06-16 1:06 ` Peng Fan 2023-06-16 9:01 ` Daniel Lezcano 2023-06-16 9:01 ` Daniel Lezcano 2023-05-16 8:37 ` [PATCH 3/3] thermal: qoriq: support version 2.1 Peng Fan (OSS) 2023-05-16 8:37 ` Peng Fan (OSS) 2023-05-23 1:59 ` [PATCH 0/3] thermal: qoriq_thermal: support TMU 2.1 Alice Guo 2023-05-23 1:59 ` Alice Guo 2023-05-29 3:35 ` Peng Fan 2023-05-29 3:35 ` Peng Fan 2023-06-16 9:02 ` Daniel Lezcano 2023-06-16 9:02 ` Daniel Lezcano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230516083746.63436-2-peng.fan@oss.nxp.com \ --to=peng.fan@oss.nxp.com \ --cc=alice.guo@nxp.com \ --cc=amitk@kernel.org \ --cc=andrew.smirnov@gmail.com \ --cc=daniel.lezcano@linaro.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=pankit.garg@nxp.com \ --cc=peng.fan@nxp.com \ --cc=rafael@kernel.org \ --cc=rui.zhang@intel.com \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.