All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Oder Chiou <oder_chiou@realtek.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 03/12] ASoC: codecs: rt1318: do not store status in state container
Date: Wed, 17 May 2023 13:14:07 +0200	[thread overview]
Message-ID: <20230517111416.424420-3-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20230517111416.424420-1-krzysztof.kozlowski@linaro.org>

Driver in its update status callback stores Soundwire device status in
state container but it never uses it later.  Simplify the code a bit.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 sound/soc/codecs/rt1318-sdw.c | 5 +----
 sound/soc/codecs/rt1318-sdw.h | 1 -
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/sound/soc/codecs/rt1318-sdw.c b/sound/soc/codecs/rt1318-sdw.c
index 795accedc22c..3751d923611c 100644
--- a/sound/soc/codecs/rt1318-sdw.c
+++ b/sound/soc/codecs/rt1318-sdw.c
@@ -456,9 +456,6 @@ static int rt1318_update_status(struct sdw_slave *slave,
 {
 	struct  rt1318_sdw_priv *rt1318 = dev_get_drvdata(&slave->dev);
 
-	/* Update the status */
-	rt1318->status = status;
-
 	if (status == SDW_SLAVE_UNATTACHED)
 		rt1318->hw_init = false;
 
@@ -466,7 +463,7 @@ static int rt1318_update_status(struct sdw_slave *slave,
 	 * Perform initialization only if slave status is present and
 	 * hw_init flag is false
 	 */
-	if (rt1318->hw_init || rt1318->status != SDW_SLAVE_ATTACHED)
+	if (rt1318->hw_init || status != SDW_SLAVE_ATTACHED)
 		return 0;
 
 	/* perform I/O transfers required for Slave initialization */
diff --git a/sound/soc/codecs/rt1318-sdw.h b/sound/soc/codecs/rt1318-sdw.h
index 85918c184f16..86e83d63a017 100644
--- a/sound/soc/codecs/rt1318-sdw.h
+++ b/sound/soc/codecs/rt1318-sdw.h
@@ -88,7 +88,6 @@ struct rt1318_sdw_priv {
 	struct snd_soc_component *component;
 	struct regmap *regmap;
 	struct sdw_slave *sdw_slave;
-	enum sdw_slave_status status;
 	struct sdw_bus_params params;
 	bool hw_init;
 	bool first_hw_init;
-- 
2.34.1


  parent reply	other threads:[~2023-05-17 11:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-17 11:14 [PATCH 01/12] ASoC: codecs: rt1308: do not store status in state container Krzysztof Kozlowski
2023-05-17 11:14 ` [PATCH 02/12] ASoC: codecs: rt1316: " Krzysztof Kozlowski
2023-05-17 14:40   ` Mark Brown
2023-05-17 11:14 ` Krzysztof Kozlowski [this message]
2023-05-17 11:14 ` [PATCH 04/12] ASoC: codecs: rt5682: " Krzysztof Kozlowski
2023-05-17 11:14 ` [PATCH 05/12] ASoC: codecs: rt700: " Krzysztof Kozlowski
2023-05-17 11:14 ` [PATCH 06/12] ASoC: codecs: rt711-sdca: " Krzysztof Kozlowski
2023-05-17 11:14 ` [PATCH 07/12] ASoC: codecs: rt711: " Krzysztof Kozlowski
2023-05-17 11:14 ` [PATCH 08/12] ASoC: codecs: rt712-sdca-dmic: " Krzysztof Kozlowski
2023-05-17 11:14 ` [PATCH 09/12] ASoC: codecs: rt712-sdca: " Krzysztof Kozlowski
2023-05-17 11:14 ` [PATCH 10/12] ASoC: codecs: rt715-sdca: " Krzysztof Kozlowski
2023-05-17 11:14 ` [PATCH 11/12] ASoC: codecs: rt715: " Krzysztof Kozlowski
2023-05-17 11:14 ` [PATCH 12/12] ASoC: codecs: rt722-sdca: " Krzysztof Kozlowski
2023-05-17 13:27 ` [PATCH 01/12] ASoC: codecs: rt1308: " Pierre-Louis Bossart
2023-05-18 17:20 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230517111416.424420-3-krzysztof.kozlowski@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.