All of lore.kernel.org
 help / color / mirror / Atom feed
From: Douglas Anderson <dianders@chromium.org>
To: Petr Mladek <pmladek@suse.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Matthias Kaehlcke <mka@chromium.org>,
	kgdb-bugreport@lists.sourceforge.net,
	Stephane Eranian <eranian@google.com>,
	mpe@ellerman.id.au, Tzung-Bi Shih <tzungbi@chromium.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linuxppc-dev@lists.ozlabs.org, Sumit Garg <sumit.garg@linaro.org>,
	npiggin@gmail.com, davem@davemloft.net,
	Marc Zyngier <maz@kernel.org>, Stephen Boyd <swboyd@chromium.org>,
	sparclinux@vger.kernel.org, christophe.leroy@csgroup.eu,
	Catalin Marinas <catalin.marinas@arm.com>,
	ravi.v.shankar@intel.com, Randy Dunlap <rdunlap@infradead.org>,
	Pingfan Liu <kernelfans@gmail.com>,
	Guenter Roeck <groeck@chromium.org>,
	Lecopzer Chen <lecopzer.chen@mediatek.com>,
	Ian Rogers <irogers@google.com>,
	ito-yuichi@fujitsu.com, ricardo.neri@intel.com,
	linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org, Will Deacon <will@kernel.org>,
	Chen-Yu Tsai <wens@csie.org>,
	linux-kernel@vger.kernel.org,
	Masayoshi Mizuma <msys.mizuma@gmail.com>,
	Andi Kleen <ak@linux.intel.com>,
	Douglas Anderson <dianders@chromium.org>
Subject: [PATCH v5 03/18] watchdog: remove WATCHDOG_DEFAULT
Date: Fri, 19 May 2023 10:18:27 -0700	[thread overview]
Message-ID: <20230519101840.v5.3.I6a729209a1320e0ad212176e250ff945b8f91b2a@changeid> (raw)
In-Reply-To: <20230519101840.v5.18.Ia44852044cdcb074f387e80df6b45e892965d4a1@changeid>

From: Lecopzer Chen <lecopzer.chen@mediatek.com>

No reference to WATCHDOG_DEFAULT, remove it.

Signed-off-by: Pingfan Liu <kernelfans@gmail.com>
Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
I yanked this patch from the mailing lists [1] into my series just to
make it easier to avoid conflicts between my series and the one adding
the arm64 perf hardlockup detector, in case someone wanted to test
them both together. This is a nice cleanup and could land together
with the rest of my series if that makes sense.

I changed the patch prefix to match others in my series.

[1] https://lore.kernel.org/r/20220903093415.15850-2-lecopzer.chen@mediatek.com/

(no changes since v4)

Changes in v4:
- Pulled ("remove WATCHDOG_DEFAULT") into my series for v4.

 kernel/watchdog.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 8e61f21e7e33..582d572e1379 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -30,10 +30,8 @@
 static DEFINE_MUTEX(watchdog_mutex);
 
 #if defined(CONFIG_HARDLOCKUP_DETECTOR) || defined(CONFIG_HAVE_NMI_WATCHDOG)
-# define WATCHDOG_DEFAULT	(SOFT_WATCHDOG_ENABLED | NMI_WATCHDOG_ENABLED)
 # define NMI_WATCHDOG_DEFAULT	1
 #else
-# define WATCHDOG_DEFAULT	(SOFT_WATCHDOG_ENABLED)
 # define NMI_WATCHDOG_DEFAULT	0
 #endif
 
-- 
2.40.1.698.g37aff9b760-goog


WARNING: multiple messages have this Message-ID (diff)
From: Douglas Anderson <dianders@chromium.org>
To: Petr Mladek <pmladek@suse.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Matthias Kaehlcke <mka@chromium.org>,
	kgdb-bugreport@lists.sourceforge.net,
	Stephane Eranian <eranian@google.com>,
	mpe@ellerman.id.au, Tzung-Bi Shih <tzungbi@chromium.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linuxppc-dev@lists.ozlabs.org, Sumit Garg <sumit.garg@linaro.org>,
	npiggin@gmail.com, davem@davemloft.net,
	Marc Zyngier <maz@kernel.org>, Stephen Boyd <swboyd@chromium.org>,
	sparclinux@vger.kernel.org, christophe.leroy@csgroup.eu,
	Catalin Marinas <catalin.marinas@arm.com>,
	ravi.v.shankar@intel.com, Randy Dunlap <rdunlap@infradead.org>,
	Pingfan Liu <kernelfans@gmail.com>,
	Guenter Roeck <groeck@chromium.org>,
	Lecopzer Chen <lecopzer.chen@mediatek.com>,
	Ian Rogers <irogers@google.com>,
	ito-yuichi@fujitsu.com, ricardo.neri@intel.com,
	linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org, Will Deacon <will@kernel.org>,
	Chen-Yu Tsai <wens@csie.org>,
	linux-kernel@vger.kernel.org,
	Masayoshi Mizuma <msys.mizuma@gmail.com>,
	Andi Kleen <ak@linux.intel.com>,
	Douglas Anderson <dianders@chromium.org>
Subject: [PATCH v5 03/18] watchdog: remove WATCHDOG_DEFAULT
Date: Fri, 19 May 2023 10:18:27 -0700	[thread overview]
Message-ID: <20230519101840.v5.3.I6a729209a1320e0ad212176e250ff945b8f91b2a@changeid> (raw)
In-Reply-To: <20230519101840.v5.18.Ia44852044cdcb074f387e80df6b45e892965d4a1@changeid>

From: Lecopzer Chen <lecopzer.chen@mediatek.com>

No reference to WATCHDOG_DEFAULT, remove it.

Signed-off-by: Pingfan Liu <kernelfans@gmail.com>
Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
I yanked this patch from the mailing lists [1] into my series just to
make it easier to avoid conflicts between my series and the one adding
the arm64 perf hardlockup detector, in case someone wanted to test
them both together. This is a nice cleanup and could land together
with the rest of my series if that makes sense.

I changed the patch prefix to match others in my series.

[1] https://lore.kernel.org/r/20220903093415.15850-2-lecopzer.chen@mediatek.com/

(no changes since v4)

Changes in v4:
- Pulled ("remove WATCHDOG_DEFAULT") into my series for v4.

 kernel/watchdog.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 8e61f21e7e33..582d572e1379 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -30,10 +30,8 @@
 static DEFINE_MUTEX(watchdog_mutex);
 
 #if defined(CONFIG_HARDLOCKUP_DETECTOR) || defined(CONFIG_HAVE_NMI_WATCHDOG)
-# define WATCHDOG_DEFAULT	(SOFT_WATCHDOG_ENABLED | NMI_WATCHDOG_ENABLED)
 # define NMI_WATCHDOG_DEFAULT	1
 #else
-# define WATCHDOG_DEFAULT	(SOFT_WATCHDOG_ENABLED)
 # define NMI_WATCHDOG_DEFAULT	0
 #endif
 
-- 
2.40.1.698.g37aff9b760-goog


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Douglas Anderson <dianders@chromium.org>
To: Petr Mladek <pmladek@suse.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Ian Rogers <irogers@google.com>,
	ito-yuichi@fujitsu.com,
	Lecopzer Chen <lecopzer.chen@mediatek.com>,
	kgdb-bugreport@lists.sourceforge.net, ricardo.neri@intel.com,
	Stephane Eranian <eranian@google.com>,
	Douglas Anderson <dianders@chromium.org>,
	Guenter Roeck <groeck@chromium.org>,
	sparclinux@vger.kernel.org, Will Deacon <will@kernel.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Andi Kleen <ak@linux.intel.com>, Marc Zyngier <maz@kernel.org>,
	Chen-Yu Tsai <wens@csie.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Masayoshi Mizuma <msys.mizuma@gmail.com>,
	ravi.v.shankar@intel.com, Tzung-Bi Shih <tzungbi@chromium.org>,
	npiggin@gmail.com, Stephen Boyd <swboyd@chromium.org>,
	Pingfan Liu <kernelfans@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	Sumit Garg <sumit.garg@linaro.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	linuxppc-dev@lists.ozla bs.org, davem@davemloft.net
Subject: [PATCH v5 03/18] watchdog: remove WATCHDOG_DEFAULT
Date: Fri, 19 May 2023 10:18:27 -0700	[thread overview]
Message-ID: <20230519101840.v5.3.I6a729209a1320e0ad212176e250ff945b8f91b2a@changeid> (raw)
In-Reply-To: <20230519101840.v5.18.Ia44852044cdcb074f387e80df6b45e892965d4a1@changeid>

From: Lecopzer Chen <lecopzer.chen@mediatek.com>

No reference to WATCHDOG_DEFAULT, remove it.

Signed-off-by: Pingfan Liu <kernelfans@gmail.com>
Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
I yanked this patch from the mailing lists [1] into my series just to
make it easier to avoid conflicts between my series and the one adding
the arm64 perf hardlockup detector, in case someone wanted to test
them both together. This is a nice cleanup and could land together
with the rest of my series if that makes sense.

I changed the patch prefix to match others in my series.

[1] https://lore.kernel.org/r/20220903093415.15850-2-lecopzer.chen@mediatek.com/

(no changes since v4)

Changes in v4:
- Pulled ("remove WATCHDOG_DEFAULT") into my series for v4.

 kernel/watchdog.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 8e61f21e7e33..582d572e1379 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -30,10 +30,8 @@
 static DEFINE_MUTEX(watchdog_mutex);
 
 #if defined(CONFIG_HARDLOCKUP_DETECTOR) || defined(CONFIG_HAVE_NMI_WATCHDOG)
-# define WATCHDOG_DEFAULT	(SOFT_WATCHDOG_ENABLED | NMI_WATCHDOG_ENABLED)
 # define NMI_WATCHDOG_DEFAULT	1
 #else
-# define WATCHDOG_DEFAULT	(SOFT_WATCHDOG_ENABLED)
 # define NMI_WATCHDOG_DEFAULT	0
 #endif
 
-- 
2.40.1.698.g37aff9b760-goog


  parent reply	other threads:[~2023-05-19 17:21 UTC|newest]

Thread overview: 113+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-19 17:18 [PATCH v5 00/18] watchdog/hardlockup: Add the buddy hardlockup detector Douglas Anderson
2023-05-19 17:18 ` [PATCH v5 18/18] arm64: Enable perf events based hard lockup detector Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` [PATCH v5 00/18] watchdog/hardlockup: Add the buddy hardlockup detector Douglas Anderson
2023-05-19 17:18 ` Douglas Anderson
2023-05-19 17:18 ` [PATCH v5 01/18] watchdog/perf: Define dummy watchdog_update_hrtimer_threshold() on correct config Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18 ` [PATCH v5 02/18] watchdog/perf: More properly prevent false positives with turbo modes Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-23  9:35   ` Petr Mladek
2023-05-23  9:35     ` Petr Mladek
2023-05-23  9:35     ` Petr Mladek
2023-05-19 17:18 ` Douglas Anderson [this message]
2023-05-19 17:18   ` [PATCH v5 03/18] watchdog: remove WATCHDOG_DEFAULT Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18 ` [PATCH v5 04/18] watchdog/hardlockup: change watchdog_nmi_enable() to void Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18 ` [PATCH v5 05/18] watchdog/perf: Ensure CPU-bound context when creating hardlockup detector event Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18 ` [PATCH v5 06/18] watchdog/hardlockup: Add comments to touch_nmi_watchdog() Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-23  9:58   ` Petr Mladek
2023-05-23  9:58     ` Petr Mladek
2023-05-23  9:58     ` Petr Mladek
2023-05-19 17:18 ` [PATCH v5 07/18] watchdog/perf: Rename watchdog_hld.c to watchdog_perf.c Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18 ` [PATCH v5 08/18] watchdog/hardlockup: Move perf hardlockup checking/panic to common watchdog.c Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-23 11:45   ` Petr Mladek
2023-05-23 11:45     ` Petr Mladek
2023-05-23 11:45     ` Petr Mladek
2023-05-19 17:18 ` [PATCH v5 09/18] watchdog/hardlockup: Style changes to watchdog_hardlockup_check() / is_hardlockup() Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18 ` [PATCH v5 10/18] watchdog/hardlockup: Add a "cpu" param to watchdog_hardlockup_check() Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-23 16:02   ` Petr Mladek
2023-05-23 16:02     ` Petr Mladek
2023-05-23 16:02     ` Petr Mladek
2023-05-23 16:34     ` Doug Anderson
2023-05-23 16:34       ` Doug Anderson
2023-05-23 16:34       ` Doug Anderson
2023-05-24 11:36       ` Petr Mladek
2023-05-24 11:36         ` Petr Mladek
2023-05-24 11:36         ` Petr Mladek
2023-05-19 17:18 ` [PATCH v5 11/18] watchdog/hardlockup: Move perf hardlockup watchdog petting to watchdog.c Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-24 13:07   ` Petr Mladek
2023-05-24 13:07     ` Petr Mladek
2023-05-24 13:07     ` Petr Mladek
2023-05-19 17:18 ` [PATCH v5 12/18] watchdog/hardlockup: Rename some "NMI watchdog" constants/function Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-24 13:38   ` Petr Mladek
2023-05-24 13:38     ` Petr Mladek
2023-05-24 13:38     ` Petr Mladek
2023-05-25 23:33     ` Doug Anderson
2023-05-25 23:33       ` Doug Anderson
2023-05-25 23:33       ` Doug Anderson
2023-05-19 17:18 ` [PATCH v5 13/18] watchdog/hardlockup: Have the perf hardlockup use __weak functions more cleanly Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-24 13:59   ` Petr Mladek
2023-05-24 13:59     ` Petr Mladek
2023-05-24 13:59     ` Petr Mladek
2023-05-24 19:38     ` Doug Anderson
2023-05-24 19:38       ` Doug Anderson
2023-05-24 19:38       ` Doug Anderson
2023-05-26 14:44       ` Petr Mladek
2023-05-26 14:44         ` Petr Mladek
2023-05-26 14:44         ` Petr Mladek
2023-05-19 17:18 ` [PATCH v5 14/18] watchdog/hardlockup: detect hard lockups using secondary (buddy) CPUs Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-25 16:26   ` Petr Mladek
2023-05-25 16:26     ` Petr Mladek
2023-05-25 16:26     ` Petr Mladek
2023-05-25 20:08     ` Doug Anderson
2023-05-25 20:08       ` Doug Anderson
2023-05-25 20:08       ` Doug Anderson
2023-05-26 12:29       ` Petr Mladek
2023-05-26 12:29         ` Petr Mladek
2023-05-26 12:29         ` Petr Mladek
2023-05-19 17:18 ` [PATCH v5 15/18] watchdog/perf: Add a weak function for an arch to detect if perf can use NMIs Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-26 12:36   ` Petr Mladek
2023-05-26 12:36     ` Petr Mladek
2023-05-26 12:36     ` Petr Mladek
2023-06-12 10:33   ` Mark Rutland
2023-06-12 10:33     ` Mark Rutland
2023-06-12 13:55     ` Doug Anderson
2023-06-12 13:55       ` Doug Anderson
2023-06-12 13:55       ` Doug Anderson
2023-06-12 13:59       ` Mark Rutland
2023-06-12 13:59         ` Mark Rutland
2023-06-12 13:59         ` Mark Rutland
2023-05-19 17:18 ` [PATCH v5 16/18] watchdog/perf: Adapt the watchdog_perf interface for async model Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18 ` [PATCH v5 17/18] arm64: add hw_nmi_get_sample_period for preparation of lockup detector Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson
2023-05-19 17:18   ` Douglas Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230519101840.v5.3.I6a729209a1320e0ad212176e250ff945b8f91b2a@changeid \
    --to=dianders@chromium.org \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=daniel.thompson@linaro.org \
    --cc=davem@davemloft.net \
    --cc=eranian@google.com \
    --cc=groeck@chromium.org \
    --cc=irogers@google.com \
    --cc=ito-yuichi@fujitsu.com \
    --cc=kernelfans@gmail.com \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=lecopzer.chen@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=mka@chromium.org \
    --cc=mpe@ellerman.id.au \
    --cc=msys.mizuma@gmail.com \
    --cc=npiggin@gmail.com \
    --cc=pmladek@suse.com \
    --cc=ravi.v.shankar@intel.com \
    --cc=rdunlap@infradead.org \
    --cc=ricardo.neri@intel.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=sumit.garg@linaro.org \
    --cc=swboyd@chromium.org \
    --cc=tzungbi@chromium.org \
    --cc=wens@csie.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.