All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
To: Stefan Hajnoczi <stefanha@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Bobby Eshleman <bobby.eshleman@bytedance.com>
Cc: <kvm@vger.kernel.org>,
	<virtualization@lists.linux-foundation.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel@sberdevices.ru>, <oxffffaa@gmail.com>,
	<avkrasnov@sberdevices.ru>,
	Arseniy Krasnov <AVKrasnov@sberdevices.ru>
Subject: [RFC PATCH v3 14/17] docs: net: description of MSG_ZEROCOPY for AF_VSOCK
Date: Mon, 22 May 2023 10:39:47 +0300	[thread overview]
Message-ID: <20230522073950.3574171-15-AVKrasnov@sberdevices.ru> (raw)
In-Reply-To: <20230522073950.3574171-1-AVKrasnov@sberdevices.ru>

This adds description of MSG_ZEROCOPY flag support for AF_VSOCK type of
socket.

Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
---
 Documentation/networking/msg_zerocopy.rst | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/Documentation/networking/msg_zerocopy.rst b/Documentation/networking/msg_zerocopy.rst
index b3ea96af9b49..34bc7ff411ce 100644
--- a/Documentation/networking/msg_zerocopy.rst
+++ b/Documentation/networking/msg_zerocopy.rst
@@ -7,7 +7,8 @@ Intro
 =====
 
 The MSG_ZEROCOPY flag enables copy avoidance for socket send calls.
-The feature is currently implemented for TCP and UDP sockets.
+The feature is currently implemented for TCP, UDP and VSOCK (with
+virtio transport) sockets.
 
 
 Opportunity and Caveats
@@ -174,7 +175,7 @@ read_notification() call in the previous snippet. A notification
 is encoded in the standard error format, sock_extended_err.
 
 The level and type fields in the control data are protocol family
-specific, IP_RECVERR or IPV6_RECVERR.
+specific, IP_RECVERR or IPV6_RECVERR (for TCP or UDP socket).
 
 Error origin is the new type SO_EE_ORIGIN_ZEROCOPY. ee_errno is zero,
 as explained before, to avoid blocking read and write system calls on
@@ -201,6 +202,7 @@ undefined, bar for ee_code, as discussed below.
 
 	printf("completed: %u..%u\n", serr->ee_info, serr->ee_data);
 
+For VSOCK socket, cmsg_level will be SOL_VSOCK and cmsg_type will be 0.
 
 Deferred copies
 ~~~~~~~~~~~~~~~
@@ -235,12 +237,15 @@ Implementation
 Loopback
 --------
 
+For TCP and UDP:
 Data sent to local sockets can be queued indefinitely if the receive
 process does not read its socket. Unbound notification latency is not
 acceptable. For this reason all packets generated with MSG_ZEROCOPY
 that are looped to a local socket will incur a deferred copy. This
 includes looping onto packet sockets (e.g., tcpdump) and tun devices.
 
+For VSOCK:
+Data path sent to local sockets is the same as for non-local sockets.
 
 Testing
 =======
@@ -254,3 +259,6 @@ instance when run with msg_zerocopy.sh between a veth pair across
 namespaces, the test will not show any improvement. For testing, the
 loopback restriction can be temporarily relaxed by making
 skb_orphan_frags_rx identical to skb_orphan_frags.
+
+For VSOCK type of socket example can be found in  tools/testing/vsock/
+vsock_test_zerocopy.c.
-- 
2.25.1


  parent reply	other threads:[~2023-05-22  7:46 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-22  7:39 [RFC PATCH v3 00/17] vsock: MSG_ZEROCOPY flag support Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 01/17] vsock/virtio: read data from non-linear skb Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 02/17] vhost/vsock: " Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 03/17] vsock/virtio: support to send " Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 04/17] vsock/virtio: non-linear skb handling for tap Arseniy Krasnov
2023-05-22 13:13   ` Simon Horman
2023-05-22 13:15     ` Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 05/17] vsock/virtio: MSG_ZEROCOPY flag support Arseniy Krasnov
2023-05-22 13:11   ` Simon Horman
2023-05-22 13:09     ` Arseniy Krasnov
2023-05-23  5:46       ` Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 06/17] vsock: check error queue to set EPOLLERR Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 07/17] vsock: read from socket's error queue Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 08/17] vsock: check for MSG_ZEROCOPY support Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 09/17] vsock: enable SOCK_SUPPORT_ZC bit Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 10/17] vhost/vsock: support MSG_ZEROCOPY for transport Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 11/17] vsock/virtio: " Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 12/17] vsock/loopback: " Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 13/17] net/sock: enable setting SO_ZEROCOPY for PF_VSOCK Arseniy Krasnov
2023-05-22  7:39 ` Arseniy Krasnov [this message]
2023-05-22  7:39 ` [RFC PATCH v3 15/17] test/vsock: MSG_ZEROCOPY flag tests Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 16/17] test/vsock: MSG_ZEROCOPY support for vsock_perf Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 17/17] test/vsock: io_uring rx/tx tests Arseniy Krasnov
2023-05-25 15:56 ` [RFC PATCH v3 00/17] vsock: MSG_ZEROCOPY flag support Arseniy Krasnov
2023-05-26 10:30   ` Stefano Garzarella
2023-05-26 10:30     ` Stefano Garzarella
2023-05-26 11:36     ` Arseniy Krasnov
2023-05-26 12:23       ` Stefano Garzarella
2023-05-26 12:23         ` Stefano Garzarella
2023-05-26 12:28         ` Arseniy Krasnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230522073950.3574171-15-AVKrasnov@sberdevices.ru \
    --to=avkrasnov@sberdevices.ru \
    --cc=bobby.eshleman@bytedance.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jasowang@redhat.com \
    --cc=kernel@sberdevices.ru \
    --cc=kuba@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=oxffffaa@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=sgarzare@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.