All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
To: Stefan Hajnoczi <stefanha@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Bobby Eshleman <bobby.eshleman@bytedance.com>
Cc: <kvm@vger.kernel.org>,
	<virtualization@lists.linux-foundation.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel@sberdevices.ru>, <oxffffaa@gmail.com>,
	<avkrasnov@sberdevices.ru>,
	Arseniy Krasnov <AVKrasnov@sberdevices.ru>
Subject: [RFC PATCH v3 08/17] vsock: check for MSG_ZEROCOPY support
Date: Mon, 22 May 2023 10:39:41 +0300	[thread overview]
Message-ID: <20230522073950.3574171-9-AVKrasnov@sberdevices.ru> (raw)
In-Reply-To: <20230522073950.3574171-1-AVKrasnov@sberdevices.ru>

This feature totally depends on transport, so if transport doesn't
support it, return error.

Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
---
 include/net/af_vsock.h   | 7 +++++++
 net/vmw_vsock/af_vsock.c | 6 ++++++
 2 files changed, 13 insertions(+)

diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h
index 0e7504a42925..ec09edc5f3a0 100644
--- a/include/net/af_vsock.h
+++ b/include/net/af_vsock.h
@@ -177,6 +177,9 @@ struct vsock_transport {
 
 	/* Read a single skb */
 	int (*read_skb)(struct vsock_sock *, skb_read_actor_t);
+
+	/* Zero-copy. */
+	bool (*msgzerocopy_allow)(void);
 };
 
 /**** CORE ****/
@@ -243,4 +246,8 @@ static inline void __init vsock_bpf_build_proto(void)
 {}
 #endif
 
+static inline bool vsock_msgzerocopy_allow(const struct vsock_transport *t)
+{
+	return t->msgzerocopy_allow && t->msgzerocopy_allow();
+}
 #endif /* __AF_VSOCK_H__ */
diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
index b2da791d920b..dbfe82ee7769 100644
--- a/net/vmw_vsock/af_vsock.c
+++ b/net/vmw_vsock/af_vsock.c
@@ -1824,6 +1824,12 @@ static int vsock_connectible_sendmsg(struct socket *sock, struct msghdr *msg,
 		goto out;
 	}
 
+	if (msg->msg_flags & MSG_ZEROCOPY &&
+	    !vsock_msgzerocopy_allow(transport)) {
+		err = -EOPNOTSUPP;
+		goto out;
+	}
+
 	/* Wait for room in the produce queue to enqueue our user's data. */
 	timeout = sock_sndtimeo(sk, msg->msg_flags & MSG_DONTWAIT);
 
-- 
2.25.1


  parent reply	other threads:[~2023-05-22  7:45 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-22  7:39 [RFC PATCH v3 00/17] vsock: MSG_ZEROCOPY flag support Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 01/17] vsock/virtio: read data from non-linear skb Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 02/17] vhost/vsock: " Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 03/17] vsock/virtio: support to send " Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 04/17] vsock/virtio: non-linear skb handling for tap Arseniy Krasnov
2023-05-22 13:13   ` Simon Horman
2023-05-22 13:15     ` Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 05/17] vsock/virtio: MSG_ZEROCOPY flag support Arseniy Krasnov
2023-05-22 13:11   ` Simon Horman
2023-05-22 13:09     ` Arseniy Krasnov
2023-05-23  5:46       ` Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 06/17] vsock: check error queue to set EPOLLERR Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 07/17] vsock: read from socket's error queue Arseniy Krasnov
2023-05-22  7:39 ` Arseniy Krasnov [this message]
2023-05-22  7:39 ` [RFC PATCH v3 09/17] vsock: enable SOCK_SUPPORT_ZC bit Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 10/17] vhost/vsock: support MSG_ZEROCOPY for transport Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 11/17] vsock/virtio: " Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 12/17] vsock/loopback: " Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 13/17] net/sock: enable setting SO_ZEROCOPY for PF_VSOCK Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 14/17] docs: net: description of MSG_ZEROCOPY for AF_VSOCK Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 15/17] test/vsock: MSG_ZEROCOPY flag tests Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 16/17] test/vsock: MSG_ZEROCOPY support for vsock_perf Arseniy Krasnov
2023-05-22  7:39 ` [RFC PATCH v3 17/17] test/vsock: io_uring rx/tx tests Arseniy Krasnov
2023-05-25 15:56 ` [RFC PATCH v3 00/17] vsock: MSG_ZEROCOPY flag support Arseniy Krasnov
2023-05-26 10:30   ` Stefano Garzarella
2023-05-26 10:30     ` Stefano Garzarella
2023-05-26 11:36     ` Arseniy Krasnov
2023-05-26 12:23       ` Stefano Garzarella
2023-05-26 12:23         ` Stefano Garzarella
2023-05-26 12:28         ` Arseniy Krasnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230522073950.3574171-9-AVKrasnov@sberdevices.ru \
    --to=avkrasnov@sberdevices.ru \
    --cc=bobby.eshleman@bytedance.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jasowang@redhat.com \
    --cc=kernel@sberdevices.ru \
    --cc=kuba@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=oxffffaa@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=sgarzare@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.