From: Klaus Jensen <its@irrelevant.dk>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Klaus Jensen <its@irrelevant.dk>,
Keith Busch <kbusch@kernel.org>,
Jesper Devantier <j.devantier@samsung.com>,
Klaus Jensen <k.jensen@samsung.com>
Subject: [PATCH 2/4] hw/nvme: verify uniqueness of reclaim unit handle identifiers
Date: Wed, 24 May 2023 13:19:02 +0200 [thread overview]
Message-ID: <20230524111904.91179-3-its@irrelevant.dk> (raw)
In-Reply-To: <20230524111904.91179-1-its@irrelevant.dk>
From: Klaus Jensen <k.jensen@samsung.com>
Verify that a reclaim unit handle identifier is only specified once in
fdp.ruhs.
Fixes: 73064edfb864 ("hw/nvme: flexible data placement emulation")
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
hw/nvme/ns.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/hw/nvme/ns.c b/hw/nvme/ns.c
index 050fdaf50fcd..c4ea2033bb1c 100644
--- a/hw/nvme/ns.c
+++ b/hw/nvme/ns.c
@@ -453,6 +453,17 @@ static bool nvme_ns_init_fdp(NvmeNamespace *ns, Error **errp)
free(r);
+ /* verify that the ruhids are unique */
+ for (unsigned int i = 0; i < ns->fdp.nphs; i++) {
+ for (unsigned int j = i + 1; j < ns->fdp.nphs; j++) {
+ if (ruhids[i] == ruhids[j]) {
+ error_setg(errp, "duplicate reclaim unit handle identifier: %u",
+ ruhids[i]);
+ return false;
+ }
+ }
+ }
+
ph = ns->fdp.phs = g_new(uint16_t, ns->fdp.nphs);
ruhid = ruhids;
--
2.40.0
next prev parent reply other threads:[~2023-05-24 11:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 11:19 [PATCH 0/4] hw/nvme: tp4146 misc Klaus Jensen
2023-05-24 11:19 ` [PATCH 1/4] hw/nvme: fix verification of number of ruhis Klaus Jensen
2023-05-24 11:19 ` Klaus Jensen [this message]
2023-05-24 11:19 ` [PATCH 3/4] hw/nvme: add placement handle list ranges Klaus Jensen
2023-05-24 11:19 ` [PATCH 4/4] docs: update hw/nvme documentation for TP4146 Klaus Jensen
[not found] ` <CGME20230609083911eucas1p19c8484fdbfc404bdab8bec9ffe903153@eucas1p1.samsung.com>
2023-06-09 8:39 ` [PATCH 0/4] hw/nvme: tp4146 misc Jesper Devantier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524111904.91179-3-its@irrelevant.dk \
--to=its@irrelevant.dk \
--cc=j.devantier@samsung.com \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.