From: Adam Ford <aford173@gmail.com> To: dri-devel@lists.freedesktop.org Cc: Neil Armstrong <neil.armstrong@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Robert Foss <rfoss@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Jonas Karlman <jonas@kwiboo.se>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, aford@beaconembedded.com, Jernej Skrabec <jernej.skrabec@gmail.com>, Frieder Schrempf <frieder.schrempf@kontron.de>, devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Jagan Teki <jagan@amarulasolutions.com>, Andrzej Hajda <andrzej.hajda@intel.com>, Adam Ford <aford173@gmail.com>, linux-kernel@vger.kernel.org, Marek Szyprowski <m.szyprowski@samsung.com> Subject: [PATCH V8 7/7] dt-bindings: bridge: samsung-dsim: Make some flags optional Date: Thu, 25 May 2023 22:05:59 -0500 [thread overview] Message-ID: <20230526030559.326566-8-aford173@gmail.com> (raw) In-Reply-To: <20230526030559.326566-1-aford173@gmail.com> In the event a device is connected to the samsung-dsim controller that doesn't support the burst-clock, the driver is able to get the requested pixel clock from the attached device or bridge. In these instances, the samsung,burst-clock-frequency isn't needed, so remove it from the required list. The pll-clock frequency can be set by the device tree entry for samsung,pll-clock-frequency, but in some cases, the pll-clock may have the same clock rate as sclk_mipi clock. If they are equal, this flag is not needed since the driver will use the sclk_mipi rate as a fallback. Signed-off-by: Adam Ford <aford173@gmail.com> --- .../bindings/display/bridge/samsung,mipi-dsim.yaml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml index 9f61ebdfefa8..360fea81f4b6 100644 --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml @@ -70,7 +70,9 @@ properties: samsung,burst-clock-frequency: $ref: /schemas/types.yaml#/definitions/uint32 description: - DSIM high speed burst mode frequency. + DSIM high speed burst mode frequency when connected to devices + that support burst mode. If absent, the driver will use the pixel + clock from the attached device or bridge. samsung,esc-clock-frequency: $ref: /schemas/types.yaml#/definitions/uint32 @@ -80,7 +82,8 @@ properties: samsung,pll-clock-frequency: $ref: /schemas/types.yaml#/definitions/uint32 description: - DSIM oscillator clock frequency. + DSIM oscillator clock frequency. If absent, the driver will + use the clock frequency of sclk_mipi. phys: maxItems: 1 @@ -134,9 +137,7 @@ required: - compatible - interrupts - reg - - samsung,burst-clock-frequency - samsung,esc-clock-frequency - - samsung,pll-clock-frequency allOf: - $ref: ../dsi-controller.yaml# -- 2.39.2
WARNING: multiple messages have this Message-ID (diff)
From: Adam Ford <aford173@gmail.com> To: dri-devel@lists.freedesktop.org Cc: aford@beaconembedded.com, Adam Ford <aford173@gmail.com>, Inki Dae <inki.dae@samsung.com>, Jagan Teki <jagan@amarulasolutions.com>, Marek Szyprowski <m.szyprowski@samsung.com>, Andrzej Hajda <andrzej.hajda@intel.com>, Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Frieder Schrempf <frieder.schrempf@kontron.de>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V8 7/7] dt-bindings: bridge: samsung-dsim: Make some flags optional Date: Thu, 25 May 2023 22:05:59 -0500 [thread overview] Message-ID: <20230526030559.326566-8-aford173@gmail.com> (raw) In-Reply-To: <20230526030559.326566-1-aford173@gmail.com> In the event a device is connected to the samsung-dsim controller that doesn't support the burst-clock, the driver is able to get the requested pixel clock from the attached device or bridge. In these instances, the samsung,burst-clock-frequency isn't needed, so remove it from the required list. The pll-clock frequency can be set by the device tree entry for samsung,pll-clock-frequency, but in some cases, the pll-clock may have the same clock rate as sclk_mipi clock. If they are equal, this flag is not needed since the driver will use the sclk_mipi rate as a fallback. Signed-off-by: Adam Ford <aford173@gmail.com> --- .../bindings/display/bridge/samsung,mipi-dsim.yaml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml index 9f61ebdfefa8..360fea81f4b6 100644 --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml @@ -70,7 +70,9 @@ properties: samsung,burst-clock-frequency: $ref: /schemas/types.yaml#/definitions/uint32 description: - DSIM high speed burst mode frequency. + DSIM high speed burst mode frequency when connected to devices + that support burst mode. If absent, the driver will use the pixel + clock from the attached device or bridge. samsung,esc-clock-frequency: $ref: /schemas/types.yaml#/definitions/uint32 @@ -80,7 +82,8 @@ properties: samsung,pll-clock-frequency: $ref: /schemas/types.yaml#/definitions/uint32 description: - DSIM oscillator clock frequency. + DSIM oscillator clock frequency. If absent, the driver will + use the clock frequency of sclk_mipi. phys: maxItems: 1 @@ -134,9 +137,7 @@ required: - compatible - interrupts - reg - - samsung,burst-clock-frequency - samsung,esc-clock-frequency - - samsung,pll-clock-frequency allOf: - $ref: ../dsi-controller.yaml# -- 2.39.2
next prev parent reply other threads:[~2023-05-26 3:06 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-26 3:05 [PATCH V8 0/7] drm: bridge: samsung-dsim: Support variable clocking Adam Ford 2023-05-26 3:05 ` Adam Ford 2023-05-26 3:05 ` [PATCH V8 1/7] drm: bridge: samsung-dsim: fix blanking packet size calculation Adam Ford 2023-05-26 3:05 ` Adam Ford 2023-05-26 3:05 ` [PATCH V8 2/7] drm: bridge: samsung-dsim: Fix PMS Calculator on imx8m[mnp] Adam Ford 2023-05-26 3:05 ` Adam Ford 2023-05-26 3:05 ` [PATCH V8 3/7] drm: bridge: samsung-dsim: Fetch pll-clock-frequency automatically Adam Ford 2023-05-26 3:05 ` Adam Ford 2023-05-26 3:05 ` [PATCH V8 4/7] drm: bridge: samsung-dsim: Select GENERIC_PHY_MIPI_DPHY Adam Ford 2023-05-26 3:05 ` Adam Ford 2023-05-26 3:05 ` [PATCH V8 5/7] drm: bridge: samsung-dsim: Dynamically configure DPHY timing Adam Ford 2023-05-26 3:05 ` Adam Ford 2023-05-26 3:05 ` [PATCH V8 6/7] drm: bridge: samsung-dsim: Support non-burst mode Adam Ford 2023-05-26 3:05 ` Adam Ford 2023-05-26 3:05 ` Adam Ford [this message] 2023-05-26 3:05 ` [PATCH V8 7/7] dt-bindings: bridge: samsung-dsim: Make some flags optional Adam Ford 2023-05-26 18:19 ` Conor Dooley 2023-05-26 18:19 ` Conor Dooley 2023-05-26 19:24 ` Adam Ford 2023-05-26 19:24 ` Adam Ford 2023-05-26 19:30 ` Conor Dooley 2023-05-26 19:30 ` Conor Dooley 2023-05-30 7:48 ` Krzysztof Kozlowski 2023-05-30 7:48 ` Krzysztof Kozlowski 2023-05-26 7:22 ` [PATCH V8 0/7] drm: bridge: samsung-dsim: Support variable clocking Neil Armstrong 2023-05-26 7:22 ` Neil Armstrong 2023-05-26 7:24 ` Neil Armstrong 2023-05-26 7:24 ` Neil Armstrong 2023-05-26 14:04 ` Adam Ford 2023-05-26 14:04 ` Adam Ford 2023-05-30 8:01 ` Neil Armstrong 2023-05-30 8:01 ` Neil Armstrong 2023-06-07 13:15 ` Rasmus Villemoes 2023-06-07 13:15 ` Rasmus Villemoes 2023-06-07 13:27 ` Adam Ford 2023-06-07 13:27 ` Adam Ford 2023-06-07 14:23 ` Adam Ford 2023-06-07 14:23 ` Adam Ford 2023-06-08 11:40 ` Rasmus Villemoes 2023-06-08 11:40 ` Rasmus Villemoes 2023-06-08 12:30 ` Adam Ford 2023-06-08 12:30 ` Adam Ford 2023-06-08 12:52 ` Lucas Stach 2023-06-08 12:52 ` Lucas Stach
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230526030559.326566-8-aford173@gmail.com \ --to=aford173@gmail.com \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=aford@beaconembedded.com \ --cc=andrzej.hajda@intel.com \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=frieder.schrempf@kontron.de \ --cc=jagan@amarulasolutions.com \ --cc=jernej.skrabec@gmail.com \ --cc=jonas@kwiboo.se \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=neil.armstrong@linaro.org \ --cc=rfoss@kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.