From: Steven Rostedt <rostedt@goodmis.org>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: [PATCH] libtracefs/utest: Do not use synth for test_synth element
Date: Tue, 30 May 2023 02:21:11 -0400 [thread overview]
Message-ID: <20230530022111.25bd25de@rorschach.local.home> (raw)
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
The test_synth_compare() function is confusing as it uses "synth" for the
test_synth structure. "synth" should only be used for tracefs_synth
descriptors. Rename it to "sevents" to match the variable of the calling
function.
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
utest/tracefs-utest.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/utest/tracefs-utest.c b/utest/tracefs-utest.c
index 9cfafdbd039c..0f4075679ec4 100644
--- a/utest/tracefs-utest.c
+++ b/utest/tracefs-utest.c
@@ -983,7 +983,7 @@ struct test_synth {
char *match_name;
};
-static void test_synth_compare(struct test_synth *synth, struct tracefs_dynevent **devents)
+static void test_synth_compare(struct test_synth *sevents, struct tracefs_dynevent **devents)
{
enum tracefs_dynevent_type stype;
char *format;
@@ -996,9 +996,9 @@ static void test_synth_compare(struct test_synth *synth, struct tracefs_dynevent
CU_TEST(stype == TRACEFS_DYNEVENT_SYNTH);
if (stype != TRACEFS_DYNEVENT_SYNTH)
continue;
- CU_TEST(event && synth[i].name && strcmp(event, synth[i].name) == 0);
- if (synth[i].match_name) {
- CU_TEST(strstr(format, synth[i].match_name) != NULL);
+ CU_TEST(event && sevents[i].name && strcmp(event, sevents[i].name) == 0);
+ if (sevents[i].match_name) {
+ CU_TEST(strstr(format, sevents[i].match_name) != NULL);
}
free(event);
free(format);
--
2.39.2
reply other threads:[~2023-05-30 6:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530022111.25bd25de@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.