From: Claudiu Beznea <claudiu.beznea@microchip.com> To: <mturquette@baylibre.com>, <sboyd@kernel.org>, <luca.ceresoli@bootlin.com>, <nm@ti.com>, <kristo@kernel.org>, <ssantosh@kernel.org>, <michal.simek@xilinx.com> Cc: <aford173@gmail.com>, <mike.looijmans@topic.nl>, <robert.hancock@calian.com>, <shawn.guo@linaro.org>, <fabio.estevam@freescale.com>, <linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-omap@vger.kernel.org>, Claudiu Beznea <claudiu.beznea@microchip.com> Subject: [PATCH 2/8] clk: cdce925: check return value of kasprintf() Date: Tue, 30 May 2023 12:39:07 +0300 [thread overview] Message-ID: <20230530093913.1656095-3-claudiu.beznea@microchip.com> (raw) In-Reply-To: <20230530093913.1656095-1-claudiu.beznea@microchip.com> kasprintf() returns a pointer to dynamically allocated memory. Pointer could be NULL in case allocation fails. Check pointer validity. Identified with coccinelle (kmerr.cocci script). Fixes: 19fbbbbcd3a3 ("Add TI CDCE925 I2C controlled clock synthesizer driver") Depends-on: e665f029a283 ("clk: Convert to using %pOFn instead of device_node.name") Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> --- drivers/clk/clk-cdce925.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/clk/clk-cdce925.c b/drivers/clk/clk-cdce925.c index 6350682f7e6d..87890669297d 100644 --- a/drivers/clk/clk-cdce925.c +++ b/drivers/clk/clk-cdce925.c @@ -701,6 +701,10 @@ static int cdce925_probe(struct i2c_client *client) for (i = 0; i < data->chip_info->num_plls; ++i) { pll_clk_name[i] = kasprintf(GFP_KERNEL, "%pOFn.pll%d", client->dev.of_node, i); + if (!pll_clk_name[i]) { + err = -ENOMEM; + goto error; + } init.name = pll_clk_name[i]; data->pll[i].chip = data; data->pll[i].hw.init = &init; @@ -742,6 +746,10 @@ static int cdce925_probe(struct i2c_client *client) init.num_parents = 1; init.parent_names = &parent_name; /* Mux Y1 to input */ init.name = kasprintf(GFP_KERNEL, "%pOFn.Y1", client->dev.of_node); + if (!init.name) { + err = -ENOMEM; + goto error; + } data->clk[0].chip = data; data->clk[0].hw.init = &init; data->clk[0].index = 0; @@ -760,6 +768,10 @@ static int cdce925_probe(struct i2c_client *client) for (i = 1; i < data->chip_info->num_outputs; ++i) { init.name = kasprintf(GFP_KERNEL, "%pOFn.Y%d", client->dev.of_node, i+1); + if (!init.name) { + err = -ENOMEM; + goto error; + } data->clk[i].chip = data; data->clk[i].hw.init = &init; data->clk[i].index = i; -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Claudiu Beznea <claudiu.beznea@microchip.com> To: <mturquette@baylibre.com>, <sboyd@kernel.org>, <luca.ceresoli@bootlin.com>, <nm@ti.com>, <kristo@kernel.org>, <ssantosh@kernel.org>, <michal.simek@xilinx.com> Cc: <aford173@gmail.com>, <mike.looijmans@topic.nl>, <robert.hancock@calian.com>, <shawn.guo@linaro.org>, <fabio.estevam@freescale.com>, <linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-omap@vger.kernel.org>, Claudiu Beznea <claudiu.beznea@microchip.com> Subject: [PATCH 2/8] clk: cdce925: check return value of kasprintf() Date: Tue, 30 May 2023 12:39:07 +0300 [thread overview] Message-ID: <20230530093913.1656095-3-claudiu.beznea@microchip.com> (raw) In-Reply-To: <20230530093913.1656095-1-claudiu.beznea@microchip.com> kasprintf() returns a pointer to dynamically allocated memory. Pointer could be NULL in case allocation fails. Check pointer validity. Identified with coccinelle (kmerr.cocci script). Fixes: 19fbbbbcd3a3 ("Add TI CDCE925 I2C controlled clock synthesizer driver") Depends-on: e665f029a283 ("clk: Convert to using %pOFn instead of device_node.name") Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> --- drivers/clk/clk-cdce925.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/clk/clk-cdce925.c b/drivers/clk/clk-cdce925.c index 6350682f7e6d..87890669297d 100644 --- a/drivers/clk/clk-cdce925.c +++ b/drivers/clk/clk-cdce925.c @@ -701,6 +701,10 @@ static int cdce925_probe(struct i2c_client *client) for (i = 0; i < data->chip_info->num_plls; ++i) { pll_clk_name[i] = kasprintf(GFP_KERNEL, "%pOFn.pll%d", client->dev.of_node, i); + if (!pll_clk_name[i]) { + err = -ENOMEM; + goto error; + } init.name = pll_clk_name[i]; data->pll[i].chip = data; data->pll[i].hw.init = &init; @@ -742,6 +746,10 @@ static int cdce925_probe(struct i2c_client *client) init.num_parents = 1; init.parent_names = &parent_name; /* Mux Y1 to input */ init.name = kasprintf(GFP_KERNEL, "%pOFn.Y1", client->dev.of_node); + if (!init.name) { + err = -ENOMEM; + goto error; + } data->clk[0].chip = data; data->clk[0].hw.init = &init; data->clk[0].index = 0; @@ -760,6 +768,10 @@ static int cdce925_probe(struct i2c_client *client) for (i = 1; i < data->chip_info->num_outputs; ++i) { init.name = kasprintf(GFP_KERNEL, "%pOFn.Y%d", client->dev.of_node, i+1); + if (!init.name) { + err = -ENOMEM; + goto error; + } data->clk[i].chip = data; data->clk[i].hw.init = &init; data->clk[i].index = i; -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-30 9:40 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-30 9:39 [PATCH 0/8] clk: check memory returned by {devm_}kasprintf() Claudiu Beznea 2023-05-30 9:39 ` Claudiu Beznea 2023-05-30 9:39 ` [PATCH 1/8] clk: vc5: check memory returned by kasprintf() Claudiu Beznea 2023-05-30 9:39 ` Claudiu Beznea 2023-05-31 16:32 ` Luca Ceresoli 2023-05-31 16:32 ` Luca Ceresoli 2023-06-20 18:53 ` Stephen Boyd 2023-06-20 18:53 ` Stephen Boyd 2023-05-30 9:39 ` Claudiu Beznea [this message] 2023-05-30 9:39 ` [PATCH 2/8] clk: cdce925: check return value of kasprintf() Claudiu Beznea 2023-06-20 18:54 ` Stephen Boyd 2023-06-20 18:54 ` Stephen Boyd 2023-05-30 9:39 ` [PATCH 3/8] clk: si5341: return error if one synth clock registration fails Claudiu Beznea 2023-05-30 9:39 ` Claudiu Beznea 2023-06-20 18:54 ` Stephen Boyd 2023-06-20 18:54 ` Stephen Boyd 2023-05-30 9:39 ` [PATCH 4/8] clk: si5341: check return value of {devm_}kasprintf() Claudiu Beznea 2023-05-30 9:39 ` Claudiu Beznea 2023-06-20 18:54 ` Stephen Boyd 2023-06-20 18:54 ` Stephen Boyd 2023-05-30 9:39 ` [PATCH 5/8] clk: si5341: free unused memory on probe failure Claudiu Beznea 2023-05-30 9:39 ` Claudiu Beznea 2023-06-20 18:55 ` Stephen Boyd 2023-06-20 18:55 ` Stephen Boyd 2023-05-30 9:39 ` [PATCH 6/8] clk: keystone: sci-clk: check return value of kasprintf() Claudiu Beznea 2023-05-30 9:39 ` Claudiu Beznea 2023-05-31 4:12 ` Tony Lindgren 2023-05-31 4:12 ` Tony Lindgren 2023-06-20 18:55 ` Stephen Boyd 2023-06-20 18:55 ` Stephen Boyd 2023-05-30 9:39 ` [PATCH 7/8] clk: ti: clkctrl: " Claudiu Beznea 2023-05-30 9:39 ` Claudiu Beznea 2023-05-31 4:12 ` Tony Lindgren 2023-05-31 4:12 ` Tony Lindgren 2023-06-20 18:55 ` Stephen Boyd 2023-06-20 18:55 ` Stephen Boyd 2023-05-30 9:39 ` [PATCH 8/8] clk: clocking-wizard: check return value of devm_kasprintf() Claudiu Beznea 2023-05-30 9:39 ` Claudiu Beznea 2023-06-20 18:55 ` Stephen Boyd 2023-06-20 18:55 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230530093913.1656095-3-claudiu.beznea@microchip.com \ --to=claudiu.beznea@microchip.com \ --cc=aford173@gmail.com \ --cc=fabio.estevam@freescale.com \ --cc=kristo@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=luca.ceresoli@bootlin.com \ --cc=michal.simek@xilinx.com \ --cc=mike.looijmans@topic.nl \ --cc=mturquette@baylibre.com \ --cc=nm@ti.com \ --cc=robert.hancock@calian.com \ --cc=sboyd@kernel.org \ --cc=shawn.guo@linaro.org \ --cc=ssantosh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.