All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: laurent@vivier.eu, qemu-devel@nongnu.org
Subject: [PATCH v3 20/23] q800: don't access Nubus bus directly from the mac-nubus-bridge device
Date: Sun,  4 Jun 2023 14:14:47 +0100	[thread overview]
Message-ID: <20230604131450.428797-21-mark.cave-ayland@ilande.co.uk> (raw)
In-Reply-To: <20230604131450.428797-1-mark.cave-ayland@ilande.co.uk>

Instead use the qdev_get_child_bus() function which is intended for this exact
purpose.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
---
 hw/m68k/q800.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c
index 14879310ca..df2765dbd1 100644
--- a/hw/m68k/q800.c
+++ b/hw/m68k/q800.c
@@ -448,7 +448,7 @@ static void q800_machine_init(MachineState *machine)
                           qdev_get_gpio_in_named(DEVICE(&m->via2), "nubus-irq",
                                                  VIA2_NUBUS_IRQ_9));
 
-    nubus = &NUBUS_BRIDGE(dev)->bus;
+    nubus = NUBUS_BUS(qdev_get_child_bus(dev, "nubus-bus.0"));
 
     /* framebuffer in nubus slot #9 */
 
-- 
2.30.2



  parent reply	other threads:[~2023-06-04 13:19 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-04 13:14 [PATCH v3 00/23] q800: add support for booting MacOS Classic - part 1 Mark Cave-Ayland
2023-06-04 13:14 ` [PATCH v3 01/23] q800: fix up minor spacing issues in hw_compat_q800 GlobalProperty array Mark Cave-Ayland
2023-06-04 13:14 ` [PATCH v3 02/23] q800: add missing space after parent object in GLUEState Mark Cave-Ayland
2023-06-04 13:14 ` [PATCH v3 03/23] q800: introduce Q800MachineState Mark Cave-Ayland
2023-06-04 13:14 ` [PATCH v3 04/23] q800: rename q800_init() to q800_machine_init() Mark Cave-Ayland
2023-06-04 13:14 ` [PATCH v3 05/23] q800: move CPU object into Q800MachineState Mark Cave-Ayland
2023-06-04 16:16   ` Laurent Vivier
2023-06-05 12:33   ` Philippe Mathieu-Daudé
2023-06-04 13:14 ` [PATCH v3 06/23] q800: move ROM memory region to Q800MachineState Mark Cave-Ayland
2023-06-04 13:14 ` [PATCH v3 07/23] q800: move GLUE device into separate q800-glue.c file Mark Cave-Ayland
2023-06-05 12:41   ` Philippe Mathieu-Daudé
2023-06-19 12:26     ` Mark Cave-Ayland
2023-06-04 13:14 ` [PATCH v3 08/23] q800: move GLUE device to Q800MachineState Mark Cave-Ayland
2023-06-04 13:14 ` [PATCH v3 09/23] q800: introduce mac-io container memory region Mark Cave-Ayland
2023-06-05 12:49   ` Philippe Mathieu-Daudé
2023-06-04 13:14 ` [PATCH v3 10/23] q800: reimplement mac-io region aliasing using IO " Mark Cave-Ayland
2023-06-05 12:43   ` Philippe Mathieu-Daudé
2023-06-06  6:33     ` Mark Cave-Ayland
2023-06-06 12:40       ` Philippe Mathieu-Daudé
2023-06-05 12:48   ` Philippe Mathieu-Daudé
2023-06-04 13:14 ` [PATCH v3 11/23] q800: move VIA1 device to Q800MachineState Mark Cave-Ayland
2023-06-04 13:14 ` [PATCH v3 12/23] q800: move VIA2 " Mark Cave-Ayland
2023-06-04 13:14 ` [PATCH v3 13/23] hw/net/dp8393x.c: move TYPE_DP8393X and dp8393xState into dp8393x.h Mark Cave-Ayland
2023-06-04 16:17   ` Laurent Vivier
2023-06-05  0:36     ` Jason Wang
2023-06-05 12:44   ` Philippe Mathieu-Daudé
2023-06-04 13:14 ` [PATCH v3 14/23] q800: move dp8393x device to Q800MachineState Mark Cave-Ayland
2023-06-04 13:14 ` [PATCH v3 15/23] q800: move ESCC " Mark Cave-Ayland
2023-06-04 13:14 ` [PATCH v3 16/23] q800: move escc_orgate " Mark Cave-Ayland
2023-06-04 13:14 ` [PATCH v3 17/23] q800: move ESP " Mark Cave-Ayland
2023-06-04 13:14 ` [PATCH v3 18/23] q800: move SWIM " Mark Cave-Ayland
2023-06-04 13:14 ` [PATCH v3 19/23] q800: move mac-nubus-bridge " Mark Cave-Ayland
2023-06-04 16:29   ` Laurent Vivier
2023-06-05  5:43     ` Mark Cave-Ayland
2023-06-05 12:47   ` Philippe Mathieu-Daudé
2023-06-04 13:14 ` Mark Cave-Ayland [this message]
2023-06-05 12:46   ` [PATCH v3 20/23] q800: don't access Nubus bus directly from the mac-nubus-bridge device Philippe Mathieu-Daudé
2023-06-04 13:14 ` [PATCH v3 21/23] q800: move macfb device to Q800MachineState Mark Cave-Ayland
2023-06-04 13:14 ` [PATCH v3 22/23] mac_via: fix rtc command decoding from PRAM addresses 0x0 to 0xf Mark Cave-Ayland
2023-06-04 13:14 ` [PATCH v3 23/23] mac_via: fix rtc command decoding for the PRAM seconds registers Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230604131450.428797-21-mark.cave-ayland@ilande.co.uk \
    --to=mark.cave-ayland@ilande.co.uk \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.