All of lore.kernel.org
 help / color / mirror / Atom feed
From: Utkarsh Patel <utkarsh.h.patel@intel.com>
To: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	heikki.krogerus@linux.intel.com, pmalani@chromium.org,
	bleung@chromium.org
Cc: Utkarsh Patel <utkarsh.h.patel@intel.com>
Subject: [PATCH 1/2] platform/chrome: cros_ec_typec: Configure Retimer cable type
Date: Sun,  4 Jun 2023 18:01:16 -0700	[thread overview]
Message-ID: <20230605010117.794691-2-utkarsh.h.patel@intel.com> (raw)
In-Reply-To: <20230605010117.794691-1-utkarsh.h.patel@intel.com>

Connector class driver only configure cable type active or passive.
With this change it will also configure if the cable type is retimer or
redriver if required by AP. This details will be provided by Chrome EC
as a part of cable discover mode VDO.

This change also brings in corresponding EC header updates from the EC
code base [1].

[1]:
https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/master/include/ec_commands.h

Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>
---
 drivers/platform/chrome/cros_ec_typec.c        | 8 +++++++-
 include/linux/platform_data/cros_ec_commands.h | 2 ++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index a673c3342470..9c18b1df64a7 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -448,6 +448,9 @@ static int cros_typec_enable_tbt(struct cros_typec_data *typec,
 	if (pd_ctrl->control_flags & USB_PD_CTRL_ACTIVE_CABLE)
 		data.enter_vdo |= TBT_ENTER_MODE_ACTIVE_CABLE;
 
+	if (pd_ctrl->control_flags & USB_PD_CTRL_RETIMER_CABLE)
+		data.enter_vdo |= TBT_CABLE_RETIMER;
+
 	if (!port->state.alt) {
 		port->state.alt = port->port_altmode[CROS_EC_ALTMODE_TBT];
 		ret = cros_typec_usb_safe_state(port);
@@ -522,8 +525,11 @@ static int cros_typec_enable_usb4(struct cros_typec_data *typec,
 	/* Cable Type */
 	if (pd_ctrl->control_flags & USB_PD_CTRL_OPTICAL_CABLE)
 		data.eudo |= EUDO_CABLE_TYPE_OPTICAL << EUDO_CABLE_TYPE_SHIFT;
-	else if (pd_ctrl->control_flags & USB_PD_CTRL_ACTIVE_CABLE)
+	else if (pd_ctrl->control_flags & USB_PD_CTRL_RETIMER_CABLE)
 		data.eudo |= EUDO_CABLE_TYPE_RE_TIMER << EUDO_CABLE_TYPE_SHIFT;
+	else if (!(pd_ctrl->control_flags & USB_PD_CTRL_RETIMER_CABLE) &&
+		  (pd_ctrl->control_flags & USB_PD_CTRL_ACTIVE_CABLE))
+		data.eudo |= EUDO_CABLE_TYPE_RE_DRIVER << EUDO_CABLE_TYPE_SHIFT;
 
 	data.active_link_training = !!(pd_ctrl->control_flags &
 				       USB_PD_CTRL_ACTIVE_LINK_UNIDIR);
diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h
index ab721cf13a98..c9aa5495c666 100644
--- a/include/linux/platform_data/cros_ec_commands.h
+++ b/include/linux/platform_data/cros_ec_commands.h
@@ -4963,6 +4963,8 @@ struct ec_response_usb_pd_control_v1 {
 #define USB_PD_CTRL_TBT_LEGACY_ADAPTER  BIT(2)
 /* Active Link Uni-Direction */
 #define USB_PD_CTRL_ACTIVE_LINK_UNIDIR  BIT(3)
+/* Retimer/Redriver cable */
+#define USB_PD_CTRL_RETIMER_CABLE BIT(4)
 
 struct ec_response_usb_pd_control_v2 {
 	uint8_t enabled;
-- 
2.25.1


  reply	other threads:[~2023-06-05  1:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05  1:01 [PATCH 0/2] Add support to configure active retimer cable Utkarsh Patel
2023-06-05  1:01 ` Utkarsh Patel [this message]
2023-06-15 17:28   ` [PATCH 1/2] platform/chrome: cros_ec_typec: Configure Retimer cable type Prashant Malani
2023-06-16 21:57     ` Patel, Utkarsh H
2023-06-16 22:05       ` Prashant Malani
2023-06-22 17:40         ` Patel, Utkarsh H
2023-06-22 17:48           ` Prashant Malani
2023-06-05  1:01 ` [PATCH 2/2] usb: typec: intel_pmc_mux: Configure Active and Retimer Cable type Utkarsh Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230605010117.794691-2-utkarsh.h.patel@intel.com \
    --to=utkarsh.h.patel@intel.com \
    --cc=bleung@chromium.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pmalani@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.