From: Arnd Bergmann <arnd@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Yingkun Meng <mengyingkun@loongson.cn>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/4] ASoC: loongson: add PCI dependency
Date: Fri, 16 Jun 2023 11:00:39 +0200 [thread overview]
Message-ID: <20230616090156.2347850-3-arnd@kernel.org> (raw)
In-Reply-To: <20230616090156.2347850-1-arnd@kernel.org>
From: Arnd Bergmann <arnd@arndb.de>
The new driver fails to build when PCI is disabled:
WARNING: unmet direct dependencies detected for SND_SOC_LOONGSON_I2S_PCI
Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && (LOONGARCH || COMPILE_TEST [=y]) && PCI [=n]
Selected by [y]:
- SND_SOC_LOONGSON_CARD [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && (LOONGARCH || COMPILE_TEST [=y])
sound/soc/loongson/loongson_i2s_pci.c:167:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
module_pci_driver(loongson_i2s_driver);
Add the appropriate Kconfig dependency.
Fixes: d24028606e764 ("ASoC: loongson: Add Loongson ASoC Sound Card Support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
sound/soc/loongson/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/loongson/Kconfig b/sound/soc/loongson/Kconfig
index c175f9de19a85..b8d7e2bade246 100644
--- a/sound/soc/loongson/Kconfig
+++ b/sound/soc/loongson/Kconfig
@@ -16,6 +16,7 @@ config SND_SOC_LOONGSON_I2S_PCI
config SND_SOC_LOONGSON_CARD
tristate "Loongson Sound Card Driver"
select SND_SOC_LOONGSON_I2S_PCI
+ depends on PCI
help
Say Y or M if you want to add support for SoC audio using
loongson I2S controller.
--
2.39.2
next prev parent reply other threads:[~2023-06-16 9:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 9:00 [PATCH 1/4] ASoC: max98388: fix unused function warnings Arnd Bergmann
2023-06-16 9:00 ` [PATCH 2/4] ASoC: loongson: fix unused PM function warning Arnd Bergmann
2023-06-17 4:08 ` Randy Dunlap
2023-06-16 9:00 ` Arnd Bergmann [this message]
2023-06-17 4:21 ` [PATCH 3/4] ASoC: loongson: add PCI dependency Randy Dunlap
2023-06-16 9:00 ` [PATCH 4/4] ASoC: loongson: fix compile testing on 32-bit Arnd Bergmann
2023-06-17 4:06 ` Randy Dunlap
2023-06-16 13:33 ` [PATCH 1/4] ASoC: max98388: fix unused function warnings Mark Brown
2023-06-17 4:10 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230616090156.2347850-3-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mengyingkun@loongson.cn \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.