All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com
Cc: robh@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org,
	linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, steev@kali.org,
	quic_srichara@quicinc.com,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	stable@vger.kernel.org
Subject: [PATCH v4 1/9] PCI: qcom: Disable write access to read only registers for IP v2.3.3
Date: Mon, 19 Jun 2023 20:34:00 +0530	[thread overview]
Message-ID: <20230619150408.8468-2-manivannan.sadhasivam@linaro.org> (raw)
In-Reply-To: <20230619150408.8468-1-manivannan.sadhasivam@linaro.org>

In the post init sequence of v2.9.0, write access to read only registers
are not disabled after updating the registers. Fix it by disabling the
access after register update.

Cc: <stable@vger.kernel.org>
Fixes: 5d76117f070d ("PCI: qcom: Add support for IPQ8074 PCIe controller")
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 drivers/pci/controller/dwc/pcie-qcom.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
index 4ab30892f6ef..ef385d36d653 100644
--- a/drivers/pci/controller/dwc/pcie-qcom.c
+++ b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -836,6 +836,8 @@ static int qcom_pcie_post_init_2_3_3(struct qcom_pcie *pcie)
 	writel(PCI_EXP_DEVCTL2_COMP_TMOUT_DIS, pci->dbi_base + offset +
 		PCI_EXP_DEVCTL2);
 
+	dw_pcie_dbi_ro_wr_dis(pci);
+
 	return 0;
 }
 
-- 
2.25.1


  reply	other threads:[~2023-06-19 15:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-19 15:03 [PATCH v4 0/9] PCI: qcom: Do not advertise hotplug capability Manivannan Sadhasivam
2023-06-19 15:04 ` Manivannan Sadhasivam [this message]
2023-06-19 15:04 ` [PATCH v4 2/9] PCI: qcom: Use DWC helpers for modifying the read-only DBI registers Manivannan Sadhasivam
2023-06-19 15:04 ` [PATCH v4 3/9] PCI: qcom: Disable write access to read only registers for IP v2.9.0 Manivannan Sadhasivam
2023-06-19 15:04 ` [PATCH v4 4/9] PCI: qcom: Do not advertise hotplug capability for IPs v2.7.0 and v1.9.0 Manivannan Sadhasivam
2023-06-19 15:04 ` [PATCH v4 5/9] PCI: qcom: Do not advertise hotplug capability for IPs v2.3.3 and v2.9.0 Manivannan Sadhasivam
2023-06-19 15:04 ` [PATCH v4 6/9] PCI: qcom: Do not advertise hotplug capability for IP v2.3.2 Manivannan Sadhasivam
2023-06-19 15:04 ` [PATCH v4 7/9] PCI: qcom: Use post init sequence of IP v2.3.2 for v2.4.0 Manivannan Sadhasivam
2023-06-19 15:04 ` [PATCH v4 8/9] PCI: qcom: Do not advertise hotplug capability for IP v1.0.0 Manivannan Sadhasivam
2023-06-19 15:04 ` [PATCH v4 9/9] PCI: qcom: Do not advertise hotplug capability for IP v2.1.0 Manivannan Sadhasivam
2023-06-20 10:13 ` [PATCH v4 0/9] PCI: qcom: Do not advertise hotplug capability Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230619150408.8468-2-manivannan.sadhasivam@linaro.org \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=andersson@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=kw@linux.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=quic_srichara@quicinc.com \
    --cc=robh@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=steev@kali.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.