From: Miquel Raynal <miquel.raynal@bootlin.com> To: Mark Brown <broonie@kernel.org>, <linux-spi@vger.kernel.org> Cc: Tudor Ambarus <tudor.ambarus@linaro.org>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Nicolas Ferre <nicolas.ferre@microchip.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Claudiu Beznea <claudiu.beznea@microchip.com>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, <linux-arm-kernel@lists.infradead.org>, linux-sunxi@lists.linux.dev, Miquel Raynal <miquel.raynal@bootlin.com> Subject: [PATCH v2 3/3] spi: sun6i: Use the new helper to derive the xfer timeout value Date: Mon, 19 Jun 2023 17:53:49 +0200 [thread overview] Message-ID: <20230619155349.3118420-4-miquel.raynal@bootlin.com> (raw) In-Reply-To: <20230619155349.3118420-1-miquel.raynal@bootlin.com> A helper was recently added to the core to factorize common code between drivers, like the amount of time a driver should wait for a transfer to happen. It is of course possible to use a default value (like eg. 1s) but it is way stronger to adapt this amount of time to the transfer. Indeed, long transfers (eg. 4MiB) on a slow single-spi bus might take more than the usual second of timeout and prevent lengthy transfers. The core helper was heavily inspired by the logic applied in this driver, the only difference being the minimum amount of time which was enlarged from 0.1s to 0.5s. Use this helper instead of open-coding it. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/spi/spi-sun6i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c index 23ad052528db..180094dfae19 100644 --- a/drivers/spi/spi-sun6i.c +++ b/drivers/spi/spi-sun6i.c @@ -422,7 +422,7 @@ static int sun6i_spi_transfer_one(struct spi_master *master, reg = sun6i_spi_read(sspi, SUN6I_TFR_CTL_REG); sun6i_spi_write(sspi, SUN6I_TFR_CTL_REG, reg | SUN6I_TFR_CTL_XCH); - tx_time = max(tfr->len * 8 * 2 / (tfr->speed_hz / 1000), 100U); + tx_time = spi_controller_xfer_timeout(master, tfr); start = jiffies; timeout = wait_for_completion_timeout(&sspi->done, msecs_to_jiffies(tx_time)); -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com> To: Mark Brown <broonie@kernel.org>, <linux-spi@vger.kernel.org> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>, Samuel Holland <samuel@sholland.org>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Tudor Ambarus <tudor.ambarus@linaro.org>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Miquel Raynal <miquel.raynal@bootlin.com>, linux-sunxi@lists.linux.dev, Claudiu Beznea <claudiu.beznea@microchip.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 3/3] spi: sun6i: Use the new helper to derive the xfer timeout value Date: Mon, 19 Jun 2023 17:53:49 +0200 [thread overview] Message-ID: <20230619155349.3118420-4-miquel.raynal@bootlin.com> (raw) In-Reply-To: <20230619155349.3118420-1-miquel.raynal@bootlin.com> A helper was recently added to the core to factorize common code between drivers, like the amount of time a driver should wait for a transfer to happen. It is of course possible to use a default value (like eg. 1s) but it is way stronger to adapt this amount of time to the transfer. Indeed, long transfers (eg. 4MiB) on a slow single-spi bus might take more than the usual second of timeout and prevent lengthy transfers. The core helper was heavily inspired by the logic applied in this driver, the only difference being the minimum amount of time which was enlarged from 0.1s to 0.5s. Use this helper instead of open-coding it. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/spi/spi-sun6i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c index 23ad052528db..180094dfae19 100644 --- a/drivers/spi/spi-sun6i.c +++ b/drivers/spi/spi-sun6i.c @@ -422,7 +422,7 @@ static int sun6i_spi_transfer_one(struct spi_master *master, reg = sun6i_spi_read(sspi, SUN6I_TFR_CTL_REG); sun6i_spi_write(sspi, SUN6I_TFR_CTL_REG, reg | SUN6I_TFR_CTL_XCH); - tx_time = max(tfr->len * 8 * 2 / (tfr->speed_hz / 1000), 100U); + tx_time = spi_controller_xfer_timeout(master, tfr); start = jiffies; timeout = wait_for_completion_timeout(&sspi->done, msecs_to_jiffies(tx_time)); -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-19 15:54 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-19 15:53 [PATCH v2 0/3] spi: Helper for deriving timeout values Miquel Raynal 2023-06-19 15:53 ` Miquel Raynal 2023-06-19 15:53 ` [PATCH v2 1/3] spi: Create a helper to derive adaptive timeouts Miquel Raynal 2023-06-19 15:53 ` Miquel Raynal 2023-06-19 15:53 ` [PATCH v2 2/3] spi: atmel: Prevent false timeouts on long transfers Miquel Raynal 2023-06-19 15:53 ` Miquel Raynal 2023-06-21 14:59 ` Mark Brown 2023-06-21 14:59 ` Mark Brown 2023-06-22 8:25 ` Miquel Raynal 2023-06-22 8:25 ` Miquel Raynal 2023-06-19 15:53 ` Miquel Raynal [this message] 2023-06-19 15:53 ` [PATCH v2 3/3] spi: sun6i: Use the new helper to derive the xfer timeout value Miquel Raynal 2023-06-21 15:51 ` Jernej Škrabec 2023-06-21 15:51 ` Jernej Škrabec 2023-06-26 16:47 ` [PATCH v2 0/3] spi: Helper for deriving timeout values Mark Brown 2023-06-26 16:47 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230619155349.3118420-4-miquel.raynal@bootlin.com \ --to=miquel.raynal@bootlin.com \ --cc=alexandre.belloni@bootlin.com \ --cc=broonie@kernel.org \ --cc=claudiu.beznea@microchip.com \ --cc=jernej.skrabec@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=nicolas.ferre@microchip.com \ --cc=samuel@sholland.org \ --cc=thomas.petazzoni@bootlin.com \ --cc=tudor.ambarus@linaro.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.