From: Julia Lawall <Julia.Lawall@inria.fr> To: Sumit Semwal <sumit.semwal@linaro.org> Cc: keescook@chromium.org, kernel-janitors@vger.kernel.org, "Benjamin Gaignard" <benjamin.gaignard@collabora.com>, "Liam Mark" <lmark@codeaurora.org>, "Laura Abbott" <labbott@redhat.com>, "Brian Starkey" <Brian.Starkey@arm.com>, "John Stultz" <jstultz@google.com>, "Christian König" <christian.koenig@amd.com>, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/26] dma-buf: system_heap: use array_size Date: Fri, 23 Jun 2023 23:14:37 +0200 [thread overview] Message-ID: <20230623211457.102544-7-Julia.Lawall@inria.fr> (raw) In-Reply-To: <20230623211457.102544-1-Julia.Lawall@inria.fr> Use array_size to protect against multiplication overflows. The changes were done using the following Coccinelle semantic patch: // <smpl> @@ size_t e1,e2; expression COUNT; identifier alloc = {vmalloc,vzalloc,kvmalloc,kvzalloc}; @@ ( alloc( - (e1) * (e2) + array_size(e1, e2) ,...) | alloc( - (e1) * (COUNT) + array_size(COUNT, e1) ,...) ) // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> --- drivers/dma-buf/heaps/system_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/heaps/system_heap.c b/drivers/dma-buf/heaps/system_heap.c index ee7059399e9c..fb7867599874 100644 --- a/drivers/dma-buf/heaps/system_heap.c +++ b/drivers/dma-buf/heaps/system_heap.c @@ -221,7 +221,7 @@ static void *system_heap_do_vmap(struct system_heap_buffer *buffer) { struct sg_table *table = &buffer->sg_table; int npages = PAGE_ALIGN(buffer->len) / PAGE_SIZE; - struct page **pages = vmalloc(sizeof(struct page *) * npages); + struct page **pages = vmalloc(array_size(npages, sizeof(struct page *))); struct page **tmp = pages; struct sg_page_iter piter; void *vaddr;
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <Julia.Lawall@inria.fr> To: Sumit Semwal <sumit.semwal@linaro.org> Cc: "Benjamin Gaignard" <benjamin.gaignard@collabora.com>, keescook@chromium.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, "Liam Mark" <lmark@codeaurora.org>, "Christian König" <christian.koenig@amd.com>, linaro-mm-sig@lists.linaro.org, "John Stultz" <jstultz@google.com>, dri-devel@lists.freedesktop.org, "Laura Abbott" <labbott@redhat.com>, linux-media@vger.kernel.org Subject: [PATCH 06/26] dma-buf: system_heap: use array_size Date: Fri, 23 Jun 2023 23:14:37 +0200 [thread overview] Message-ID: <20230623211457.102544-7-Julia.Lawall@inria.fr> (raw) In-Reply-To: <20230623211457.102544-1-Julia.Lawall@inria.fr> Use array_size to protect against multiplication overflows. The changes were done using the following Coccinelle semantic patch: // <smpl> @@ size_t e1,e2; expression COUNT; identifier alloc = {vmalloc,vzalloc,kvmalloc,kvzalloc}; @@ ( alloc( - (e1) * (e2) + array_size(e1, e2) ,...) | alloc( - (e1) * (COUNT) + array_size(COUNT, e1) ,...) ) // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> --- drivers/dma-buf/heaps/system_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/heaps/system_heap.c b/drivers/dma-buf/heaps/system_heap.c index ee7059399e9c..fb7867599874 100644 --- a/drivers/dma-buf/heaps/system_heap.c +++ b/drivers/dma-buf/heaps/system_heap.c @@ -221,7 +221,7 @@ static void *system_heap_do_vmap(struct system_heap_buffer *buffer) { struct sg_table *table = &buffer->sg_table; int npages = PAGE_ALIGN(buffer->len) / PAGE_SIZE; - struct page **pages = vmalloc(sizeof(struct page *) * npages); + struct page **pages = vmalloc(array_size(npages, sizeof(struct page *))); struct page **tmp = pages; struct sg_page_iter piter; void *vaddr;
next prev parent reply other threads:[~2023-06-23 21:15 UTC|newest] Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-23 21:14 [PATCH 00/26] use array_size Julia Lawall 2023-06-23 21:14 ` [Intel-gfx] " Julia Lawall 2023-06-23 21:14 ` Julia Lawall 2023-06-23 21:14 ` [PATCH 01/26] lib/test_vmalloc.c: " Julia Lawall 2023-06-23 21:14 ` [PATCH 02/26] octeon_ep: " Julia Lawall 2023-06-24 15:46 ` Simon Horman 2023-06-24 22:28 ` Jakub Kicinski 2023-06-25 20:14 ` Christophe JAILLET 2023-06-25 20:25 ` Julia Lawall 2023-06-25 20:32 ` Christophe JAILLET 2023-06-25 20:57 ` Julia Lawall 2023-06-23 21:14 ` [PATCH 03/26] drm/gud: " Julia Lawall 2023-06-23 21:14 ` Julia Lawall 2023-06-23 21:14 ` [PATCH 04/26] gve: " Julia Lawall 2023-06-24 15:47 ` Simon Horman 2023-06-23 21:14 ` [PATCH 05/26] RDMA/erdma: " Julia Lawall 2023-06-27 9:32 ` Cheng Xu 2023-06-23 21:14 ` Julia Lawall [this message] 2023-06-23 21:14 ` [PATCH 06/26] dma-buf: system_heap: " Julia Lawall 2023-06-23 21:42 ` John Stultz 2023-06-23 21:42 ` John Stultz 2023-06-23 21:14 ` [PATCH 07/26] scsi: fnic: " Julia Lawall 2023-06-23 21:14 ` [PATCH 08/26] virtio-mem: " Julia Lawall 2023-06-25 1:39 ` Xuan Zhuo 2023-06-25 1:39 ` Xuan Zhuo 2023-06-26 7:40 ` David Hildenbrand 2023-06-26 7:40 ` David Hildenbrand 2023-06-26 10:59 ` Michael S. Tsirkin 2023-06-26 10:59 ` Michael S. Tsirkin 2023-06-23 21:14 ` [PATCH 09/26] pds_core: " Julia Lawall 2023-06-24 15:47 ` Simon Horman 2023-06-26 16:02 ` Shannon Nelson 2023-06-23 21:14 ` [PATCH 10/26] bus: mhi: host: " Julia Lawall 2023-06-23 21:30 ` Jeffrey Hugo 2023-06-23 21:45 ` Julia Lawall 2023-06-23 22:09 ` Jeffrey Hugo 2023-06-23 23:45 ` Kees Cook 2023-06-24 16:06 ` Jeffrey Hugo 2023-06-26 11:46 ` Dan Carpenter 2023-06-26 14:53 ` Jeffrey Hugo 2023-06-23 21:14 ` [PATCH 11/26] ionic: " Julia Lawall 2023-06-24 15:47 ` Simon Horman 2023-06-26 16:03 ` Shannon Nelson 2023-06-23 21:14 ` [PATCH 12/26] btrfs: zoned: " Julia Lawall 2023-06-26 6:08 ` Johannes Thumshirn 2023-06-26 7:59 ` Naohiro Aota 2023-06-29 14:30 ` David Sterba 2023-06-23 21:14 ` [PATCH 13/26] iommu/tegra: gart: " Julia Lawall 2023-06-23 21:14 ` [PATCH 14/26] RDMA/siw: " Julia Lawall 2023-06-26 11:23 ` Bernard Metzler 2023-06-23 21:14 ` [PATCH 15/26] habanalabs: " Julia Lawall 2023-06-23 21:14 ` Julia Lawall 2023-06-23 21:14 ` [PATCH 16/26] drm/i915/gvt: " Julia Lawall 2023-06-23 21:14 ` [Intel-gfx] " Julia Lawall 2023-06-23 21:14 ` Julia Lawall 2023-06-26 9:26 ` [Intel-gfx] " Andi Shyti 2023-06-26 9:26 ` Andi Shyti 2023-06-26 9:26 ` Andi Shyti 2023-06-26 11:54 ` Dan Carpenter 2023-06-26 11:54 ` Dan Carpenter 2023-06-26 11:54 ` Dan Carpenter 2023-06-23 21:14 ` [PATCH 17/26] kcov: " Julia Lawall 2023-06-24 5:34 ` Dmitry Vyukov 2023-06-23 21:14 ` [PATCH 18/26] net: enetc: " Julia Lawall 2023-06-24 15:48 ` Simon Horman 2023-06-23 21:14 ` [PATCH 19/26] RDMA/bnxt_re: " Julia Lawall 2023-06-23 21:14 ` [PATCH 20/26] drm/vmwgfx: " Julia Lawall 2023-06-23 21:14 ` Julia Lawall 2023-06-27 17:33 ` Julia Lawall 2023-06-27 17:33 ` Julia Lawall 2023-06-23 21:14 ` [PATCH 21/26] x86/sgx: " Julia Lawall 2023-07-10 22:02 ` Jarkko Sakkinen 2023-06-23 21:14 ` [PATCH 22/26] net: mana: " Julia Lawall 2023-06-24 15:48 ` Simon Horman 2023-06-23 21:14 ` [PATCH 23/26] media: staging: imgu: " Julia Lawall 2023-06-25 4:59 ` Bingbu Cao 2023-06-27 17:35 ` Julia Lawall 2023-06-29 7:34 ` Sakari Ailus 2023-06-23 21:14 ` [PATCH 24/26] scsi: qla2xxx: " Julia Lawall 2023-06-23 21:14 ` [PATCH 25/26] vduse: " Julia Lawall 2023-06-23 21:14 ` [PATCH 26/26] comedi: " Julia Lawall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230623211457.102544-7-Julia.Lawall@inria.fr \ --to=julia.lawall@inria.fr \ --cc=Brian.Starkey@arm.com \ --cc=benjamin.gaignard@collabora.com \ --cc=christian.koenig@amd.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=jstultz@google.com \ --cc=keescook@chromium.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=labbott@redhat.com \ --cc=linaro-mm-sig@lists.linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=lmark@codeaurora.org \ --cc=sumit.semwal@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.