All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gaosheng Cui <cuigaosheng1@huawei.com>
To: <john.johansen@canonical.com>, <paul@paul-moore.com>,
	<jmorris@namei.org>, <serge@hallyn.com>,
	<cuigaosheng1@huawei.com>
Cc: <apparmor@lists.ubuntu.com>, <linux-security-module@vger.kernel.org>
Subject: [PATCH -next 11/11] apparmor: Fix kernel-doc warnings in apparmor/policy.c
Date: Sun, 25 Jun 2023 09:13:49 +0800	[thread overview]
Message-ID: <20230625011349.1457810-12-cuigaosheng1@huawei.com> (raw)
In-Reply-To: <20230625011349.1457810-1-cuigaosheng1@huawei.com>

Fix kernel-doc warnings:

security/apparmor/policy.c:294: warning: Function parameter or
member 'proxy' not described in 'aa_alloc_profile'
security/apparmor/policy.c:785: warning: Function parameter or
member 'label' not described in 'aa_policy_view_capable'
security/apparmor/policy.c:785: warning: Function parameter or
member 'ns' not described in 'aa_policy_view_capable'
security/apparmor/policy.c:847: warning: Function parameter or
member 'ns' not described in 'aa_may_manage_policy'
security/apparmor/policy.c:964: warning: Function parameter or
member 'hname' not described in '__lookup_replace'
security/apparmor/policy.c:964: warning: Function parameter or
member 'info' not described in '__lookup_replace'
security/apparmor/policy.c:964: warning: Function parameter or
member 'noreplace' not described in '__lookup_replace'
security/apparmor/policy.c:964: warning: Function parameter or
member 'ns' not described in '__lookup_replace'
security/apparmor/policy.c:964: warning: Function parameter or
member 'p' not described in '__lookup_replace'

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 security/apparmor/policy.c | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/security/apparmor/policy.c b/security/apparmor/policy.c
index 715fe1b66d12..4817c1b30105 100644
--- a/security/apparmor/policy.c
+++ b/security/apparmor/policy.c
@@ -285,6 +285,7 @@ void aa_free_profile(struct aa_profile *profile)
 /**
  * aa_alloc_profile - allocate, initialize and return a new profile
  * @hname: name of the profile  (NOT NULL)
+ * @proxy: proxy to use OR null if to allocate a new one
  * @gfp: allocation type
  *
  * Returns: refcount profile or NULL on failure
@@ -774,8 +775,9 @@ static int policy_ns_capable(struct aa_label *label,
 
 /**
  * aa_policy_view_capable - check if viewing policy in at @ns is allowed
- * label: label that is trying to view policy in ns
- * ns: namespace being viewed by @label (may be NULL if @label's ns)
+ * @label: label that is trying to view policy in ns
+ * @ns: namespace being viewed by @label (may be NULL if @label's ns)
+ *
  * Returns: true if viewing policy is allowed
  *
  * If @ns is NULL then the namespace being viewed is assumed to be the
@@ -839,6 +841,7 @@ bool aa_current_policy_admin_capable(struct aa_ns *ns)
 /**
  * aa_may_manage_policy - can the current task manage policy
  * @label: label to check if it can manage policy
+ * @ns: namespace being managed by @label (may be NULL if @label's ns)
  * @mask: contains the policy manipulation operation being done
  *
  * Returns: 0 if the task is allowed to manipulate policy else error
@@ -950,11 +953,11 @@ static void __replace_profile(struct aa_profile *old, struct aa_profile *new)
 
 /**
  * __lookup_replace - lookup replacement information for a profile
- * @ns - namespace the lookup occurs in
- * @hname - name of profile to lookup
- * @noreplace - true if not replacing an existing profile
- * @p - Returns: profile to be replaced
- * @info - Returns: info string on why lookup failed
+ * @ns: namespace the lookup occurs in
+ * @hname: name of profile to lookup
+ * @noreplace: true if not replacing an existing profile
+ * @p: Returns - profile to be replaced
+ * @info: Returns - info string on why lookup failed
  *
  * Returns: profile to replace (no ref) on success else ptr error
  */
-- 
2.25.1


  parent reply	other threads:[~2023-06-25  1:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-25  1:13 [PATCH -next 00/11] Fix kernel-doc warnings in apparmor Gaosheng Cui
2023-06-25  1:13 ` [PATCH -next 01/11] apparmor: Fix kernel-doc warnings in apparmor/audit.c Gaosheng Cui
2023-06-25  1:13 ` [PATCH -next 02/11] apparmor: Fix kernel-doc warnings in apparmor/capability.c Gaosheng Cui
2023-06-25  1:13 ` [PATCH -next 03/11] apparmor: Fix kernel-doc warnings in apparmor/domain.c Gaosheng Cui
2023-06-25  1:13 ` [PATCH -next 04/11] apparmor: Fix kernel-doc warnings in apparmor/file.c Gaosheng Cui
2023-06-25  1:13 ` [PATCH -next 05/11] apparmor: Fix kernel-doc warnings in apparmor/label.c Gaosheng Cui
2023-07-07 13:56   ` Georgia Garcia
2023-06-25  1:13 ` [PATCH -next 06/11] apparmor: Fix kernel-doc warnings in apparmor/lib.c Gaosheng Cui
2023-06-25  1:13 ` [PATCH -next 07/11] apparmor: Fix kernel-doc warnings in apparmor/match.c Gaosheng Cui
2023-06-25  1:13 ` [PATCH -next 08/11] apparmor: Fix kernel-doc warnings in apparmor/resource.c Gaosheng Cui
2023-06-25  1:13 ` [PATCH -next 09/11] apparmor: Fix kernel-doc warnings in apparmor/policy_unpack.c Gaosheng Cui
2023-06-25  1:13 ` [PATCH -next 10/11] apparmor: Fix kernel-doc warnings in apparmor/policy_compat.c Gaosheng Cui
2023-07-07 13:56   ` Georgia Garcia
2023-06-25  1:13 ` Gaosheng Cui [this message]
2023-07-10  8:45 ` [PATCH -next 00/11] Fix kernel-doc warnings in apparmor John Johansen
2023-07-13  9:21   ` cuigaosheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230625011349.1457810-12-cuigaosheng1@huawei.com \
    --to=cuigaosheng1@huawei.com \
    --cc=apparmor@lists.ubuntu.com \
    --cc=jmorris@namei.org \
    --cc=john.johansen@canonical.com \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.