All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Rob Clark <robdclark@gmail.com>,
	 Abhinav Kumar <quic_abhinavk@quicinc.com>,
	 Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Sean Paul <sean@poorly.run>,  David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	 Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>
Cc: devicetree@vger.kernel.org,
	Neil Armstrong <neil.armstrong@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	freedreno@lists.freedesktop.org
Subject: [PATCH v2 13/14] drm/msm/a6xx: Vastly increase HFI timeout
Date: Tue, 08 Aug 2023 23:02:51 +0200	[thread overview]
Message-ID: <20230628-topic-a7xx_drmmsm-v2-13-1439e1b2343f@linaro.org> (raw)
In-Reply-To: <20230628-topic-a7xx_drmmsm-v2-0-1439e1b2343f@linaro.org>

A7xx GMUs can be slow as molasses at times.
Increase the timeout to 1 second to match the vendor driver.

Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD
Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> # sm8450
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 drivers/gpu/drm/msm/adreno/a6xx_hfi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/adreno/a6xx_hfi.c b/drivers/gpu/drm/msm/adreno/a6xx_hfi.c
index cdb3f6e74d3e..e25ddb82a087 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_hfi.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_hfi.c
@@ -108,7 +108,7 @@ static int a6xx_hfi_wait_for_ack(struct a6xx_gmu *gmu, u32 id, u32 seqnum,
 
 	/* Wait for a response */
 	ret = gmu_poll_timeout(gmu, REG_A6XX_GMU_GMU2HOST_INTR_INFO, val,
-		val & A6XX_GMU_GMU2HOST_INTR_INFO_MSGQ, 100, 5000);
+		val & A6XX_GMU_GMU2HOST_INTR_INFO_MSGQ, 100, 1000000);
 
 	if (ret) {
 		DRM_DEV_ERROR(gmu->dev,

-- 
2.41.0


WARNING: multiple messages have this Message-ID (diff)
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Rob Clark <robdclark@gmail.com>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Neil Armstrong <neil.armstrong@linaro.org>
Subject: [PATCH v2 13/14] drm/msm/a6xx: Vastly increase HFI timeout
Date: Tue, 08 Aug 2023 23:02:51 +0200	[thread overview]
Message-ID: <20230628-topic-a7xx_drmmsm-v2-13-1439e1b2343f@linaro.org> (raw)
In-Reply-To: <20230628-topic-a7xx_drmmsm-v2-0-1439e1b2343f@linaro.org>

A7xx GMUs can be slow as molasses at times.
Increase the timeout to 1 second to match the vendor driver.

Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD
Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> # sm8450
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 drivers/gpu/drm/msm/adreno/a6xx_hfi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/adreno/a6xx_hfi.c b/drivers/gpu/drm/msm/adreno/a6xx_hfi.c
index cdb3f6e74d3e..e25ddb82a087 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_hfi.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_hfi.c
@@ -108,7 +108,7 @@ static int a6xx_hfi_wait_for_ack(struct a6xx_gmu *gmu, u32 id, u32 seqnum,
 
 	/* Wait for a response */
 	ret = gmu_poll_timeout(gmu, REG_A6XX_GMU_GMU2HOST_INTR_INFO, val,
-		val & A6XX_GMU_GMU2HOST_INTR_INFO_MSGQ, 100, 5000);
+		val & A6XX_GMU_GMU2HOST_INTR_INFO_MSGQ, 100, 1000000);
 
 	if (ret) {
 		DRM_DEV_ERROR(gmu->dev,

-- 
2.41.0


  parent reply	other threads:[~2023-08-08 21:03 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 21:02 [PATCH v2 00/14] A7xx support Konrad Dybcio
2023-08-08 21:02 ` Konrad Dybcio
2023-08-08 21:02 ` [PATCH v2 01/14] dt-bindings: display/msm/gmu: Add Adreno 7[34]0 GMU Konrad Dybcio
2023-08-08 21:02   ` Konrad Dybcio
2023-08-08 21:02 ` [PATCH v2 02/14] dt-bindings: display/msm/gmu: Allow passing QMP handle Konrad Dybcio
2023-08-08 21:02   ` Konrad Dybcio
2023-08-15  5:43   ` Krzysztof Kozlowski
2023-08-15  5:43     ` Krzysztof Kozlowski
2023-08-08 21:02 ` [PATCH v2 03/14] dt-bindings: display/msm/gpu: Allow A7xx SKUs Konrad Dybcio
2023-08-08 21:02   ` Konrad Dybcio
2023-08-08 21:02 ` [PATCH v2 04/14] drm/msm/a6xx: Add missing regs for A7XX Konrad Dybcio
2023-08-08 21:02   ` Konrad Dybcio
2023-08-08 21:02 ` [PATCH v2 05/14] drm/msm/a6xx: Introduce a6xx_llc_read Konrad Dybcio
2023-08-08 21:02   ` Konrad Dybcio
2023-08-08 21:02 ` [PATCH v2 06/14] drm/msm/a6xx: Move LLC accessors to the common header Konrad Dybcio
2023-08-08 21:02   ` Konrad Dybcio
2023-08-08 21:02 ` [PATCH v2 07/14] drm/msm/a6xx: Bail out early if setting GPU OOB fails Konrad Dybcio
2023-08-08 21:02   ` Konrad Dybcio
2023-08-08 21:02 ` [PATCH v2 08/14] drm/msm/a6xx: Add skeleton A7xx support Konrad Dybcio
2023-08-08 21:02   ` Konrad Dybcio
2023-08-14 20:59   ` Rob Clark
2023-08-14 20:59     ` Rob Clark
2023-08-08 21:02 ` [PATCH v2 09/14] drm/msm/a6xx: Send ACD state to QMP at GMU resume Konrad Dybcio
2023-08-08 21:02   ` Konrad Dybcio
2023-08-08 21:02 ` [PATCH v2 10/14] drm/msm/a6xx: Mostly implement A7xx gpu_state Konrad Dybcio
2023-08-08 21:02   ` Konrad Dybcio
2023-08-08 21:02 ` [PATCH v2 11/14] drm/msm/a6xx: Add A730 support Konrad Dybcio
2023-08-08 21:02   ` Konrad Dybcio
2023-08-08 21:02 ` [PATCH v2 12/14] drm/msm/a6xx: Add A740 support Konrad Dybcio
2023-08-08 21:02   ` Konrad Dybcio
2023-08-08 21:02 ` Konrad Dybcio [this message]
2023-08-08 21:02   ` [PATCH v2 13/14] drm/msm/a6xx: Vastly increase HFI timeout Konrad Dybcio
2023-08-09 22:15   ` Rob Clark
2023-08-09 22:15     ` Rob Clark
2023-08-08 21:02 ` [PATCH v2 14/14] drm/msm/a6xx: Poll for GBIF unhalt status in hw_init Konrad Dybcio
2023-08-08 21:02   ` Konrad Dybcio
2023-08-09 22:08 ` [PATCH v2 00/14] A7xx support Rob Clark
2023-08-09 22:08   ` Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230628-topic-a7xx_drmmsm-v2-13-1439e1b2343f@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.